[{"id":34242,"web_url":"https://patchwork.libcamera.org/comment/34242/","msgid":"<174731376232.329449.12226357814493943179@calcite>","date":"2025-05-15T12:56:02","subject":"Re: [PATCH v1 1/2] libcamera: converter_v4l2_m2m: Add missing\n\t`` include","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-15 14:30:38)\n> `std::set` is directly used in the file, but not directly included.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index ee05b798f..0ce7a7a67 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -10,6 +10,7 @@\n> \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFA70C3200\n\tfor ;\n\tThu, 15 May 2025 12:56:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9447168B6F;\n\tThu, 15 May 2025 14:56:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F066F68B4F\n\tfor ;\n\tThu, 15 May 2025 14:56:05 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2a01:cb16:204c:4644:2597:989f:e013:9296])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4363836;\n\tThu, 15 May 2025 14:55:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dVpax6G9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747313748;\n\tbh=8VGQ+UNB5yyKMN4KIwI175M1gg8KM/x6twPTWYB15YI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=dVpax6G9Krnbw97rt/N/bXZKP5vU9Zi2E4YUPwYhTaXSdnjp1PLotcPImAZoFkc3j\n\tyjv40N4wey/zsGut+Lk6I9yUX9Dz8qrKQ1P5c53oUwYGwPkxt0apvKBpm7fhjBEA98\n\tnqPwRpsALIB8VI6HRpDTHMRSyt699Wp4vqbwxkS0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250515123039.3134682-1-barnabas.pocze@ideasonboard.com>","References":"<20250515123039.3134682-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 1/2] libcamera: converter_v4l2_m2m: Add missing\n\t`` include","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 15 May 2025 14:56:02 +0200","Message-ID":"<174731376232.329449.12226357814493943179@calcite>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34256,"web_url":"https://patchwork.libcamera.org/comment/34256/","msgid":"<174739902853.1694779.8229395502288302091@ping.linuxembedded.co.uk>","date":"2025-05-16T12:37:08","subject":"Re: [PATCH v1 1/2] libcamera: converter_v4l2_m2m: Add missing\n\t`` include","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2025-05-15 13:56:02)\n> Quoting Barnabás Pőcze (2025-05-15 14:30:38)\n> > `std::set` is directly used in the file, but not directly included.\n> > \n> > Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > index ee05b798f..0ce7a7a67 100644\n> > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > @@ -10,6 +10,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > \n> > #include \n> > #include \n> > -- \n> > 2.49.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16AECBD78E\n\tfor ;\n\tFri, 16 May 2025 12:37:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 058E668B70;\n\tFri, 16 May 2025 14:37:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92F9168B66\n\tfor ;\n\tFri, 16 May 2025 14:37:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7D4D1D8;\n\tFri, 16 May 2025 14:36:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D+J0YAtI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747399013;\n\tbh=h/1xzJQyshRpIye13nV2rV0weBaQeGjqkorjs58dl2Q=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=D+J0YAtItJK9nqQnByO7UfeHu/i96joUe0Y8tA6V8HColJNxaQ6tc5h/yFMq5By8H\n\tqMNuXI0W6d91IYfbsal0XRjlNL1P1uwFWu1cXkoQHABvTQaLCAkKTt4B1OAvms1ZgD\n\tWzxIlg0OsW8azadzhF/kIeC/BnjxpocJk9gkE1Kk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<174731376232.329449.12226357814493943179@calcite>","References":"<20250515123039.3134682-1-barnabas.pocze@ideasonboard.com>\n\t<174731376232.329449.12226357814493943179@calcite>","Subject":"Re: [PATCH v1 1/2] libcamera: converter_v4l2_m2m: Add missing\n\t`` include","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tPaul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 16 May 2025 13:37:08 +0100","Message-ID":"<174739902853.1694779.8229395502288302091@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]