[{"id":34240,"web_url":"https://patchwork.libcamera.org/comment/34240/","msgid":"<174731206308.209691.16548254841562645488@calcite>","date":"2025-05-15T12:27:43","subject":"Re: [RFC PATCH v1 5/8] utils: codegen: ipc: Simplify `return`\n\tstatements","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-15 14:00:09)\n> Returning an expression of type `void` from a function returning `void`\n> is legal, so do not handle those cases specially.\n\nOh I didn't know that, neat.\n\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index effc8f7dd..9a3aadbd2 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -127,13 +127,13 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> {{proxy_funcs.func_sig(proxy_name, method)}}\n> {\n> if (isolate_)\n> - {{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}IPC(\n> + return {{method.mojom_name}}IPC(\n> {%- for param in method|method_param_names -%}\n> {{param}}{{- \", \" if not loop.last}}\n> {%- endfor -%}\n> );\n> else\n> - {{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}Thread(\n> + return {{method.mojom_name}}Thread(\n> {%- for param in method|method_param_names -%}\n> {{param}}{{- \", \" if not loop.last}}\n> {%- endfor -%}\n> @@ -159,16 +159,14 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> state_ = ProxyRunning;\n> thread_.start();\n> \n> - {{ \"return \" if method|method_return_value != \"void\" -}}\n> - proxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking\n> + return proxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking\n> {{- \", \" if method|method_param_names}}\n> {%- for param in method|method_param_names -%}\n> {{param}}{{- \", \" if not loop.last}}\n> {%- endfor -%}\n> );\n> {%- elif not method|is_async %}\n> - {{ \"return \" if method|method_return_value != \"void\" -}}\n> - ipa_->{{method.mojom_name}}(\n> + return ipa_->{{method.mojom_name}}(\n> {%- for param in method|method_param_names -%}\n> {{param}}{{- \", \" if not loop.last}}\n> {%- endfor -%}\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29797C3220\n\tfor ;\n\tThu, 15 May 2025 12:27:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4B0268D6C;\n\tThu, 15 May 2025 14:27:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5ED0968B6E\n\tfor ;\n\tThu, 15 May 2025 14:27:46 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2a01:cb16:204c:4644:2597:989f:e013:9296])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EAB6836;\n\tThu, 15 May 2025 14:27:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oizIIsyK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747312049;\n\tbh=/6nQRU3D3ZRYLqhPhqFX1Agu9QEiUDPl/Nonn4TBFw4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oizIIsyK3rI+ptGabuFCEJiK8bnQZd4zLd5n/gYYxk4GH4smQD3aOKwIdCl+UWHou\n\tWD2mOIBICyTGdBr/S/gFA81NNSofBA5Fnc2TL3JiNL8l+FKLHeyKUhTse0DJ2Png1U\n\tjlM/g93srn7kGEb1GRJGfuWMzzJ37DcvOyJ2Wk0k=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250515120012.3127231-6-barnabas.pocze@ideasonboard.com>","References":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>\n\t<20250515120012.3127231-6-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1 5/8] utils: codegen: ipc: Simplify `return`\n\tstatements","From":"Paul Elder ","Cc":"","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 15 May 2025 14:27:43 +0200","Message-ID":"<174731206308.209691.16548254841562645488@calcite>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34293,"web_url":"https://patchwork.libcamera.org/comment/34293/","msgid":"","date":"2025-05-20T11:49:21","subject":"Re: [RFC PATCH v1 5/8] utils: codegen: ipc: Simplify `return`\n\tstatements","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Thu, May 15, 2025 at 02:00:09PM +0200, Barnabás Pőcze wrote:\n> Returning an expression of type `void` from a function returning `void`\n> is legal, so do not handle those cases specially.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n>\n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index effc8f7dd..9a3aadbd2 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -127,13 +127,13 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> {{proxy_funcs.func_sig(proxy_name, method)}}\n> {\n> \tif (isolate_)\n> -\t\t{{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}IPC(\n> +\t\treturn {{method.mojom_name}}IPC(\n> {%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> {%- endfor -%}\n> );\n> \telse\n> -\t\t{{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}Thread(\n> +\t\treturn {{method.mojom_name}}Thread(\n> {%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> {%- endfor -%}\n> @@ -159,16 +159,14 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> \tstate_ = ProxyRunning;\n> \tthread_.start();\n>\n> -\t{{ \"return \" if method|method_return_value != \"void\" -}}\n> -\tproxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking\n> +\treturn proxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking\n> \t{{- \", \" if method|method_param_names}}\n> \t{%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> \t{%- endfor -%}\n> );\n> {%- elif not method|is_async %}\n> -\t{{ \"return \" if method|method_return_value != \"void\" -}}\n> -\tipa_->{{method.mojom_name}}(\n> +\treturn ipa_->{{method.mojom_name}}(\n> \t{%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> \t{%- endfor -%}\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48BCBC31E9\n\tfor ;\n\tTue, 20 May 2025 11:49:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1FAD68D85;\n\tTue, 20 May 2025 13:49:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D524614DE\n\tfor ;\n\tTue, 20 May 2025 13:49:24 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E38339E5;\n\tTue, 20 May 2025 13:49:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vrFEE6T6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747741744;\n\tbh=mN8KALtvLXTQ6AKjZJsQVwR7Z0wU+y43fG85hOJI2IE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vrFEE6T691k7K/K5Bew8N6+Pz5DZ4ZD9QtsL+Idx5UF4GzQG7Z+PLnY5SuvTC8JD+\n\tdWy2qKpBSYdHph8iIaEIiUeAvwYB4dySmKG91aQYNaa/dfolw7lciDE2zptuGi0NH8\n\tGf8FHPZ+uwAzTc/+Te7ycJsNpqdOAFrPh5c3WAaU=","Date":"Tue, 20 May 2025 13:49:21 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPaul Elder ","Subject":"Re: [RFC PATCH v1 5/8] utils: codegen: ipc: Simplify `return`\n\tstatements","Message-ID":"","References":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>\n\t<20250515120012.3127231-6-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250515120012.3127231-6-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]