[{"id":34238,"web_url":"https://patchwork.libcamera.org/comment/34238/","msgid":"<174731183343.209691.17729712032247584311@calcite>","date":"2025-05-15T12:23:53","subject":"Re: [RFC PATCH v1 3/8] utils: codegen: ipc: Add `deserializer()`\n\tfunction","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-15 14:00:07)\n> Add `deserializer()` in `serializer.tmpl` to have a single function\n> that generates all the necessary functions into the template specialization\n> like `serializer()`. This also avoids the duplication of some\n> conditional logic.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> .../libcamera_templates/core_ipa_serializer.h.tmpl | 7 +------\n> .../module_ipa_serializer.h.tmpl | 7 +------\n> .../generators/libcamera_templates/serializer.tmpl | 14 ++++++++++++++\n> 3 files changed, 16 insertions(+), 12 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl\n> index cbb35ef51..ac84963dc 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl\n> @@ -32,12 +32,7 @@ class IPADataSerializer<{{struct|name}}>\n> {\n> public:\n> {{- serializer.serializer(struct)}}\n> -{%- if struct|has_fd %}\n> -{{serializer.deserializer_fd(struct)}}\n> -{%- else %}\n> -{{serializer.deserializer_no_fd(struct)}}\n> -{{serializer.deserializer_fd_simple(struct)}}\n> -{%- endif %}\n> +{{- serializer.deserializer(struct)}}\n> };\n> {% endfor %}\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl\n> index f3b8e3b15..65a7dd11c 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl\n> @@ -33,12 +33,7 @@ class IPADataSerializer<{{struct|name_full}}>\n> {\n> public:\n> {{- serializer.serializer(struct)}}\n> -{%- if struct|has_fd %}\n> -{{serializer.deserializer_fd(struct)}}\n> -{%- else %}\n> -{{serializer.deserializer_no_fd(struct)}}\n> -{{serializer.deserializer_fd_simple(struct)}}\n> -{%- endif %}\n> +{{- serializer.deserializer(struct)}}\n> };\n> {% endfor %}\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl b/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl\n> index 114e349c9..d07836cc1 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl\n> @@ -317,3 +317,17 @@\n> return ret;\n> }\n> {%- endmacro %}\n> +\n> +{#\n> + # \\brief Deserialize a struct\n> + #\n> + # Generate code for IPADataSerializer specialization, for deserializing \\a struct.\n> + #}\n> +{%- macro deserializer(struct) %}\n> +{%- if struct|has_fd %}\n> +{{deserializer_fd(struct)}}\n> +{%- else %}\n> +{{deserializer_no_fd(struct)}}\n> +{{deserializer_fd_simple(struct)}}\n> +{%- endif %}\n> +{%- endmacro %}\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AFD5C3200\n\tfor ;\n\tThu, 15 May 2025 12:24:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B2F468C92;\n\tThu, 15 May 2025 14:23:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79DA268B6C\n\tfor ;\n\tThu, 15 May 2025 14:23:58 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2a01:cb16:204c:4644:2597:989f:e013:9296])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E512B836;\n\tThu, 15 May 2025 14:23:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HLHEM4cD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747311821;\n\tbh=BV8CJl6qFIGUgtzHQu93me3vreNDO7diHinBFVKxDHY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=HLHEM4cDMXciVlhF35QDZzdVmcs03yQfBIVBey4NJEsOg4StLqsP1dUD/qer3bEhK\n\tSFT5LGfC+/Jn3XiTcyuev0b6QmANOQD3+vkR9JkASkkkKhkg2tlPIXO4patqoTvTvK\n\tv63s6OtrCbydXxyyYYviJjR/xlx/eb0ZOfsABlxs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250515120012.3127231-4-barnabas.pocze@ideasonboard.com>","References":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>\n\t<20250515120012.3127231-4-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1 3/8] utils: codegen: ipc: Add `deserializer()`\n\tfunction","From":"Paul Elder ","Cc":"","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 15 May 2025 14:23:53 +0200","Message-ID":"<174731183343.209691.17729712032247584311@calcite>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34291,"web_url":"https://patchwork.libcamera.org/comment/34291/","msgid":"<7qdiidvarg6m6xyyfg3lv3odwbseuq3wlq2ph4kovucedro2wr@oami25xxsdnp>","date":"2025-05-20T11:48:07","subject":"Re: [RFC PATCH v1 3/8] utils: codegen: ipc: Add `deserializer()`\n\tfunction","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Thu, May 15, 2025 at 02:00:07PM +0200, Barnabás Pőcze wrote:\n> Add `deserializer()` in `serializer.tmpl` to have a single function\n> that generates all the necessary functions into the template specialization\n> like `serializer()`. This also avoids the duplication of some\n> conditional logic.\n>\n> Signed-off-by: Barnabás Pőcze \n\nLooks good to me\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> .../libcamera_templates/core_ipa_serializer.h.tmpl | 7 +------\n> .../module_ipa_serializer.h.tmpl | 7 +------\n> .../generators/libcamera_templates/serializer.tmpl | 14 ++++++++++++++\n> 3 files changed, 16 insertions(+), 12 deletions(-)\n>\n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl\n> index cbb35ef51..ac84963dc 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl\n> @@ -32,12 +32,7 @@ class IPADataSerializer<{{struct|name}}>\n> {\n> public:\n> {{- serializer.serializer(struct)}}\n> -{%- if struct|has_fd %}\n> -{{serializer.deserializer_fd(struct)}}\n> -{%- else %}\n> -{{serializer.deserializer_no_fd(struct)}}\n> -{{serializer.deserializer_fd_simple(struct)}}\n> -{%- endif %}\n> +{{- serializer.deserializer(struct)}}\n> };\n> {% endfor %}\n>\n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl\n> index f3b8e3b15..65a7dd11c 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_serializer.h.tmpl\n> @@ -33,12 +33,7 @@ class IPADataSerializer<{{struct|name_full}}>\n> {\n> public:\n> {{- serializer.serializer(struct)}}\n> -{%- if struct|has_fd %}\n> -{{serializer.deserializer_fd(struct)}}\n> -{%- else %}\n> -{{serializer.deserializer_no_fd(struct)}}\n> -{{serializer.deserializer_fd_simple(struct)}}\n> -{%- endif %}\n> +{{- serializer.deserializer(struct)}}\n> };\n> {% endfor %}\n>\n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl b/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl\n> index 114e349c9..d07836cc1 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/serializer.tmpl\n> @@ -317,3 +317,17 @@\n> \t\treturn ret;\n> \t}\n> {%- endmacro %}\n> +\n> +{#\n> + # \\brief Deserialize a struct\n> + #\n> + # Generate code for IPADataSerializer specialization, for deserializing \\a struct.\n> + #}\n> +{%- macro deserializer(struct) %}\n> +{%- if struct|has_fd %}\n> +{{deserializer_fd(struct)}}\n> +{%- else %}\n> +{{deserializer_no_fd(struct)}}\n> +{{deserializer_fd_simple(struct)}}\n> +{%- endif %}\n> +{%- endmacro %}\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDEEAC31E9\n\tfor ;\n\tTue, 20 May 2025 11:48:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1184668B67;\n\tTue, 20 May 2025 13:48:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CB58614DE\n\tfor ;\n\tTue, 20 May 2025 13:48:11 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7712A446;\n\tTue, 20 May 2025 13:47:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MxPhgJQP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747741670;\n\tbh=Z/r81fT000qJsROu+2UvhVeQr+J2vtEUxHi3k5Q3nyY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MxPhgJQP9J7a8ADKpPs2XGWS++QJ57mf3Dl+do/0533Ozb7G6hInGJ/SLJRtKprQF\n\tdGkbrNMpsKdre4wNpuKxFHlNnYc4NHc2NGyGP2lxpszVNYaDgfSj/CQj+E7p7IH7M1\n\t7i+o+hx+HI9bbB2dpOlgAN5ymK3mpGEDF5I6Oi08=","Date":"Tue, 20 May 2025 13:48:07 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPaul Elder ","Subject":"Re: [RFC PATCH v1 3/8] utils: codegen: ipc: Add `deserializer()`\n\tfunction","Message-ID":"<7qdiidvarg6m6xyyfg3lv3odwbseuq3wlq2ph4kovucedro2wr@oami25xxsdnp>","References":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>\n\t<20250515120012.3127231-4-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250515120012.3127231-4-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]