[{"id":34236,"web_url":"https://patchwork.libcamera.org/comment/34236/","msgid":"<174731119890.209691.8174756414249649624@calcite>","date":"2025-05-15T12:13:18","subject":"Re: [RFC PATCH v1 1/8] utils: codegen: ipc: Use `any()` instead of\n\t`len([]) > 0`","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-15 14:00:05)\n> Use `any()` with a generator expression instead of constructing\n> a list and checking its length.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> .../ipc/generators/mojom_libcamera_generator.py | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/mojom_libcamera_generator.py b/utils/codegen/ipc/generators/mojom_libcamera_generator.py\n> index d9c620a05..eff29a5b8 100644\n> --- a/utils/codegen/ipc/generators/mojom_libcamera_generator.py\n> +++ b/utils/codegen/ipc/generators/mojom_libcamera_generator.py\n> @@ -166,7 +166,7 @@ def MethodParamOutputs(method):\n> return method.response_parameters[1:]\n> \n> def MethodParamsHaveFd(parameters):\n> - return len([x for x in parameters if HasFd(x)]) > 0\n> + return any(x for x in parameters if HasFd(x))\n> \n> def MethodInputHasFd(method):\n> return MethodParamsHaveFd(method.parameters)\n> @@ -465,9 +465,9 @@ class Generator(generator.Generator):\n> 'cmd_event_enum_name': '_%sEventCmd' % self.module_name,\n> 'consts': self.module.constants,\n> 'enums': self.module.enums,\n> - 'has_array': len([x for x in self.module.kinds.keys() if x[0] == 'a']) > 0,\n> - 'has_map': len([x for x in self.module.kinds.keys() if x[0] == 'm']) > 0,\n> - 'has_string': len([x for x in self.module.kinds.keys() if x[0] == 's']) > 0,\n> + 'has_array': any(x for x in self.module.kinds.keys() if x[0] == 'a'),\n> + 'has_map': any(x for x in self.module.kinds.keys() if x[0] == 'm'),\n> + 'has_string': any(x for x in self.module.kinds.keys() if x[0] == 's'),\n> 'has_namespace': self.module.mojom_namespace != '',\n> 'interface_event': GetEventInterface(self.module.interfaces),\n> 'interface_main': GetMainInterface(self.module.interfaces),\n> @@ -485,9 +485,9 @@ class Generator(generator.Generator):\n> return {\n> 'consts': self.module.constants,\n> 'enums_gen_header': [x for x in self.module.enums if x.attributes is None or 'skipHeader' not in x.attributes],\n> - 'has_array': len([x for x in self.module.kinds.keys() if x[0] == 'a']) > 0,\n> - 'has_map': len([x for x in self.module.kinds.keys() if x[0] == 'm']) > 0,\n> - 'has_string': len([x for x in self.module.kinds.keys() if x[0] == 's']) > 0,\n> + 'has_array': any(x for x in self.module.kinds.keys() if x[0] == 'a'),\n> + 'has_map': any(x for x in self.module.kinds.keys() if x[0] == 'm'),\n> + 'has_string': any(x for x in self.module.kinds.keys() if x[0] == 's'),\n> 'structs_gen_header': [x for x in self.module.structs if x.attributes is None or 'skipHeader' not in x.attributes],\n> 'structs_gen_serializer': [x for x in self.module.structs if x.attributes is None or 'skipSerdes' not in x.attributes],\n> }\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0249EC3200\n\tfor ;\n\tThu, 15 May 2025 12:13:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A27B068B6F;\n\tThu, 15 May 2025 14:13:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ED7468B5D\n\tfor ;\n\tThu, 15 May 2025 14:13:23 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2a01:cb16:204c:4644:2597:989f:e013:9296])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 043B8836;\n\tThu, 15 May 2025 14:13:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CxImVIpi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747311186;\n\tbh=g3xFS6o4Z+I/1CbClLib/hLswGgEtaUruwV0ogECfa8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CxImVIpin5don2viz6y6G8yQJV9k1gjRR/m59fN1ly57ekUjMlU3zMQVLeVCznOGR\n\tBrKS5BO4iR++XsH5iEgwpnOdq9ZsG+LXrjJtrW1Y0aLYpY8P3kMpDs7aEBcy7kXcKT\n\tkojvjaryu076/Ez7l7ORNKdmWhyx0m64pao+JGt0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250515120012.3127231-2-barnabas.pocze@ideasonboard.com>","References":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>\n\t<20250515120012.3127231-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1 1/8] utils: codegen: ipc: Use `any()` instead of\n\t`len([]) > 0`","From":"Paul Elder ","Cc":"","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 15 May 2025 14:13:18 +0200","Message-ID":"<174731119890.209691.8174756414249649624@calcite>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34289,"web_url":"https://patchwork.libcamera.org/comment/34289/","msgid":"","date":"2025-05-20T11:19:05","subject":"Re: [RFC PATCH v1 1/8] utils: codegen: ipc: Use `any()` instead of\n\t`len([]) > 0`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Thu, May 15, 2025 at 02:00:05PM +0200, Barnabás Pőcze wrote:\n> Use `any()` with a generator expression instead of constructing\n> a list and checking its length.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> .../ipc/generators/mojom_libcamera_generator.py | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/utils/codegen/ipc/generators/mojom_libcamera_generator.py b/utils/codegen/ipc/generators/mojom_libcamera_generator.py\n> index d9c620a05..eff29a5b8 100644\n> --- a/utils/codegen/ipc/generators/mojom_libcamera_generator.py\n> +++ b/utils/codegen/ipc/generators/mojom_libcamera_generator.py\n> @@ -166,7 +166,7 @@ def MethodParamOutputs(method):\n> return method.response_parameters[1:]\n>\n> def MethodParamsHaveFd(parameters):\n> - return len([x for x in parameters if HasFd(x)]) > 0\n> + return any(x for x in parameters if HasFd(x))\n>\n> def MethodInputHasFd(method):\n> return MethodParamsHaveFd(method.parameters)\n> @@ -465,9 +465,9 @@ class Generator(generator.Generator):\n> 'cmd_event_enum_name': '_%sEventCmd' % self.module_name,\n> 'consts': self.module.constants,\n> 'enums': self.module.enums,\n> - 'has_array': len([x for x in self.module.kinds.keys() if x[0] == 'a']) > 0,\n> - 'has_map': len([x for x in self.module.kinds.keys() if x[0] == 'm']) > 0,\n> - 'has_string': len([x for x in self.module.kinds.keys() if x[0] == 's']) > 0,\n> + 'has_array': any(x for x in self.module.kinds.keys() if x[0] == 'a'),\n> + 'has_map': any(x for x in self.module.kinds.keys() if x[0] == 'm'),\n> + 'has_string': any(x for x in self.module.kinds.keys() if x[0] == 's'),\n> 'has_namespace': self.module.mojom_namespace != '',\n> 'interface_event': GetEventInterface(self.module.interfaces),\n> 'interface_main': GetMainInterface(self.module.interfaces),\n> @@ -485,9 +485,9 @@ class Generator(generator.Generator):\n> return {\n> 'consts': self.module.constants,\n> 'enums_gen_header': [x for x in self.module.enums if x.attributes is None or 'skipHeader' not in x.attributes],\n> - 'has_array': len([x for x in self.module.kinds.keys() if x[0] == 'a']) > 0,\n> - 'has_map': len([x for x in self.module.kinds.keys() if x[0] == 'm']) > 0,\n> - 'has_string': len([x for x in self.module.kinds.keys() if x[0] == 's']) > 0,\n> + 'has_array': any(x for x in self.module.kinds.keys() if x[0] == 'a'),\n> + 'has_map': any(x for x in self.module.kinds.keys() if x[0] == 'm'),\n> + 'has_string': any(x for x in self.module.kinds.keys() if x[0] == 's'),\n> 'structs_gen_header': [x for x in self.module.structs if x.attributes is None or 'skipHeader' not in x.attributes],\n> 'structs_gen_serializer': [x for x in self.module.structs if x.attributes is None or 'skipSerdes' not in x.attributes],\n> }\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70610C31E9\n\tfor ;\n\tTue, 20 May 2025 11:19:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40E0868D85;\n\tTue, 20 May 2025 13:19:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EBC5614DE\n\tfor ;\n\tTue, 20 May 2025 13:19:09 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B69B446;\n\tTue, 20 May 2025 13:18:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Rb9uG39S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747739928;\n\tbh=p/pCVAXUrG+5Y0IEvYAPp8t9ED29unt/Mh4/X0SAppY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Rb9uG39SlbLlMS+RS4KL+P1S5092OCgSJMaubZtdy+e53k39px0/EBf7TZDs3OILR\n\tqsjPNTRArXKwUuTdnvKQggknzVFVP3Wd5fQCmKAWHCaBOZOgBnGPdLaQ254I/D2XeI\n\tAOZJEGydyBSXv5AXvYW+NSXSKDfhR25p/7SxWD+o=","Date":"Tue, 20 May 2025 13:19:05 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPaul Elder ","Subject":"Re: [RFC PATCH v1 1/8] utils: codegen: ipc: Use `any()` instead of\n\t`len([]) > 0`","Message-ID":"","References":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>\n\t<20250515120012.3127231-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250515120012.3127231-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]