[{"id":34216,"web_url":"https://patchwork.libcamera.org/comment/34216/","msgid":"<20250513090530.GC7625@pendragon.ideasonboard.com>","date":"2025-05-13T09:05:30","subject":"Re: [PATCH v2] ipa: rkisp1: awb: Declare ControlInfo in AWB","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, May 13, 2025 at 01:58:45AM +0200, Paul Elder wrote:\n> The ControlInfo information for AwbEnable and ColourGains were declared\n\ns/were/are/\n\n> and exposed in the top-level IPA. These should instead be exposed by the\n> AWB part of the IPA, as it doesn't make sense to support these controls\n> when AWB is disabled, for example.\n> \n> Move the declaration of these controls out of the top-level IPA and into\n> AWB.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n> src/ipa/rkisp1/rkisp1.cpp | 2 --\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index eafe93081..8991f9cfa 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -90,6 +90,8 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n> \tcmap[&controls::ColourTemperature] = ControlInfo(kMinColourTemperature,\n> \t\t\t\t\t\t\t kMaxColourTemperature,\n> \t\t\t\t\t\t\t kDefaultColourTemperature);\n> +\tcmap[&controls::AwbEnable] = ControlInfo(false, true);\n> +\tcmap[&controls::ColourGains] = ControlInfo(0.0f, 3.996f, 1.0f);\n> \n> \tif (!tuningData.contains(\"algorithm\"))\n> \t\tLOG(RkISP1Awb, Info) << \"No AWB algorithm specified.\"\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 70ce0cba2..1ed7d7d92 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -115,8 +115,6 @@ const IPAHwSettings ipaHwSettingsV12{\n> \n> /* List of controls handled by the RkISP1 IPA */\n> const ControlInfoMap::Map rkisp1Controls{\n> -\t{ &controls::AwbEnable, ControlInfo(false, true) },\n> -\t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n> \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FB35C3200\n\tfor ;\n\tTue, 13 May 2025 09:05:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45C7368B55;\n\tTue, 13 May 2025 11:05:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08CD568B51\n\tfor ;\n\tTue, 13 May 2025 11:05:40 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [146.0.27.149])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40AFC4C9;\n\tTue, 13 May 2025 11:05:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r31WYYqX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747127124;\n\tbh=zAomJ+SVvnYDmAHJg/50A6ulU2rdvkVMkfQo0RC9xUA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r31WYYqXafQ/9iEBuq8gaK8kTUWhtxq81r0BH2Z9qDQ4zN450VKIKa7ohjwN/Kmwy\n\tbXN32NhSleqKZkczaPt5fZ4opauoepBXA+58prSM8esM8+QOM+HXn8CmyAsxaMcBv3\n\tt0jif1s3BwgLe8zkxLP3Hgc25zFd4m8UrfBte+D8=","Date":"Tue, 13 May 2025 11:05:30 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v2] ipa: rkisp1: awb: Declare ControlInfo in AWB","Message-ID":"<20250513090530.GC7625@pendragon.ideasonboard.com>","References":"<20250512235845.630232-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250512235845.630232-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]