{"id":23361,"url":"https://patchwork.libcamera.org/api/patches/23361/?format=json","web_url":"https://patchwork.libcamera.org/patch/23361/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250512235845.630232-1-paul.elder@ideasonboard.com>","date":"2025-05-12T23:58:45","name":"[v2] ipa: rkisp1: awb: Declare ControlInfo in AWB","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5c7659472807c81e171fad43c504edc2b0389946","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23361/mbox/","series":[{"id":5170,"url":"https://patchwork.libcamera.org/api/series/5170/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5170","date":"2025-05-12T23:58:45","name":"[v2] ipa: rkisp1: awb: Declare ControlInfo in AWB","version":2,"mbox":"https://patchwork.libcamera.org/series/5170/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23361/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23361/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C960C3200\n\tfor ;\n\tMon, 12 May 2025 23:59:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5E6C68B40;\n\tTue, 13 May 2025 01:59:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A9886175B\n\tfor ;\n\tTue, 13 May 2025 01:58:59 +0200 (CEST)","from pyrite.hamster-moth.ts.net (unknown\n\t[IPv6:2a01:cb16:207c:d42d:582a:8fec:5220:cfc6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F176353;\n\tTue, 13 May 2025 01:58:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ewRKbVlN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747094324;\n\tbh=xZ/sV1t0k+8UR8NfIfPfrKgeTZ1e0Cs+FfJzmbTk03Y=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ewRKbVlN1gX7yIm2ePl3M+tcriJ1z2GB8xEpP4gXUB8OxwzysihUspWzMvOxZ9JqQ\n\t5OWBtfCXav1PM8yWtyDTEoZiw5Jrig3FoAeWPuPdGxwjLT7hzcotwM3tmFzgn18pYj\n\tCwrLXmPUcAYtRzUuSkhMu0XbeuIQkN4xqHk8TBQk=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tKieran Bingham ","Subject":"[PATCH v2] ipa: rkisp1: awb: Declare ControlInfo in AWB","Date":"Tue, 13 May 2025 01:58:45 +0200","Message-Id":"<20250512235845.630232-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ControlInfo information for AwbEnable and ColourGains were declared\nand exposed in the top-level IPA. These should instead be exposed by the\nAWB part of the IPA, as it doesn't make sense to support these controls\nwhen AWB is disabled, for example.\n\nMove the declaration of these controls out of the top-level IPA and into\nAWB.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 2 --\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex eafe93081..8991f9cfa 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -90,6 +90,8 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n \tcmap[&controls::ColourTemperature] = ControlInfo(kMinColourTemperature,\n \t\t\t\t\t\t\t kMaxColourTemperature,\n \t\t\t\t\t\t\t kDefaultColourTemperature);\n+\tcmap[&controls::AwbEnable] = ControlInfo(false, true);\n+\tcmap[&controls::ColourGains] = ControlInfo(0.0f, 3.996f, 1.0f);\n \n \tif (!tuningData.contains(\"algorithm\"))\n \t\tLOG(RkISP1Awb, Info) << \"No AWB algorithm specified.\"\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 70ce0cba2..1ed7d7d92 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -115,8 +115,6 @@ const IPAHwSettings ipaHwSettingsV12{\n \n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n-\t{ &controls::AwbEnable, ControlInfo(false, true) },\n-\t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n","prefixes":["v2"]}