[{"id":34175,"web_url":"https://patchwork.libcamera.org/comment/34175/","msgid":"<2a4765b66012a423ca948b0c32d773dddf298aeb.camel@ideasonboard.com>","date":"2025-05-11T10:04:42","subject":"Re: [PATCH] ipa: Move IPA installations to a subdir","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch!\n\nOn Sat, 2025-05-10 at 11:07 +0200, Kieran Bingham wrote:\n> IPAs are expected to live within a directory that is searched by the\n> IPAManager.  If other non-IPA so files are installed in the same\n> location, then the user may be presented with an error message\n> reporting\n> that the module could not be parsed.\n> \n> Move IPA modules to an ipa specific subdirectory to ensure we only\n> parse\n> .so files that are expected to be IPA modules at load time.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=268\n> Signed-off-by: Kieran Bingham \n> ---\n>  src/ipa/meson.build | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 0ad4631def27..68f64b9a6fa3 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -4,7 +4,7 @@ ipa_includes = [\n>      libcamera_includes,\n>  ]\n>  \n> -ipa_install_dir = libcamera_libdir\n> +ipa_install_dir = libcamera_libdir / 'ipa'\n>  ipa_data_dir = libcamera_datadir / 'ipa'\n>  ipa_sysconf_dir = libcamera_sysconfdir / 'ipa'\n\nReviewed-by: Isaac Scott \n\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 465EBC3226\n\tfor ;\n\tSun, 11 May 2025 10:04:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CA2768B5B;\n\tSun, 11 May 2025 12:04:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F22068B41\n\tfor ;\n\tSun, 11 May 2025 12:04:46 +0200 (CEST)","from [IPv6:2001:861:3a80:3300:81b6:b1aa:9e10:77ca] (unknown\n\t[IPv6:2001:861:3a80:3300:81b6:b1aa:9e10:77ca])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91D6A63B;\n\tSun, 11 May 2025 12:04:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VUFLRYZA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746957871;\n\tbh=GoX0AFnO05pQAsqBXGN6/Lq3R+Wzgs57bj/VU+qrLlM=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=VUFLRYZArNWz9ctKfFAC3WcY4nwzRjGz+VfOylWBWbkgsWoKGW9cA/p1H2xdVseWG\n\toyDNojQprmj0b9aDy5GWEL6bmM2uTaLlKJeNUYR4iPehG6XHLp4/XMXZabJaq1Fbh5\n\tO0saWi3AKNcyolC7mOgJ6eTfLdR4uqGtbtcLApzc=","Message-ID":"<2a4765b66012a423ca948b0c32d773dddf298aeb.camel@ideasonboard.com>","Subject":"Re: [PATCH] ipa: Move IPA installations to a subdir","From":"Isaac Scott ","To":"Kieran Bingham , libcamera devel\n\t","Cc":"Christian Rauch ","Date":"Sun, 11 May 2025 11:04:42 +0100","In-Reply-To":"<20250510090713.7114-1-kieran.bingham@ideasonboard.com>","References":"<20250510090713.7114-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.1 (by Flathub.org) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34177,"web_url":"https://patchwork.libcamera.org/comment/34177/","msgid":"<20250511110423.GM19001@pendragon.ideasonboard.com>","date":"2025-05-11T11:04:23","subject":"Re: [PATCH] ipa: Move IPA installations to a subdir","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Sat, May 10, 2025 at 11:07:13AM +0200, Kieran Bingham wrote:\n> IPAs are expected to live within a directory that is searched by the\n> IPAManager. If other non-IPA so files are installed in the same\n> location, then the user may be presented with an error message reporting\n> that the module could not be parsed.\n> \n> Move IPA modules to an ipa specific subdirectory to ensure we only parse\n> .so files that are expected to be IPA modules at load time.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=268\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 0ad4631def27..68f64b9a6fa3 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -4,7 +4,7 @@ ipa_includes = [\n> libcamera_includes,\n> ]\n> \n> -ipa_install_dir = libcamera_libdir\n> +ipa_install_dir = libcamera_libdir / 'ipa'\n> ipa_data_dir = libcamera_datadir / 'ipa'\n> ipa_sysconf_dir = libcamera_sysconfdir / 'ipa'\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 169E0C3226\n\tfor ;\n\tSun, 11 May 2025 11:04:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2275C68B5E;\n\tSun, 11 May 2025 13:04:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8009368B51\n\tfor ;\n\tSun, 11 May 2025 13:04:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(static-176-133-119-130.ftth.abo.bbox.fr [176.133.119.130])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14FDB605;\n\tSun, 11 May 2025 13:04:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FegOm/yZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746961456;\n\tbh=7rMP4DGTcYK0yDSADismC0sA1zFUOeD3CqmHf/8aIVA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FegOm/yZTu4DzUJA91hJSGS35xnMez0FkREmnluJ3oNWGGo3IkyI0/6ZhomoX6fAA\n\tgzu7AHwb0rDuawhymOwe342VNvy2Q08t1gTxYQ6Z4W8TbGKkMHO8heqSJcDedqaNoK\n\thb7DWRWkZyD5gfMceiNGpaLeojXMNI7MItkyIdeU=","Date":"Sun, 11 May 2025 13:04:23 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ,\n\tChristian Rauch ","Subject":"Re: [PATCH] ipa: Move IPA installations to a subdir","Message-ID":"<20250511110423.GM19001@pendragon.ideasonboard.com>","References":"<20250510090713.7114-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250510090713.7114-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34179,"web_url":"https://patchwork.libcamera.org/comment/34179/","msgid":"<174696722590.660817.18356742030646363902@pyrite.rasen.tech>","date":"2025-05-11T12:40:25","subject":"Re: [PATCH] ipa: Move IPA installations to a subdir","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-05-10 11:07:13)\n> IPAs are expected to live within a directory that is searched by the\n> IPAManager. If other non-IPA so files are installed in the same\n> location, then the user may be presented with an error message reporting\n> that the module could not be parsed.\n> \n> Move IPA modules to an ipa specific subdirectory to ensure we only parse\n> .so files that are expected to be IPA modules at load time.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=268\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 0ad4631def27..68f64b9a6fa3 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -4,7 +4,7 @@ ipa_includes = [\n> libcamera_includes,\n> ]\n> \n> -ipa_install_dir = libcamera_libdir\n> +ipa_install_dir = libcamera_libdir / 'ipa'\n> ipa_data_dir = libcamera_datadir / 'ipa'\n> ipa_sysconf_dir = libcamera_sysconfdir / 'ipa'\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DEAB1C3200\n\tfor ;\n\tSun, 11 May 2025 12:40:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 034FB68B5C;\n\tSun, 11 May 2025 14:40:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DE3D68B51\n\tfor ;\n\tSun, 11 May 2025 14:40:29 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8440563B;\n\tSun, 11 May 2025 14:40:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i+GBuMOA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746967214;\n\tbh=GACy4q/f6qD0my/CXG6JKqMzvBVsCfXZcYlIO7XPZYE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=i+GBuMOAe1DhYkUfGbrRrxN2fQMC4IYyBj7wOjIT8fQW6qv6qy3+GOgEofqyWNVqk\n\tfeqLEhQttfJeaTh2Y0EMvENDcYtkydEmM2pNNHFSHO+HQP2j0qy3xMUXFnV/TW5N+P\n\tl0PeYfhodi5DqtDzhunWzCAFL2R26UEWl+n3bRIc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250510090713.7114-1-kieran.bingham@ideasonboard.com>","References":"<20250510090713.7114-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH] ipa: Move IPA installations to a subdir","From":"Paul Elder ","Cc":"Christian Rauch ,\n\tKieran Bingham ","To":"Kieran Bingham ,\n\tlibcamera devel ","Date":"Sun, 11 May 2025 14:40:25 +0200","Message-ID":"<174696722590.660817.18356742030646363902@pyrite.rasen.tech>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]