{"id":23350,"url":"https://patchwork.libcamera.org/api/patches/23350/?format=json","web_url":"https://patchwork.libcamera.org/patch/23350/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250509125746.49898-1-s.pueschel@pengutronix.de>","date":"2025-05-09T12:57:46","name":"libcamera: v4l2_videodevice: Log buffer count on error","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e6d2747a3453fb3fbef6faef73f5166d723a6142","submitter":{"id":225,"url":"https://patchwork.libcamera.org/api/people/225/?format=json","name":"Sven Püschel","email":"s.pueschel@pengutronix.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23350/mbox/","series":[{"id":5167,"url":"https://patchwork.libcamera.org/api/series/5167/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5167","date":"2025-05-09T12:57:46","name":"libcamera: v4l2_videodevice: Log buffer count on error","version":1,"mbox":"https://patchwork.libcamera.org/series/5167/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23350/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23350/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C468C3200\n\tfor ;\n\tFri, 9 May 2025 12:58:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6041B68B45;\n\tFri, 9 May 2025 14:58:10 +0200 (CEST)","from metis.whiteo.stw.pengutronix.de\n\t(metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C1AF68B25\n\tfor ;\n\tFri, 9 May 2025 14:58:08 +0200 (CEST)","from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77]\n\thelo=peter.fritz.box)\n\tby metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)\n\t(envelope-from )\n\tid 1uDNIm-0006Xi-Dj; Fri, 09 May 2025 14:58:08 +0200"],"From":"=?utf-8?q?Sven_P=C3=BCschel?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Sven_P=C3=BCschel?= ,\n\t=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH] libcamera: v4l2_videodevice: Log buffer count on error","Date":"Fri, 9 May 2025 14:57:46 +0200","Message-ID":"<20250509125746.49898-1-s.pueschel@pengutronix.de>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-SA-Exim-Connect-IP":"2a0a:edc0:0:900:1d::77","X-SA-Exim-Mail-From":"s.pueschel@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.whiteo.stw.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"libcamera-devel@lists.libcamera.org","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Log the actual and requested buffer count in the v4l2 error,\nwhen not the requested buffer count could was allocated by V4L2.\n\nSigned-off-by: Sven Püschel \nReviewed-by: Barnabás Pőcze \n\n---\n\nExtracted from a [1], as it is independent of it.\n\n[1] https://lists.libcamera.org/pipermail/libcamera-devel/2025-April/050024.html\n---\n src/libcamera/v4l2_videodevice.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex f5b3fa09..d6f8c3cd 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1326,7 +1326,8 @@ int V4L2VideoDevice::requestBuffers(unsigned int count,\n \n \tif (rb.count < count) {\n \t\tLOG(V4L2, Error)\n-\t\t\t<< \"Not enough buffers provided by V4L2VideoDevice\";\n+\t\t\t<< \"Not enough buffers provided by V4L2VideoDevice. Wanted: \"\n+\t\t\t<< count << \", got: \" << rb.count;\n \t\trequestBuffers(0, memoryType);\n \t\treturn -ENOMEM;\n \t}\n","prefixes":[]}