{"id":23345,"url":"https://patchwork.libcamera.org/api/patches/23345/?format=json","web_url":"https://patchwork.libcamera.org/patch/23345/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250507082753.2306743-5-naush@raspberrypi.com>","date":"2025-05-07T07:52:11","name":"[RFC,4/6] pipeline: rpi: Remove disable_startup_frame_drops config option","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5bfa51e86f786b03c6d9f9f0b91a2345638e31d9","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23345/mbox/","series":[{"id":5164,"url":"https://patchwork.libcamera.org/api/series/5164/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5164","date":"2025-05-07T07:52:07","name":"Eliminating startup frames","version":1,"mbox":"https://patchwork.libcamera.org/series/5164/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23345/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23345/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 501B4C3226\n\tfor ;\n\tWed, 7 May 2025 08:28:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7262168B37;\n\tWed, 7 May 2025 10:28:12 +0200 (CEST)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C91C68B31\n\tfor ;\n\tWed, 7 May 2025 10:28:01 +0200 (CEST)","by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-39c2688e2bbso438510f8f.1\n\tfor ;\n\tWed, 07 May 2025 01:28:01 -0700 (PDT)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-441d440fff6sm22182575e9.25.2025.05.07.01.27.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 May 2025 01:27:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"amtIQMeV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1746606480; x=1747211280;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TDFSDhxsWtnuegD2eNp0so8bkMmcVepBWj9qp8gGI+4=;\n\tb=amtIQMeVvuX80CKpubGGo0fDVcTkWMDGXHPljK0ztot5vjpGY7aZ2PoiUYSvg13OfX\n\tI6oBGQ8jVDWUoGLJ8i32ml6osJKK/xlNwzGPHrvZmUW6RKdMRI460kRhtzgWgN9Sfb9D\n\t3OvRvcER/Ib8BLffiLnpX1HNXuh1xiRe/NkwLjrbdlIEmO9z49yuytMeSKtbCjG4Y88Q\n\t5CFxmQ+Z2kxLY91mk2ulTemKvtOS/6T4dqTfQUqpK3+PUitZQFboXMTHFBEGwMw7owwU\n\t9cVDSr4ljKGIs4tROD0WcFnyaXpaXGLOMp5VoMXr2QI/8qLCZ8Yfs3H2gRFByp1MH02w\n\tkaMw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1746606480; x=1747211280;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TDFSDhxsWtnuegD2eNp0so8bkMmcVepBWj9qp8gGI+4=;\n\tb=X7bkpQMoyiQspYh1QU7QbBa1565mXsks6kTRAsUKFbfRPhPcqJ7BXD2NT76ysqP7WN\n\tAC50stQy/+zC5xdrrgT07cUN5k41I1MHfsGz1FwPFYvU6rD2/SQoiUzA9zJxA1G8zE2m\n\tiqVqFu80ims+oV+gDrCBrYI61fRh3zfsb6P02MlUcMn9ssn6UnEI9d99XvVcyuO7Pg/U\n\tYoxec+bebx/qnetpKEo+kEJ0+bA4/pLDDeeb49VTgBpFG8aTsdfWpzdWhIlHkmzjAcrM\n\t1nbwtxIP+WUUk9Tr4LixbJo0EaAerSXO8JcI47oorTj83a2QLL/SqGb1h6Lkrg6ah9E4\n\t0IwQ==","X-Gm-Message-State":"AOJu0YwUMa5YlIM3mGP5E4xsgwXJgoLPnq/dmwEREVyaWw6fdhz+khoR\n\tSZXgEBYZ7AHTjDXK3MDyXBxei9N2NNsnwuzsEv06d1Ek8sLmqLLLwofi5NmeygHdAPapNduhCXj\n\tX","X-Gm-Gg":"ASbGncvQmAr5FWn1+VgZKSciRooAgbK3ByHphZjfAUFNW/BkncsPl8mrj1DYm8731MM\n\tx7xGM83LEfiFFDYfKur1uu4ck21XkUuQBXnwtKdxCG6bJ7EQcukU/pWGeTPrDCVEnyT1/WVxoqP\n\t6o/3Bjvf60gCz9NMC3PDDTRoYSFso7dlXL6u95GmSdnccu+edEyLaoLrc4FhXeiU9ky62nTvrsm\n\t2byxuqO9K7ahq3OdJlqVvlkCaIkIfxIQxKF9/A7o+v7wQYQxfydgJLhD3Tu5uCCg4aM6YIGomBj\n\t+6FMo1rahRJSpUg0QV4xFioV2qb4bprqSd4cNneM1TCDtls3gO922qq95l+K7DiuwJdix28=","X-Google-Smtp-Source":"AGHT+IEKiGSxB3ET0jnS5ncxHDzlHfdU4DLEQyyWAmJ9QL0a2sqoBWeIQhyfEWi6BdBy9kUwrm44mw==","X-Received":"by 2002:a05:6000:1acc:b0:3a0:87f6:5c7a with SMTP id\n\tffacd0b85a97d-3a0b4a17181mr619387f8f.3.1746606479946; \n\tWed, 07 May 2025 01:27:59 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[RFC PATCH 4/6] pipeline: rpi: Remove disable_startup_frame_drops\n\tconfig option","Date":"Wed, 7 May 2025 08:52:11 +0100","Message-ID":"<20250507082753.2306743-5-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250507082753.2306743-1-naush@raspberrypi.com>","References":"<20250507082753.2306743-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"With the previous change to not drop frames in the pipeline handler,\nthe \"disable_startup_frame_drops\" pipeline config option is not used.\nRemove it, and throw a warning if the option is present in the YAML\nconfig file.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 5 -----\n src/libcamera/pipeline/rpi/pisp/data/example.yaml | 5 -----\n src/libcamera/pipeline/rpi/vc4/data/example.yaml | 5 -----\n 4 files changed, 4 insertions(+), 18 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 21f2daf5bab5..4afdaed5935d 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1077,7 +1077,6 @@ void CameraData::enumerateVideoDevices(MediaLink *link, const std::string &front\n int CameraData::loadPipelineConfiguration()\n {\n \tconfig_ = {\n-\t\t.disableStartupFrameDrops = false,\n \t\t.cameraTimeoutValue = 0,\n \t};\n \n@@ -1114,8 +1113,10 @@ int CameraData::loadPipelineConfiguration()\n \n \tconst YamlObject &phConfig = (*root)[\"pipeline_handler\"];\n \n-\tconfig_.disableStartupFrameDrops =\n-\t\tphConfig[\"disable_startup_frame_drops\"].get(config_.disableStartupFrameDrops);\n+\tif (phConfig.contains(\"disable_startup_frame_drops\"))\n+\t\tLOG(RPI, Warning)\n+\t\t\t<< \"The disable_startup_frame_drops key is now deprecated, \"\n+\t\t\t<< \"please use FrameMetadata::Status::FrameStartup instead.\";\n \n \tconfig_.cameraTimeoutValue =\n \t\tphConfig[\"camera_timeout_value_ms\"].get(config_.cameraTimeoutValue);\ndiff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex 6023f9f9d6b3..e27c4f860d1a 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -164,11 +164,6 @@ public:\n \tbool buffersAllocated_;\n \n \tstruct Config {\n-\t\t/*\n-\t\t * Override any request from the IPA to drop a number of startup\n-\t\t * frames.\n-\t\t */\n-\t\tbool disableStartupFrameDrops;\n \t\t/*\n \t\t * Override the camera timeout value calculated by the IPA based\n \t\t * on frame durations.\ndiff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\nindex d67e654a8b9e..baf03be79bb3 100644\n--- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n@@ -16,11 +16,6 @@\n #\n # \"num_cfe_config_queue\": 2,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\ndiff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\nindex b8e01adeaf40..27e543488d48 100644\n--- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n@@ -29,11 +29,6 @@\n #\n # \"min_total_unicam_buffers\": 4,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\n","prefixes":["RFC","4/6"]}