{"id":23336,"url":"https://patchwork.libcamera.org/api/patches/23336/?format=json","web_url":"https://patchwork.libcamera.org/patch/23336/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250506105827.506569-2-barnabas.pocze@ideasonboard.com>","date":"2025-05-06T10:58:24","name":"[v5,1/4] apps: cam: sdl_texture: Take list of buffers in span","commit_ref":"02f60006cf903cbe74c95ba0b612c5cc11045787","pull_url":null,"state":"accepted","archived":false,"hash":"15cd2530ff820510095f75e5a7d4ab09442ecdf0","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23336/mbox/","series":[{"id":5162,"url":"https://patchwork.libcamera.org/api/series/5162/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5162","date":"2025-05-06T10:58:23","name":"apps: cam: sdl_sink: Support more RGB and YUV formats","version":5,"mbox":"https://patchwork.libcamera.org/series/5162/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23336/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23336/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7277FC3200\n\tfor ;\n\tTue, 6 May 2025 10:58:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 367F368B2D;\n\tTue, 6 May 2025 12:58:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3E3868B25\n\tfor ;\n\tTue, 6 May 2025 12:58:31 +0200 (CEST)","from pb-laptop.local (185.221.141.56.nat.pool.zt.hu\n\t[185.221.141.56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F01C656D;\n\tTue, 6 May 2025 12:58:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Eih0Hibt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746529101;\n\tbh=RCWG7i9GPEl2qmDGcql7Z1mEHfnplbrtCm86A44Nv9E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Eih0HibtAg/X2peorkczC1y6R/2sCd02X8NOofUxIahE2oYFiv4dv1WCanzV184iI\n\tZg5FQCaFKCSnz/gnsDwyAvjaQwl5nafdi16QK2bS3Wv5lZLryEFlI0xtjMVkuVo+1d\n\tc3PgNvltisppzV21yly4hD5BuTWx5x5i9BrY+BRM=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v5 1/4] apps: cam: sdl_texture: Take list of buffers in span","Date":"Tue, 6 May 2025 12:58:24 +0200","Message-ID":"<20250506105827.506569-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250506105827.506569-1-barnabas.pocze@ideasonboard.com>","References":"<20250506105827.506569-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A non-owning span is sufficient, so use that instead of a vector.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/apps/cam/sdl_texture.h | 4 ++--\n src/apps/cam/sdl_texture_mjpg.cpp | 2 +-\n src/apps/cam/sdl_texture_mjpg.h | 2 +-\n src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n src/apps/cam/sdl_texture_yuv.h | 4 ++--\n 5 files changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/src/apps/cam/sdl_texture.h b/src/apps/cam/sdl_texture.h\nindex 990f83b6e..39e1c7b38 100644\n--- a/src/apps/cam/sdl_texture.h\n+++ b/src/apps/cam/sdl_texture.h\n@@ -7,7 +7,7 @@\n \n #pragma once\n \n-#include \n+#include \n \n #include \n \n@@ -19,7 +19,7 @@ public:\n \tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat, const int stride);\n \tvirtual ~SDLTexture();\n \tint create(SDL_Renderer *renderer);\n-\tvirtual void update(const std::vector> &data) = 0;\n+\tvirtual void update(libcamera::Span> data) = 0;\n \tSDL_Texture *get() const { return ptr_; }\n \n protected:\ndiff --git a/src/apps/cam/sdl_texture_mjpg.cpp b/src/apps/cam/sdl_texture_mjpg.cpp\nindex cace18fc6..ca49a1142 100644\n--- a/src/apps/cam/sdl_texture_mjpg.cpp\n+++ b/src/apps/cam/sdl_texture_mjpg.cpp\n@@ -76,7 +76,7 @@ int SDLTextureMJPG::decompress(Span data)\n \treturn 0;\n }\n \n-void SDLTextureMJPG::update(const std::vector> &data)\n+void SDLTextureMJPG::update(libcamera::Span> data)\n {\n \tdecompress(data[0]);\n \tSDL_UpdateTexture(ptr_, nullptr, rgb_.get(), stride_);\ndiff --git a/src/apps/cam/sdl_texture_mjpg.h b/src/apps/cam/sdl_texture_mjpg.h\nindex 37bed5f0e..be8a55fe7 100644\n--- a/src/apps/cam/sdl_texture_mjpg.h\n+++ b/src/apps/cam/sdl_texture_mjpg.h\n@@ -14,7 +14,7 @@ class SDLTextureMJPG : public SDLTexture\n public:\n \tSDLTextureMJPG(const SDL_Rect &rect);\n \n-\tvoid update(const std::vector> &data) override;\n+\tvoid update(libcamera::Span> data) override;\n \n private:\n \tint decompress(libcamera::Span data);\ndiff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex 480d7a379..80a5ec05d 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -15,7 +15,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n {\n }\n \n-void SDLTextureNV12::update(const std::vector> &data)\n+void SDLTextureNV12::update(libcamera::Span> data)\n {\n \tSDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n \t\t\t data[1].data(), stride_);\n@@ -27,7 +27,7 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n {\n }\n \n-void SDLTextureYUYV::update(const std::vector> &data)\n+void SDLTextureYUYV::update(libcamera::Span> data)\n {\n \tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n }\ndiff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\nindex 29c756e77..db877f503 100644\n--- a/src/apps/cam/sdl_texture_yuv.h\n+++ b/src/apps/cam/sdl_texture_yuv.h\n@@ -14,7 +14,7 @@ class SDLTextureNV12 : public SDLTexture\n {\n public:\n \tSDLTextureNV12(const SDL_Rect &rect, unsigned int stride);\n-\tvoid update(const std::vector> &data) override;\n+\tvoid update(libcamera::Span> data) override;\n };\n #endif\n \n@@ -22,5 +22,5 @@ class SDLTextureYUYV : public SDLTexture\n {\n public:\n \tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n-\tvoid update(const std::vector> &data) override;\n+\tvoid update(libcamera::Span> data) override;\n };\n","prefixes":["v5","1/4"]}