[{"id":34120,"web_url":"https://patchwork.libcamera.org/comment/34120/","msgid":"<20250502152019.GF22453@pendragon.ideasonboard.com>","date":"2025-05-02T15:20:19","subject":"Re: [PATCH v1] Documentation: guides: application-developer: Remove\n\tunnecessary argument","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 02, 2025 at 05:13:30PM +0200, Barnabás Pőcze wrote:\n> `required: true` is the default for meson's `dependency()` function.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 3608598e0..2d7c29010 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -626,7 +626,7 @@ accordingly. In this example, the application file has been named\n> \n> simple_cam = executable('simple-cam',\n> 'simple-cam.cpp',\n> - dependencies: dependency('libcamera', required : true))\n> + dependencies: dependency('libcamera'))\n> \n> The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to\n> locate the ``libcamera`` library, which the test application will be","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0298BE08B\n\tfor ;\n\tFri, 2 May 2025 15:20:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 989B568ADC;\n\tFri, 2 May 2025 17:20:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E55068AD3\n\tfor ;\n\tFri, 2 May 2025 17:20:28 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53182353;\n\tFri, 2 May 2025 17:20:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bVR0L13C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746199220;\n\tbh=H/KSNiroF9t0bM29e8VUtH/rhbZ/awnHcnl4yhvtjSw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bVR0L13CRGh6mZX4ePgVUFhC1F7gEL+1R1kdu8LNU27WmQxTFyXTXZQBZtNz8Vbns\n\t8csi8IscD4KQ2uonVoeqk5G6aKuvbNymE6u83/4+oBqTL5Cz/7EkGwn0vZeOgiHzOY\n\tSMF9XceZo4PddVIR1Xp55x7AE4nMkOtmxGrCyq3s=","Date":"Fri, 2 May 2025 18:20:19 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] Documentation: guides: application-developer: Remove\n\tunnecessary argument","Message-ID":"<20250502152019.GF22453@pendragon.ideasonboard.com>","References":"<20250502151330.192877-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250502151330.192877-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34128,"web_url":"https://patchwork.libcamera.org/comment/34128/","msgid":"<174629844245.2902011.1601892651131780282@ping.linuxembedded.co.uk>","date":"2025-05-03T18:54:02","subject":"Re: [PATCH v1] Documentation: guides: application-developer: Remove\n\tunnecessary argument","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-05-02 16:20:19)\n> On Fri, May 02, 2025 at 05:13:30PM +0200, Barnabás Pőcze wrote:\n> > `required: true` is the default for meson's `dependency()` function.\n> > \n> > Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Laurent Pinchart \n> \n\nReviewed-by: Kieran Bingham \n\n> > ---\n> > Documentation/guides/application-developer.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > index 3608598e0..2d7c29010 100644\n> > --- a/Documentation/guides/application-developer.rst\n> > +++ b/Documentation/guides/application-developer.rst\n> > @@ -626,7 +626,7 @@ accordingly. In this example, the application file has been named\n> > \n> > simple_cam = executable('simple-cam',\n> > 'simple-cam.cpp',\n> > - dependencies: dependency('libcamera', required : true))\n> > + dependencies: dependency('libcamera'))\n> > \n> > The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to\n> > locate the ``libcamera`` library, which the test application will be\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 731C0C3226\n\tfor ;\n\tSat, 3 May 2025 18:54:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D57E68AD8;\n\tSat, 3 May 2025 20:54:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89418617CB\n\tfor ;\n\tSat, 3 May 2025 20:54:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0C4B55;\n\tSat, 3 May 2025 20:53:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BdcP2Wjn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746298437;\n\tbh=cOPc9BmBxUPy+Ys/HVvkv54t9f1fBQ+KxHbFL2i7azU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BdcP2WjnNJ51XL1FYUDoBr+dv3zVGyVYWNIarmuMlnQJk4z//ClBok07cOC8aXwrJ\n\tpIzPo5+4CNYpEm8cFe5fDv1WEUmm/542Um6P6EndvnrXY+4YB0CGstxElOrdpy07Oa\n\tt652IbjqWWhTjlW7ltjx/V7FWCd0dHUJW85tYbjk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250502152019.GF22453@pendragon.ideasonboard.com>","References":"<20250502151330.192877-1-barnabas.pocze@ideasonboard.com>\n\t<20250502152019.GF22453@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v1] Documentation: guides: application-developer: Remove\n\tunnecessary argument","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","Date":"Sat, 03 May 2025 19:54:02 +0100","Message-ID":"<174629844245.2902011.1601892651131780282@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]