[{"id":34104,"web_url":"https://patchwork.libcamera.org/comment/34104/","msgid":"","date":"2025-05-02T08:23:16","subject":"Re: [PATCH 2/3] libcamera: camera_sensor: Extend reporting in\n\tgetFormat()","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Thu, May 01, 2025 at 03:16:08PM +0100, Kieran Bingham wrote:\n> When a pipeline handler asks the CameraSensor for a format, which is not\n> achievable, it can be very helpful to the user to identify what size was\n> requested and why it could not be provided within any constrained\n> maximum size.\n>\n> This can make otherwise difficult to diagnose user errors visible and\n> quickly correctable.\n>\n> Both of the CameraSensorRaw and CameraSensorLegacy are updated\n> accordingly but that likely means these two classes could soon benefit\n> from a more common base class to share otherwise identical code.\n>\n> Signed-off-by: Kieran Bingham \n\nCertainly doesn't hurt\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/sensor/camera_sensor_legacy.cpp | 4 +++-\n> src/libcamera/sensor/camera_sensor_raw.cpp | 4 +++-\n> 2 files changed, 6 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> index 32989c19c019..20275f3bb1b2 100644\n> --- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> @@ -742,7 +742,9 @@ CameraSensorLegacy::getFormat(const std::vector &mbusCodes,\n> \t}\n>\n> \tif (!bestSize) {\n> -\t\tLOG(CameraSensor, Debug) << \"No supported format or size found\";\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"No supported format or size found. Requested \"\n> +\t\t\t<< size << \" with a maximum size \" << maxSize;\n> \t\treturn {};\n> \t}\n>\n> diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\n> index ab75b1f8204c..07d1e2bfa600 100644\n> --- a/src/libcamera/sensor/camera_sensor_raw.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n> @@ -800,7 +800,9 @@ CameraSensorRaw::getFormat(const std::vector &mbusCodes,\n> \t}\n>\n> \tif (!bestSize) {\n> -\t\tLOG(CameraSensor, Debug) << \"No supported format or size found\";\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"No supported format or size found. Requested \"\n> +\t\t\t<< size << \" with a maximum size \" << maxSize;\n> \t\treturn {};\n> \t}\n>\n> --\n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7F97BE08B\n\tfor ;\n\tFri, 2 May 2025 08:23:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 541DB68AD9;\n\tFri, 2 May 2025 10:23:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D92D68AD8\n\tfor ;\n\tFri, 2 May 2025 10:23:21 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 49237353;\n\tFri, 2 May 2025 10:23:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i3QseFfZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746174193;\n\tbh=k+wCfHaPuJp6qGbt4NEJ2AGsJqaLLFkNe07xdejOKjQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i3QseFfZcyRJI0gJj17uhDLTXo9FV6GRV0TzDnYAOrjIoKlzuzIP89leCvLS8Vzuv\n\tDCDhl9+HpkwpSwdS3ysQiijxl5oUuooNAbzJGpv9pV64KBHy2wRwOTAUjiHGyIF0nO\n\tCxmALtTWK5EnVH2k5IZAkHfbaQRc/bXpzl2K3Rs8=","Date":"Fri, 2 May 2025 10:23:16 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 2/3] libcamera: camera_sensor: Extend reporting in\n\tgetFormat()","Message-ID":"","References":"<20250501141609.717148-1-kieran.bingham@ideasonboard.com>\n\t<20250501141609.717148-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250501141609.717148-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]