[{"id":34094,"web_url":"https://patchwork.libcamera.org/comment/34094/","msgid":"<174610927898.1586992.3760921562306381314@ping.linuxembedded.co.uk>","date":"2025-05-01T14:21:18","subject":"Re: [PATCH v1] py: Set `PYTHONPATH` in devenv","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-01 15:12:50)\n> If the python bindings are built, then set the `PYTHONPATH` environmental\n> variable in the meson devenv accordingly to make it easy to use.\n> \n> $ meson devenv -C build\n> [libcamera] $ echo $PYTHONPATH\n> /libcamera/build/src/py\n> [libcamera] $ python\n> Python 3.13.3 (main, Apr 9 2025, 07:44:25) [GCC 14.2.1 20250207] on linux\n> Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n> >>> import libcamera\n> >>> cm = libcamera.CameraManager.singleton()\n> [...]\n> [129:52:33.293860558] [4133380] INFO Camera camera_manager.cpp:326 libcamera v0.5.0+169-7dbe74b5-dirty (2025-05-01)\n> [...]\n> \n> Signed-off-by: Barnabás Pőcze \n\nNice touch!\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/py/libcamera/meson.build | 16 ----------------\n> src/py/meson.build | 12 ++++++++++++\n> 2 files changed, 12 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 456ee7932..33ab65798 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -1,21 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -py3_dep = dependency('python3', required : get_option('pycamera'))\n> -\n> -if not py3_dep.found()\n> - pycamera_enabled = false\n> - subdir_done()\n> -endif\n> -\n> -pybind11_dep = dependency('pybind11', required : get_option('pycamera'))\n> -\n> -if not pybind11_dep.found()\n> - pycamera_enabled = false\n> - subdir_done()\n> -endif\n> -\n> -pycamera_enabled = true\n> -\n> pycamera_sources = files([\n> 'py_camera_manager.cpp',\n> 'py_color_space.cpp',\n> diff --git a/src/py/meson.build b/src/py/meson.build\n> index a4586b4ae..922806971 100644\n> --- a/src/py/meson.build\n> +++ b/src/py/meson.build\n> @@ -1,3 +1,15 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +py3_dep = dependency('python3', required : get_option('pycamera'))\n> +pybind11_dep = dependency('pybind11', required : get_option('pycamera'))\n> +\n> +pycamera_enabled = py3_dep.found() and pybind11_dep.found()\n> +if not pycamera_enabled\n> + subdir_done()\n> +endif\n> +\n> subdir('libcamera')\n> +\n> +pycamera_devenv = environment()\n> +pycamera_devenv.prepend('PYTHONPATH', meson.current_build_dir())\n> +meson.add_devenv(pycamera_devenv)\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 556D7BE08B\n\tfor ;\n\tThu, 1 May 2025 14:21:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A665B68AD9;\n\tThu, 1 May 2025 16:21:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D38D617D7\n\tfor ;\n\tThu, 1 May 2025 16:21:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEE8263D;\n\tThu, 1 May 2025 16:21:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M3pMoVmM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746109275;\n\tbh=QSsJLD+QIQ1RQu1B3Id1LPQLKbaWQXS1w8xw1u5KVVM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=M3pMoVmMBVBP/x/vdv76Y37wSfmtjtPlTVDxYyePmo1xqfc4Gz4X+JhLqmHbrtbOa\n\tC711+u5FOhLZylkS82gkmtXzmWb9lWv1PAMTr9AjjtX89mwPPL5ce+PnKBGy70e72g\n\tK9M55K7IOl6iY76+MgoGfK2WFVfC/lh6TC7pvstU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250501141250.4140986-1-barnabas.pocze@ideasonboard.com>","References":"<20250501141250.4140986-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] py: Set `PYTHONPATH` in devenv","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 01 May 2025 15:21:18 +0100","Message-ID":"<174610927898.1586992.3760921562306381314@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34184,"web_url":"https://patchwork.libcamera.org/comment/34184/","msgid":"<174698816651.1507464.1389197915720337151@pyrite.rasen.tech>","date":"2025-05-11T18:29:26","subject":"Re: [PATCH v1] py: Set `PYTHONPATH` in devenv","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-01 16:12:50)\n> If the python bindings are built, then set the `PYTHONPATH` environmental\n> variable in the meson devenv accordingly to make it easy to use.\n> \n> $ meson devenv -C build\n> [libcamera] $ echo $PYTHONPATH\n> /libcamera/build/src/py\n> [libcamera] $ python\n> Python 3.13.3 (main, Apr 9 2025, 07:44:25) [GCC 14.2.1 20250207] on linux\n> Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n> >>> import libcamera\n> >>> cm = libcamera.CameraManager.singleton()\n> [...]\n> [129:52:33.293860558] [4133380] INFO Camera camera_manager.cpp:326 libcamera v0.5.0+169-7dbe74b5-dirty (2025-05-01)\n> [...]\n\nOh that's cool!\n\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/py/libcamera/meson.build | 16 ----------------\n> src/py/meson.build | 12 ++++++++++++\n> 2 files changed, 12 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 456ee7932..33ab65798 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -1,21 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -py3_dep = dependency('python3', required : get_option('pycamera'))\n> -\n> -if not py3_dep.found()\n> - pycamera_enabled = false\n> - subdir_done()\n> -endif\n> -\n> -pybind11_dep = dependency('pybind11', required : get_option('pycamera'))\n> -\n> -if not pybind11_dep.found()\n> - pycamera_enabled = false\n> - subdir_done()\n> -endif\n> -\n> -pycamera_enabled = true\n> -\n> pycamera_sources = files([\n> 'py_camera_manager.cpp',\n> 'py_color_space.cpp',\n> diff --git a/src/py/meson.build b/src/py/meson.build\n> index a4586b4ae..922806971 100644\n> --- a/src/py/meson.build\n> +++ b/src/py/meson.build\n> @@ -1,3 +1,15 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +py3_dep = dependency('python3', required : get_option('pycamera'))\n> +pybind11_dep = dependency('pybind11', required : get_option('pycamera'))\n> +\n> +pycamera_enabled = py3_dep.found() and pybind11_dep.found()\n> +if not pycamera_enabled\n> + subdir_done()\n> +endif\n> +\n> subdir('libcamera')\n> +\n> +pycamera_devenv = environment()\n> +pycamera_devenv.prepend('PYTHONPATH', meson.current_build_dir())\n> +meson.add_devenv(pycamera_devenv)\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 676D3C3200\n\tfor ;\n\tSun, 11 May 2025 18:29:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8324E68B67;\n\tSun, 11 May 2025 20:29:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E461F68B51\n\tfor ;\n\tSun, 11 May 2025 20:29:29 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D7E7B63;\n\tSun, 11 May 2025 20:29:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZTxGXe2s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746988155;\n\tbh=8rrhHWjifqMk2gRGYLZHQiaWD/TiDqhcehqVlh8hDnI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ZTxGXe2svichQkeHBpXSYD3uqbgjkZaC178NPrjex057kSTTXMvnVUB49E/+bsiHB\n\thp+pHo9/55Zz4xDl5Kg3bevM8CEW16DBYjuL6t1Cq/joDaMkou+ObPMj1okkuGshNJ\n\tq59xCAE6XJQ38V1NZRMrKoglCRkdiPeLmncw8m74=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250501141250.4140986-1-barnabas.pocze@ideasonboard.com>","References":"<20250501141250.4140986-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] py: Set `PYTHONPATH` in devenv","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 11 May 2025 20:29:26 +0200","Message-ID":"<174698816651.1507464.1389197915720337151@pyrite.rasen.tech>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34199,"web_url":"https://patchwork.libcamera.org/comment/34199/","msgid":"<174704253799.355457.5131498066776406053@isaac-ThinkPad-T16-Gen-2>","date":"2025-05-12T09:35:37","subject":"Re: [PATCH v1] py: Set `PYTHONPATH` in devenv","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch!\n\nQuoting Barnabás Pőcze (2025-05-01 15:12:50)\n> If the python bindings are built, then set the `PYTHONPATH` environmental\n> variable in the meson devenv accordingly to make it easy to use.\n> \n> $ meson devenv -C build\n> [libcamera] $ echo $PYTHONPATH\n> /libcamera/build/src/py\n> [libcamera] $ python\n> Python 3.13.3 (main, Apr 9 2025, 07:44:25) [GCC 14.2.1 20250207] on linux\n> Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n> >>> import libcamera\n> >>> cm = libcamera.CameraManager.singleton()\n> [...]\n> [129:52:33.293860558] [4133380] INFO Camera camera_manager.cpp:326 libcamera v0.5.0+169-7dbe74b5-dirty (2025-05-01)\n> [...]\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Isaac Scott \n\n> ---\n> src/py/libcamera/meson.build | 16 ----------------\n> src/py/meson.build | 12 ++++++++++++\n> 2 files changed, 12 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 456ee7932..33ab65798 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -1,21 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -py3_dep = dependency('python3', required : get_option('pycamera'))\n> -\n> -if not py3_dep.found()\n> - pycamera_enabled = false\n> - subdir_done()\n> -endif\n> -\n> -pybind11_dep = dependency('pybind11', required : get_option('pycamera'))\n> -\n> -if not pybind11_dep.found()\n> - pycamera_enabled = false\n> - subdir_done()\n> -endif\n> -\n> -pycamera_enabled = true\n> -\n> pycamera_sources = files([\n> 'py_camera_manager.cpp',\n> 'py_color_space.cpp',\n> diff --git a/src/py/meson.build b/src/py/meson.build\n> index a4586b4ae..922806971 100644\n> --- a/src/py/meson.build\n> +++ b/src/py/meson.build\n> @@ -1,3 +1,15 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +py3_dep = dependency('python3', required : get_option('pycamera'))\n> +pybind11_dep = dependency('pybind11', required : get_option('pycamera'))\n> +\n> +pycamera_enabled = py3_dep.found() and pybind11_dep.found()\n> +if not pycamera_enabled\n> + subdir_done()\n> +endif\n> +\n> subdir('libcamera')\n> +\n> +pycamera_devenv = environment()\n> +pycamera_devenv.prepend('PYTHONPATH', meson.current_build_dir())\n> +meson.add_devenv(pycamera_devenv)\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4C74C3226\n\tfor ;\n\tMon, 12 May 2025 09:35:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 032EE68C92;\n\tMon, 12 May 2025 11:35:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07A8C68C8F\n\tfor ;\n\tMon, 12 May 2025 11:35:40 +0200 (CEST)","from thinkpad.ideasonboard.com (unknown\n\t[IPv6:2001:861:3a80:3300:787f:eec:c7d9:4bd3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0B2D6AF;\n\tMon, 12 May 2025 11:35:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PYHfc2Sr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747042526;\n\tbh=SA46VLgJ+e8CsA8kBPzZQRQe4BiegK+QdGAoXqCw4ZA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=PYHfc2Sr8bwavXj13AGhbnOjDmcIMGqtmYVqvJBaKAj0bNPAlzKIrugcURM0dXfSz\n\twEoPVQat4vodlzMWrPZT3aWdGo0rGNzAn6Q/CoXvIbKJ/je7MsjbyQUNIJNDV0RXyr\n\tOqPVO4n1osCJ5zATCBTIGobdosJyrx2LLb8WQl8w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250501141250.4140986-1-barnabas.pocze@ideasonboard.com>","References":"<20250501141250.4140986-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] py: Set `PYTHONPATH` in devenv","From":"Isaac Scott ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 May 2025 10:35:37 +0100","Message-ID":"<174704253799.355457.5131498066776406053@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]