[{"id":34106,"web_url":"https://patchwork.libcamera.org/comment/34106/","msgid":"","date":"2025-05-02T09:25:19","subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Thu, May 01, 2025 at 11:58:16AM +0200, Barnabás Pőcze wrote:\n> The current `ControlValue` mechanism does not support arrays\n> of strings, the assignment in the removed snippet will in fact\n> trigger an assertion failure in `ControlValue::set()` because\n> `sizeof(std::string) != ControlValueSize[ControlTypeString]`.\n>\n> Fixes: b35f04b3c194 (\"cam: capture_script: Support parsing array controls\")\n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/cam/capture_script.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n>\n> diff --git a/src/apps/cam/capture_script.cpp b/src/apps/cam/capture_script.cpp\n> index e7e69960e..fdf82efc0 100644\n> --- a/src/apps/cam/capture_script.cpp\n> +++ b/src/apps/cam/capture_script.cpp\n> @@ -578,10 +578,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,\n> \t\tvalue = Span(values.data(), values.size());\n> \t\tbreak;\n> \t}\n> -\tcase ControlTypeString: {\n> -\t\tvalue = Span(repr.data(), repr.size());\n> -\t\tbreak;\n> -\t}\n> \tdefault:\n> \t\tstd::cerr << \"Unsupported control type\" << std::endl;\n> \t\tbreak;\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEE2FBE08B\n\tfor ;\n\tFri, 2 May 2025 09:25:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D11E368ADB;\n\tFri, 2 May 2025 11:25:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D810D68ACB\n\tfor ;\n\tFri, 2 May 2025 11:25:22 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEE1973B;\n\tFri, 2 May 2025 11:25:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LTN8Rc/j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746177915;\n\tbh=Up+is73/0eLtZp99tL3umLspz3qwXLz1nX0p03E+TNY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LTN8Rc/jOrvQQoY79/xM9v6rxV/JQNHvihASKfUJA4tSwWykaApwZf5Obe+O6Mn5d\n\ttUauWyDupXHw2pcapLvraGFSRcjoBaIUGEWo7bxxrdJFWTsEtbRbXFUvLsRx2v5uju\n\tMvGWDkbPSVE0gpZi59c5t/YGSkxlnNHMF9BGHM6I=","Date":"Fri, 2 May 2025 11:25:19 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham ","Subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","Message-ID":"","References":"<20250501095818.3996419-1-barnabas.pocze@ideasonboard.com>\n\t<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34228,"web_url":"https://patchwork.libcamera.org/comment/34228/","msgid":"<174714846408.233090.13961720955140054544@pyrite.rasen.tech>","date":"2025-05-13T15:01:04","subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-05-01 11:58:16)\n> The current `ControlValue` mechanism does not support arrays\n> of strings, the assignment in the removed snippet will in fact\n> trigger an assertion failure in `ControlValue::set()` because\n> `sizeof(std::string) != ControlValueSize[ControlTypeString]`.\n> \n> Fixes: b35f04b3c194 (\"cam: capture_script: Support parsing array controls\")\n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/cam/capture_script.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/apps/cam/capture_script.cpp b/src/apps/cam/capture_script.cpp\n> index e7e69960e..fdf82efc0 100644\n> --- a/src/apps/cam/capture_script.cpp\n> +++ b/src/apps/cam/capture_script.cpp\n> @@ -578,10 +578,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,\n> value = Span(values.data(), values.size());\n> break;\n> }\n> - case ControlTypeString: {\n> - value = Span(repr.data(), repr.size());\n> - break;\n> - }\n> default:\n> std::cerr << \"Unsupported control type\" << std::endl;\n> break;\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E76AC3200\n\tfor ;\n\tTue, 13 May 2025 15:01:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ACA568B61;\n\tTue, 13 May 2025 17:01:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4751068B40\n\tfor ;\n\tTue, 13 May 2025 17:01:07 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D09C7E4;\n\tTue, 13 May 2025 17:00:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cdS1GoSY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747148451;\n\tbh=bBd3nmZOmDv8W8jqb7y6k+UObp2JC8X84GVD+NY6xo4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cdS1GoSYr78E58fWNL0eMM107jmhzgF+DGU4rPFt6oSuGrlRp0xUrPLMHK84bcF45\n\tjC/fmpY0N2tdFfKduSOdMEJ1yLSFUb9APvv/CtnppaUoPe54j2XqcuDmxpHuQwxvg9\n\tmNiE3Kvp6W6ygMQtwJY8Q3fhQMPOTWQ3LTi066So=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>","References":"<20250501095818.3996419-1-barnabas.pocze@ideasonboard.com>\n\t<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","From":"Paul Elder ","Cc":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 13 May 2025 17:01:04 +0200","Message-ID":"<174714846408.233090.13961720955140054544@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36078,"web_url":"https://patchwork.libcamera.org/comment/36078/","msgid":"<20251002145235.GD10198@pendragon.ideasonboard.com>","date":"2025-10-02T14:52:35","subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Thu, May 01, 2025 at 11:58:16AM +0200, Barnabás Pőcze wrote:\n> The current `ControlValue` mechanism does not support arrays\n> of strings, the assignment in the removed snippet will in fact\n> trigger an assertion failure in `ControlValue::set()` because\n> `sizeof(std::string) != ControlValueSize[ControlTypeString]`.\n> \n> Fixes: b35f04b3c194 (\"cam: capture_script: Support parsing array controls\")\n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/cam/capture_script.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/apps/cam/capture_script.cpp b/src/apps/cam/capture_script.cpp\n> index e7e69960e..fdf82efc0 100644\n> --- a/src/apps/cam/capture_script.cpp\n> +++ b/src/apps/cam/capture_script.cpp\n> @@ -578,10 +578,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,\n> \t\tvalue = Span(values.data(), values.size());\n> \t\tbreak;\n> \t}\n> -\tcase ControlTypeString: {\n> -\t\tvalue = Span(repr.data(), repr.size());\n> -\t\tbreak;\n> -\t}\n> \tdefault:\n> \t\tstd::cerr << \"Unsupported control type\" << std::endl;\n> \t\tbreak;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34282C328C\n\tfor ;\n\tThu, 2 Oct 2025 14:52:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FC706B5AA;\n\tThu, 2 Oct 2025 16:52:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64AF56B5A2\n\tfor ;\n\tThu, 2 Oct 2025 16:52:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 57B39929;\n\tThu, 2 Oct 2025 16:51:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"El2RKfv+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759416671;\n\tbh=0vjT9gNESwzwd6CKlDEoGOzrVPoouseEtvkfMZBjv4I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=El2RKfv+4hyhLWXMd4JIm5z1/fuRMyBmnBVXDgt49+T5auOETFlIwEfV06bKDkNa2\n\tz0IDhCwBDAZL6DAdOiFuMmy4GSJKnayY4zmlCTdean73HXazIEH4B9xbKGo7HUQKFo\n\tLRNHFhZv2+chu2v0VBE1uWBz67LRwUDZnAipdh6I=","Date":"Thu, 2 Oct 2025 17:52:35 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","Message-ID":"<20251002145235.GD10198@pendragon.ideasonboard.com>","References":"<20250501095818.3996419-1-barnabas.pocze@ideasonboard.com>\n\t<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36079,"web_url":"https://patchwork.libcamera.org/comment/36079/","msgid":"<141ed3c4-fba4-4ba8-83c8-99f8db2eeae3@ideasonboard.com>","date":"2025-10-02T14:56:19","subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 02. 16:52 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> On Thu, May 01, 2025 at 11:58:16AM +0200, Barnabás Pőcze wrote:\n>> The current `ControlValue` mechanism does not support arrays\n>> of strings, the assignment in the removed snippet will in fact\n>> trigger an assertion failure in `ControlValue::set()` because\n>> `sizeof(std::string) != ControlValueSize[ControlTypeString]`.\n>>\n>> Fixes: b35f04b3c194 (\"cam: capture_script: Support parsing array controls\")\n>> Signed-off-by: Barnabás Pőcze \n>> Reviewed-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n\nThe first two patches in this series are already merged, I am afraid. :(\n\n\n> \n>> ---\n>> src/apps/cam/capture_script.cpp | 4 ----\n>> 1 file changed, 4 deletions(-)\n>>\n>> diff --git a/src/apps/cam/capture_script.cpp b/src/apps/cam/capture_script.cpp\n>> index e7e69960e..fdf82efc0 100644\n>> --- a/src/apps/cam/capture_script.cpp\n>> +++ b/src/apps/cam/capture_script.cpp\n>> @@ -578,10 +578,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,\n>> \t\tvalue = Span(values.data(), values.size());\n>> \t\tbreak;\n>> \t}\n>> -\tcase ControlTypeString: {\n>> -\t\tvalue = Span(repr.data(), repr.size());\n>> -\t\tbreak;\n>> -\t}\n>> \tdefault:\n>> \t\tstd::cerr << \"Unsupported control type\" << std::endl;\n>> \t\tbreak;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24B74C328C\n\tfor ;\n\tThu, 2 Oct 2025 14:56:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D59106B5FB;\n\tThu, 2 Oct 2025 16:56:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F1606B5A2\n\tfor ;\n\tThu, 2 Oct 2025 16:56:22 +0200 (CEST)","from [192.168.33.12] (185.221.142.146.nat.pool.zt.hu\n\t[185.221.142.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F726929;\n\tThu, 2 Oct 2025 16:54:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UAeXj62G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759416892;\n\tbh=rNnz9NJ1+fa989q6ilSxKQCNOswszgnvvyG13R5lwO8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=UAeXj62GH+vjxBA/coXfgZP1Akuu3eOIHlMjNcWAN7bY95me96ksAaoZMGUl01ErD\n\t5owQo445vNqPMujKIPgd01snrsd2TwBdvQ7ajR62RHi90Qikl9HvwDhzqzTfTiXvu7\n\tx24usjcE3dB7VEp1fxZG2nNfRJJq9TZNNMCLHnWk=","Message-ID":"<141ed3c4-fba4-4ba8-83c8-99f8db2eeae3@ideasonboard.com>","Date":"Thu, 2 Oct 2025 16:56:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/3] apps: cam: capture_script: Disallow arrays of\n\tstrings","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","References":"<20250501095818.3996419-1-barnabas.pocze@ideasonboard.com>\n\t<20250501095818.3996419-2-barnabas.pocze@ideasonboard.com>\n\t<20251002145235.GD10198@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251002145235.GD10198@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]