{"id":23303,"url":"https://patchwork.libcamera.org/api/patches/23303/?format=json","web_url":"https://patchwork.libcamera.org/patch/23303/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250430075849.2790398-3-barnabas.pocze@ideasonboard.com>","date":"2025-04-30T07:58:47","name":"[v4,2/4] apps: cam: sdl_texture: Drop `&rect_` from `SDL_Update{NV, }Texture()` call","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"afb8b0f6e3e83e23b92a98603b2eff5b6fbcd795","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23303/mbox/","series":[{"id":5154,"url":"https://patchwork.libcamera.org/api/series/5154/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5154","date":"2025-04-30T07:58:45","name":"apps: cam: sdl_sink: Support more RGB and YUV formats","version":4,"mbox":"https://patchwork.libcamera.org/series/5154/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23303/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23303/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4105BE08B\n\tfor ;\n\tWed, 30 Apr 2025 07:59:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0072D68AD5;\n\tWed, 30 Apr 2025 09:58:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF547617DE\n\tfor ;\n\tWed, 30 Apr 2025 09:58:53 +0200 (CEST)","from pb-laptop.local (185.221.141.190.nat.pool.zt.hu\n\t[185.221.141.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AF4F1196;\n\tWed, 30 Apr 2025 09:58:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JUB/NyGr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745999927;\n\tbh=7bTcM2mriVp85165ZMVr91wnqeD7M//VtRJQROS3rok=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JUB/NyGrPPkBMltYqXNvP9OzUsGAA3MdEKlqHTenUGemkXkFegfzPa+Eg3jGmXYQw\n\tzgqYy8ORx8sBLOUBGwh5OLAHgVbu2im3EFCtpb30BJx2radHfJcEiicA2FoPVHmj6B\n\td+q/bupZMw+HuT5tKuCmCf/2svbylim/NSnbKDQo=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v4 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call","Date":"Wed, 30 Apr 2025 09:58:47 +0200","Message-ID":"<20250430075849.2790398-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250430075849.2790398-1-barnabas.pocze@ideasonboard.com>","References":"<20250430075849.2790398-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the entire texture is to be updated, there is no need to specify\nthe target area explicitly.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex 80a5ec05d..7e2ce3f49 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n \n void SDLTextureNV12::update(libcamera::Span> data)\n {\n-\tSDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n+\tSDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,\n \t\t\t data[1].data(), stride_);\n }\n #endif\n@@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n \n void SDLTextureYUYV::update(libcamera::Span> data)\n {\n-\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n+\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n }\n","prefixes":["v4","2/4"]}