[{"id":34072,"web_url":"https://patchwork.libcamera.org/comment/34072/","msgid":"<93740859-6b57-4342-94e1-c3285bf0566a@ideasonboard.com>","date":"2025-04-29T12:57:51","subject":"Re: [PATCH] ipa: rkisp1: awb: Ignore empty AWB statistics","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 29/04/2025 12:59, Stefan Klug wrote:\n> When the AWB engine doesn't find a valid pixel because all pixels lie\n> outside the configured colour range it returns an AWB measurement value\n> of 255, 255, 255. This leaves the regulation in an unrecoverable state\n> noticeable by a completely green image. Fix that by skipping the AWB\n> calculation in case there were no valid pixels.\n>\n> Signed-off-by: Stefan Klug .\n\n\nReviewed-by: Daniel Scally \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index eafe93081bb1..2b8b41ecccbe 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -296,6 +296,11 @@ void Awb::process(IPAContext &context,\n> \tconst rkisp1_cif_isp_stat *params = &stats->params;\n> \tconst rkisp1_cif_isp_awb_stat *awb = ¶ms->awb;\n> \n> +\tif (awb->awb_mean[0].cnt == 0) {\n> +\t\tLOG(RkISP1Awb, Warning) << \"AWB statistics are empty\";\n> +\t\treturn;\n> +\t}\n> +\n> \tRGB rgbMeans = calculateRgbMeans(frameContext, awb);\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":["parsemail@patchwork.libcamera.org","kbingham@ideasonboard.com"],"Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6CB5C327D\n\tfor ;\n\tTue, 29 Apr 2025 13:02:50 +0000 (UTC)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C6ABAF\n\tfor ;\n\tTue, 29 Apr 2025 15:02:45 +0200 (CEST)","from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id 0JBhLtDMEGgLNzgA4E0KoQ\n\t(envelope-from )\n\tfor ; Tue, 29 Apr 2025 14:57:52 +0200","from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid 3F320AF;\tTue, 29 Apr 2025 14:57:52 +0200 (CEST)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4865268AD5;\n\tTue, 29 Apr 2025 14:57:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 364C5617DB\n\tfor ;\n\tTue, 29 Apr 2025 14:57:54 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D0D2AF\n\tfor ;\n\tTue, 29 Apr 2025 14:57:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745931765;\n\tbh=sW6VcHAziv4Xf+qJnG4EfPP5ON78K+Pe9ZviyMKxLFY=;\n\th=Date:Subject:To:References:From:In-Reply-To:List-Id:\n\tList-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\tResent-From:Resent-To:From;\n\tb=FTVmXPHq0Zp53ZgmNiwi4t7+JWzHcTjBdUpONWcbOD85YQ0Aq221Su3zleZrZPy0B\n\tdtT9DjJCJg2l2oyapJ7ox/yN+pFLKcA8enKaOTJ/q0MW929x7o4aWDkfXyPgU0VJfD\n\tkq7ejjNUI/22Qw4RWgfMfB9Hy0oPYNuPSs6G8IoM=","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745931468;\n\tbh=sW6VcHAziv4Xf+qJnG4EfPP5ON78K+Pe9ZviyMKxLFY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=qnP7sSiM6WjyP7Ul/4Do6A5N9L6Dt2sCdX8BW10oXvYFWi146qq7IeSsF5LmwAmNR\n\t5nffEAlIWnFRghJlIXBukCbtvSxjjbk/Dl09evgIpRoTsHYw9b1udxgZZbdg7AIUzO\n\tWSqEwX496XJWUycRlgOiaXm7fP4BWciE9KrhMMhY="],"Authentication-Results":["perceval.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.a=rsa-sha256 header.s=mail header.b=qnP7sSiM; dkim-atps=neutral","lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qnP7sSiM\";\tdkim-atps=neutral"],"Message-ID":"<93740859-6b57-4342-94e1-c3285bf0566a@ideasonboard.com>","Date":"Tue, 29 Apr 2025 13:57:51 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: rkisp1: awb: Ignore empty AWB statistics","To":"libcamera-devel@lists.libcamera.org","References":"<20250429115934.3551701-1-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250429115934.3551701-1-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" ","X-TUID":"9Tr0/3KGycQD","Resent-From":"Kieran Bingham ","Resent-To":"parsemail@patchwork.libcamera.org"}},{"id":34077,"web_url":"https://patchwork.libcamera.org/comment/34077/","msgid":"<174594376938.1586992.3038341283882488324@ping.linuxembedded.co.uk>","date":"2025-04-29T16:22:49","subject":"Re: [PATCH] ipa: rkisp1: awb: Ignore empty AWB statistics","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-29 12:59:19)\n> When the AWB engine doesn't find a valid pixel because all pixels lie\n> outside the configured colour range it returns an AWB measurement value\n> of 255, 255, 255. This leaves the regulation in an unrecoverable state\n> noticeable by a completely green image. Fix that by skipping the AWB\n> calculation in case there were no valid pixels.\n> \n> Signed-off-by: Stefan Klug .\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index eafe93081bb1..2b8b41ecccbe 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -296,6 +296,11 @@ void Awb::process(IPAContext &context,\n> const rkisp1_cif_isp_stat *params = &stats->params;\n> const rkisp1_cif_isp_awb_stat *awb = ¶ms->awb;\n> \n> + if (awb->awb_mean[0].cnt == 0) {\n> + LOG(RkISP1Awb, Warning) << \"AWB statistics are empty\";\n> + return;\n\nSo I think this is definitely a valid thing to do - but I can conjour up\nconditions where 'every frame' is invalid - and that then becomes very\nnoisy on this log.\n\nI suspect just making it a Debug level log instead might be better.\n\nAnyway, I'll leave that to you - I think catching this is a good thing -\nwe shouldn't try to calculate any means from no data ...\n\n\nReviewed-by: Kieran Bingham \n\n> + }\n> +\n> RGB rgbMeans = calculateRgbMeans(frameContext, awb);\n> \n> /*\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3878FBE08B\n\tfor ;\n\tTue, 29 Apr 2025 16:22:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8AB4668AD3;\n\tTue, 29 Apr 2025 18:22:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C473617DB\n\tfor ;\n\tTue, 29 Apr 2025 18:22:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 871896A8;\n\tTue, 29 Apr 2025 18:22:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ug1RIdgu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745943766;\n\tbh=2As+DzbhbW6I/94Vc/I2GPtwtQa3kYieQTyt6ks1ioY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Ug1RIdguDyM+axXzSoOXtQhQ/+blosGAVV28cu20KYlxyataronVcWPJ9q4xzUkpB\n\tJyXClybmdTHTtznXdseFwQhQyCjol1xXkEB11tQIgILJp9FCgWRSR/z30Y8hpVB7yE\n\tKgYUwxuVyTCpYIZGcRG/0wX2B8GyABV6eWm/pAUI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250429115934.3551701-1-stefan.klug@ideasonboard.com>","References":"<20250429115934.3551701-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: awb: Ignore empty AWB statistics","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 29 Apr 2025 17:22:49 +0100","Message-ID":"<174594376938.1586992.3038341283882488324@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]