[{"id":34070,"web_url":"https://patchwork.libcamera.org/comment/34070/","msgid":"<174591357863.1586992.16570111051325575430@ping.linuxembedded.co.uk>","date":"2025-04-29T07:59:38","subject":"Re: [PATCH v2] ipa: rpi: awb: Remove \"fast\" parameter","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-29 08:53:21)\n> The \"fast\" parameter has not been used since it first appeared in the\n> source code. And not only is it not used, but its retrieval from\n> the configuration since c1597f989654 (\"ipa: raspberrypi: Use YamlParser\n> to replace dependency on boost\") has been incorrect. So remove it.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> changes in v2:\n> * remove it altogether\n> \n> v1: https://patchwork.libcamera.org/patch/20076/\n> ---\n> src/ipa/rpi/controller/rpi/awb.cpp | 1 -\n> src/ipa/rpi/controller/rpi/awb.h | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> index 8479ae409..365b595ff 100644\n> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> @@ -165,7 +165,6 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n> bayes = false;\n> }\n> }\n> - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> whitepointR = params[\"whitepoint_r\"].get(0.0);\n> whitepointB = params[\"whitepoint_b\"].get(0.0);\n> if (bayes == false)\n> diff --git a/src/ipa/rpi/controller/rpi/awb.h b/src/ipa/rpi/controller/rpi/awb.h\n> index 86640f8f8..2fb912541 100644\n> --- a/src/ipa/rpi/controller/rpi/awb.h\n> +++ b/src/ipa/rpi/controller/rpi/awb.h\n> @@ -43,7 +43,6 @@ struct AwbConfig {\n> uint16_t startupFrames;\n> unsigned int convergenceFrames; /* approx number of frames to converge */\n> double speed; /* IIR filter speed applied to algorithm results */\n> - bool fast; /* \"fast\" mode uses a 16x16 rather than 32x32 grid */\n\nEven better..\n\nReviewed-by: Kieran Bingham \n\n> libcamera::ipa::Pwl ctR; /* function maps CT to r (= R/G) */\n> libcamera::ipa::Pwl ctB; /* function maps CT to b (= B/G) */\n> libcamera::ipa::Pwl ctRInverse; /* inverse of ctR */\n> --\n> 2.49.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81DCFBE08B\n\tfor ;\n\tTue, 29 Apr 2025 07:59:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2808E68AD6;\n\tTue, 29 Apr 2025 09:59:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F06F617DF\n\tfor ;\n\tTue, 29 Apr 2025 09:59:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D58CA4CE;\n\tTue, 29 Apr 2025 09:59:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r/e4hAMH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745913575;\n\tbh=oR5GT0LCrCe2j04tfuX5NcMsQhkKDwE8Z2W9jW7zupU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=r/e4hAMHissE4ulHvOmIvvQJX3Xhb43CyG6V+FLJlchkECRRSyoErNyFBp/ndQo0N\n\tTj7jOHYlX58xBctNFqAXFn8y6Xwq+Dy+wo/jmz7BRcMigqgDoOYOpjBzdnnoROqgtn\n\tOfh7ZYNfLwYaOLMkljUK/7AsB6Qng8iQKJ3Gkxuw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250429075321.2085445-1-barnabas.pocze@ideasonboard.com>","References":"<20250429075321.2085445-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2] ipa: rpi: awb: Remove \"fast\" parameter","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 29 Apr 2025 08:59:38 +0100","Message-ID":"<174591357863.1586992.16570111051325575430@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34071,"web_url":"https://patchwork.libcamera.org/comment/34071/","msgid":"","date":"2025-04-29T08:14:09","subject":"Re: [PATCH v2] ipa: rpi: awb: Remove \"fast\" parameter","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Barnabas\n\nThanks for the patch.\n\nOn Tue, 29 Apr 2025 at 08:59, Kieran Bingham\n wrote:\n>\n> Quoting Barnabás Pőcze (2025-04-29 08:53:21)\n> > The \"fast\" parameter has not been used since it first appeared in the\n> > source code. And not only is it not used, but its retrieval from\n> > the configuration since c1597f989654 (\"ipa: raspberrypi: Use YamlParser\n> > to replace dependency on boost\") has been incorrect. So remove it.\n> >\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > changes in v2:\n> > * remove it altogether\n> >\n> > v1: https://patchwork.libcamera.org/patch/20076/\n> > ---\n> > src/ipa/rpi/controller/rpi/awb.cpp | 1 -\n> > src/ipa/rpi/controller/rpi/awb.h | 1 -\n> > 2 files changed, 2 deletions(-)\n> >\n> > diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> > index 8479ae409..365b595ff 100644\n> > --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> > +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> > @@ -165,7 +165,6 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n> > bayes = false;\n> > }\n> > }\n> > - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> > whitepointR = params[\"whitepoint_r\"].get(0.0);\n> > whitepointB = params[\"whitepoint_b\"].get(0.0);\n> > if (bayes == false)\n> > diff --git a/src/ipa/rpi/controller/rpi/awb.h b/src/ipa/rpi/controller/rpi/awb.h\n> > index 86640f8f8..2fb912541 100644\n> > --- a/src/ipa/rpi/controller/rpi/awb.h\n> > +++ b/src/ipa/rpi/controller/rpi/awb.h\n> > @@ -43,7 +43,6 @@ struct AwbConfig {\n> > uint16_t startupFrames;\n> > unsigned int convergenceFrames; /* approx number of frames to converge */\n> > double speed; /* IIR filter speed applied to algorithm results */\n> > - bool fast; /* \"fast\" mode uses a 16x16 rather than 32x32 grid */\n>\n> Even better..\n>\n> Reviewed-by: Kieran Bingham \n\nWell, I honestly have no recollection that we ever turned the 32x32\ngrid into a 16x16 one, but I suppose the evidence is there and it\nwould have saved some computation. for whatever that was worth (which\ncan't have been much, because the code was obviously deleted a long\ntime ago).\n\nSo yes, let's remove it.\n\nReviewed-by: David Plowman \n\nThanks for spotting it!\n\nDavid\n\n>\n> > libcamera::ipa::Pwl ctR; /* function maps CT to r (= R/G) */\n> > libcamera::ipa::Pwl ctB; /* function maps CT to b (= B/G) */\n> > libcamera::ipa::Pwl ctRInverse; /* inverse of ctR */\n> > --\n> > 2.49.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F174C327D\n\tfor ;\n\tTue, 29 Apr 2025 08:14:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34BB268AD6;\n\tTue, 29 Apr 2025 10:14:23 +0200 (CEST)","from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com\n\t[IPv6:2607:f8b0:4864:20::f31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ADD6617DF\n\tfor ;\n\tTue, 29 Apr 2025 10:14:21 +0200 (CEST)","by mail-qv1-xf31.google.com with SMTP id\n\t6a1803df08f44-6e8f254b875so64895716d6.1\n\tfor ;\n\tTue, 29 Apr 2025 01:14:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cKdj8MXT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1745914460; x=1746519260;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=lHwAutp29UC9+Y8D2KMayrlCQyzzwRsnXaL6BsQgIdI=;\n\tb=cKdj8MXToybojE0iiio8oD5olRKvm4afnEBtHhPEwp+v53zNC7ba/eHd9Iw2GoBtRU\n\tKTZjA+vrf1k06FE191p2Mu112QHiCE30XBQmMjOpkfyDeytRw4NExqqIXGwQwa57wyXC\n\tYisPsMFMSdnohrMQfKFUxu6lV7uBaratrqG2ZNh5wMPu7+wfMaJUOZG6d2ksNA95g6rw\n\tyuMHK249LI39AHctPLZhmuaGU1Ac5ejSWvbF6zTv+8ZlUOZ38ZNgm7OUeR513br7oJAI\n\tzWM5A/DSrD759NR5mIboihIEPwtmTcOyQYNOkEsCkQLXN/v1itDeel8x29wDB0gkOSgY\n\t9x1w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745914460; x=1746519260;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=lHwAutp29UC9+Y8D2KMayrlCQyzzwRsnXaL6BsQgIdI=;\n\tb=UVo1ALBDtJryELCWQ9EID5LIh4X9uOWiGZEfiKZEjGBISu+BOtahNBzZOP+cKDYALw\n\ts6yLxk89FF5QJ9rinvmNn6s72pQrVe5uOiPuHRHEa3sM2YN8ajawGbEB7w3LiLfG6CAZ\n\tJ9PlzE7J5Cs1V2t6eUa36/1VYgW7HNvMH7fURQwkbA/T6c6uAMDqGPnxGQID3FzBXeN5\n\tIXKsa330wtf78go4sHyhmrQhztXMmhSqbCBmrn/B7TtP29rtrZDjcm9GZou6+CZCFIcx\n\tvlgaCJb61xIgGFe1j27H3Gryqr4fc90pdGJpo4K7/oUUamTw8VZwPjsZVc43kSFyJ9IR\n\tfBgg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVDnC+/Tfbwa1OH2ctBSvO+oKtLgi/BGKHePBUYMdmpNXwGzxE5MMaGtxgVS7J3wQwV8t4MNqrkk2KGklFjxCQ=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yzyck3rXH05sJM4k4XmXHAmPUhCDk3iLIxeeZn5taMNm/kY0z7Y\n\tpOO79OsUScKKBOW7Ph0H9DsfrlvANyN0kWNXI1O9Wr41JADEQLhFazqzacDVe4G+QipfmFSaArZ\n\tFNSCqfPb9OOxEkc/4QpYG6MSIlHAKmGjhkPkslg==","X-Gm-Gg":"ASbGnctbo1sW933bepYKPJfq8HhAMAD4z34ITLd4dzfL4aoLCCr0qqfJjTpKxlAgnxr\n\tABMT9itCzI20mQPdYYGVYOqWGaPx2ozMOQ3hidOFJ4N5ffFNH2gYnBVILIPVzkBetFO3IzMIHK5\n\tCUjhaBomD04/3fgsjLwxQ2oKj1YYhbRCwjCL8xRwY/hEgDZhdhutmAsw==","X-Google-Smtp-Source":"AGHT+IEw0kchMyF+tv+7gavXKi7AheezkGvYldJ5rqP6vk4E+E4YRcIfJkCXKBZC6ap4jYNX1ByKjaWs0cXjL7NmkMA=","X-Received":"by 2002:a05:6214:410f:b0:6e6:591b:fa62 with SMTP id\n\t6a1803df08f44-6f4f26b0b48mr29143256d6.5.1745914460257;\n\tTue, 29 Apr 2025 01:14:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20250429075321.2085445-1-barnabas.pocze@ideasonboard.com>\n\t<174591357863.1586992.16570111051325575430@ping.linuxembedded.co.uk>","In-Reply-To":"<174591357863.1586992.16570111051325575430@ping.linuxembedded.co.uk>","From":"David Plowman ","Date":"Tue, 29 Apr 2025 09:14:09 +0100","X-Gm-Features":"ATxdqUH5M-UbkThjJaJ1Ngiw9VV2vfBMFlSD9N3TZydE5Tzk50Qlo6TOKdCg1ao","Message-ID":"","Subject":"Re: [PATCH v2] ipa: rpi: awb: Remove \"fast\" parameter","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]