{"id":23296,"url":"https://patchwork.libcamera.org/api/patches/23296/?format=json","web_url":"https://patchwork.libcamera.org/patch/23296/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250429075321.2085445-1-barnabas.pocze@ideasonboard.com>","date":"2025-04-29T07:53:21","name":"[v2] ipa: rpi: awb: Remove \"fast\" parameter","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a2be7cdd8f07ceb755b8fe1a528d483b31294a05","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23296/mbox/","series":[],"comments":"https://patchwork.libcamera.org/api/patches/23296/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23296/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE558C327D\n\tfor ;\n\tTue, 29 Apr 2025 07:53:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7286668AD6;\n\tTue, 29 Apr 2025 09:53:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D97F4617DF\n\tfor ;\n\tTue, 29 Apr 2025 09:53:24 +0200 (CEST)","from pb-laptop.local (185.221.141.190.nat.pool.zt.hu\n\t[185.221.141.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 396964CE\n\tfor ;\n\tTue, 29 Apr 2025 09:53:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LpgTO9YP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745913199;\n\tbh=kDYtW527eXitHXwkq+TcO/P3kY2fPsRf9wvdtVgXOcQ=;\n\th=From:To:Subject:Date:From;\n\tb=LpgTO9YP25eGSCg4DdY8WquRG2XhZe1q643nfPgcXSyoRJfNa1XIBr82acc3k4ISa\n\t3LX5LP+C/oIM+XWLDNWE5EASv+2dRgv9wgaPvUDk1ekGEiq4Qc93654TEiMw4ePmxq\n\tcAa1Nw0xwQCKELEao6EY6d7EspvtO2nEQgMj+4OA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2] ipa: rpi: awb: Remove \"fast\" parameter","Date":"Tue, 29 Apr 2025 09:53:21 +0200","Message-ID":"<20250429075321.2085445-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The \"fast\" parameter has not been used since it first appeared in the\nsource code. And not only is it not used, but its retrieval from\nthe configuration since c1597f989654 (\"ipa: raspberrypi: Use YamlParser\nto replace dependency on boost\") has been incorrect. So remove it.\n\nSigned-off-by: Barnabás Pőcze \n---\nchanges in v2:\n * remove it altogether\n\nv1: https://patchwork.libcamera.org/patch/20076/\n---\n src/ipa/rpi/controller/rpi/awb.cpp | 1 -\n src/ipa/rpi/controller/rpi/awb.h | 1 -\n 2 files changed, 2 deletions(-)\n\n--\n2.49.0","diff":"diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\nindex 8479ae409..365b595ff 100644\n--- a/src/ipa/rpi/controller/rpi/awb.cpp\n+++ b/src/ipa/rpi/controller/rpi/awb.cpp\n@@ -165,7 +165,6 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n \t\t\tbayes = false;\n \t\t}\n \t}\n-\tfast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n \twhitepointR = params[\"whitepoint_r\"].get(0.0);\n \twhitepointB = params[\"whitepoint_b\"].get(0.0);\n \tif (bayes == false)\ndiff --git a/src/ipa/rpi/controller/rpi/awb.h b/src/ipa/rpi/controller/rpi/awb.h\nindex 86640f8f8..2fb912541 100644\n--- a/src/ipa/rpi/controller/rpi/awb.h\n+++ b/src/ipa/rpi/controller/rpi/awb.h\n@@ -43,7 +43,6 @@ struct AwbConfig {\n \tuint16_t startupFrames;\n \tunsigned int convergenceFrames; /* approx number of frames to converge */\n \tdouble speed; /* IIR filter speed applied to algorithm results */\n-\tbool fast; /* \"fast\" mode uses a 16x16 rather than 32x32 grid */\n \tlibcamera::ipa::Pwl ctR; /* function maps CT to r (= R/G) */\n \tlibcamera::ipa::Pwl ctB; /* function maps CT to b (= B/G) */\n \tlibcamera::ipa::Pwl ctRInverse; /* inverse of ctR */\n","prefixes":["v2"]}