[{"id":34068,"web_url":"https://patchwork.libcamera.org/comment/34068/","msgid":"","date":"2025-04-28T13:20:11","subject":"Re: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control\n\tis used","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThanks for fixing this.\n\nOn Mon, 28 Apr 2025 at 14:16, David Plowman\n wrote:\n>\n> The AeEnable control is now just a wrapper that is converted to\n> ExposureTimeMode and AnalogueGainMode controls instead. Therefore, it\n> should simply be ignored when we encounter it, without the need for\n> any warnings.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index 4c09a093..80c17588 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -967,6 +967,17 @@ void IpaBase::applyControls(const ControlList &controls)\n> break;\n> }\n>\n> + case controls::AE_ENABLE: {\n> + /*\n> + * The AeEnable control is now just a wrapper that will already have been\n> + * converted to ExposureTimeMode and AnalogueGainMode equivalents, so there\n> + * would be nothing to do here. Nonetheless, \"handle\" the control so as to\n> + * avoid warnings from the \"default:\" clause of the switch statement.\n> + */\n> +\n> + break;\n> + }\n> +\n> case controls::AE_FLICKER_MODE: {\n> RPiController::AgcAlgorithm *agc = dynamic_cast(\n> controller_.getAlgorithm(\"agc\"));\n> --\n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB64CBE08B\n\tfor ;\n\tMon, 28 Apr 2025 13:20:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C87A968AD3;\n\tMon, 28 Apr 2025 15:20:44 +0200 (CEST)","from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com\n\t[IPv6:2607:f8b0:4864:20::92b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48E6C617DC\n\tfor ;\n\tMon, 28 Apr 2025 15:20:43 +0200 (CEST)","by mail-ua1-x92b.google.com with SMTP id\n\ta1e0cc1a2514c-86d4cb6c401so240882241.1\n\tfor ;\n\tMon, 28 Apr 2025 06:20:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"IdUgp2Gp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1745846442; x=1746451242;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=BaOyRjziGbDbvJ8mvYKkT+HzVXquTuYLzdErIAJVTCc=;\n\tb=IdUgp2GpiRtMtu124xMsMOXcGb+8DxUz9MaGwtkQ5cUnIYZ0FUjXGHbcPsEZ4txnBH\n\t8Vg2Qp75GmHkxD+Pg+0+3Sub+D9xCEURANI2Bempf2gLJbQ9HwWdrFTlwWYxMmrFHe73\n\tssefagHUj/6n6e5lp7LS/h9UW21QXlJ4dczEFR/I16ekvJ6EosUxcXaqVXERqAhX82B2\n\t2uu1hixDwgiXVs1f23tNZ1sAY3qYBhPmWMLIaPSAc8/qviY5FmeRFSTyWKmZPqI+cRIz\n\tuQigFq4EYalVLijZFFci9+dSi8nsoMVlZdIKDrFg7qRFPLXa4W1/dLJUlj1GL3Vi/Om2\n\titqQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745846442; x=1746451242;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=BaOyRjziGbDbvJ8mvYKkT+HzVXquTuYLzdErIAJVTCc=;\n\tb=g0fjkYs9CLGkAzO720ey372diTbPEoaYsngdiS/S3cUsl1mGsda0JIcDaEduJrmL7p\n\t3MiEtk55lIrumOfU85ex/PkoxJxyeTypFe2k03zlU0KkSRohHBgZHXWk7XeIXaruaN2W\n\tw8K90npZOltueg9uCMthsxwqucynrKeD0Pyg8FQpXWTNdG+jMFzSLdUI3oqPWM6oAcxR\n\tgaUagUfmIOhd9pqURu07pXWq0NPIOgIUSEI0gScTaYLlWtaa0zOG+oamLPctVcgG17WQ\n\toM95EAkWjcKRcqwJ/omWgWmXO68u7VTQBA02X8Db3xAvuEjDXZuTX+CbrT4+OgUQ+Vaf\n\toNzw==","X-Gm-Message-State":"AOJu0YwkFw03W9Dtq5kdF2axLn31R14seOIQGolhsNCIm5+0oZ2fCTnU\n\tKuk4bQF4hcrekCC5f2GCSH/17VQMKyCAfxNU3Cyf5mi+dsaUJMtY64o8bdiUtTIyzyNbjj13J5C\n\tOCgkk+nObBdeEhbw7LkyUNjdDhkaorCYLeYpnHVL94Ek/qkf2","X-Gm-Gg":"ASbGnctFD2xfkrwTEbo0xXzwg/mhuTpy+wdwjr3J3ZtPbDOBtI8S/xV2e3q9f8ExR6W\n\tTn2hTuVYPqL4xxSy5PYY8E8yHm1yqmIrrauxaZ4j8JQf5kVppiae03pecHWzCxeT7CM3e0TwUVu\n\tngZjactOzU4kDBcwWjuECSgbwcL+XfnE8gMat3gMquPw7FnQ4pq5OH3w==","X-Google-Smtp-Source":"AGHT+IH0isbonlIFTGJOLpZtyQaqkrvKiixraMv3v8QEC4WEZZx/oUAtMkAX2sGVHNG6RBucwNGDinJcER4EkmE7j1M=","X-Received":"by 2002:a05:6122:438d:b0:520:41e9:d4bf with SMTP id\n\t71dfb90a1353d-52a89d1d66amr2804041e0c.1.1745846441709;\n\tMon, 28 Apr 2025 06:20:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20250428131617.3507-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20250428131617.3507-1-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Mon, 28 Apr 2025 14:20:11 +0100","X-Gm-Features":"ATxdqUG5RfAnrFEESLY05zWqcbcJF4RIHeLiOElh8-2pwZvwze7EdUbV7gW1ea0","Message-ID":"","Subject":"Re: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control\n\tis used","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34069,"web_url":"https://patchwork.libcamera.org/comment/34069/","msgid":"<174584810673.1586992.8534183426100791926@ping.linuxembedded.co.uk>","date":"2025-04-28T13:48:26","subject":"Re: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control\n\tis used","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-04-28 14:20:11)\n> Hi David,\n> \n> Thanks for fixing this.\n> \n> On Mon, 28 Apr 2025 at 14:16, David Plowman\n> wrote:\n> >\n> > The AeEnable control is now just a wrapper that is converted to\n> > ExposureTimeMode and AnalogueGainMode controls instead. Therefore, it\n> > should simply be ignored when we encounter it, without the need for\n> > any warnings.\n> >\n> > Signed-off-by: David Plowman \n> \n> Reviewed-by: Naushir Patuck \n> \n\nReviewed-by: Kieran Bingham \n\n> > ---\n> > src/ipa/rpi/common/ipa_base.cpp | 11 +++++++++++\n> > 1 file changed, 11 insertions(+)\n> >\n> > diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> > index 4c09a093..80c17588 100644\n> > --- a/src/ipa/rpi/common/ipa_base.cpp\n> > +++ b/src/ipa/rpi/common/ipa_base.cpp\n> > @@ -967,6 +967,17 @@ void IpaBase::applyControls(const ControlList &controls)\n> > break;\n> > }\n> >\n> > + case controls::AE_ENABLE: {\n> > + /*\n> > + * The AeEnable control is now just a wrapper that will already have been\n> > + * converted to ExposureTimeMode and AnalogueGainMode equivalents, so there\n> > + * would be nothing to do here. Nonetheless, \"handle\" the control so as to\n> > + * avoid warnings from the \"default:\" clause of the switch statement.\n> > + */\n> > +\n> > + break;\n> > + }\n> > +\n> > case controls::AE_FLICKER_MODE: {\n> > RPiController::AgcAlgorithm *agc = dynamic_cast(\n> > controller_.getAlgorithm(\"agc\"));\n> > --\n> > 2.39.5\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80EAEC327D\n\tfor ;\n\tMon, 28 Apr 2025 13:48:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3912D68AD0;\n\tMon, 28 Apr 2025 15:48:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C31A468AD0\n\tfor ;\n\tMon, 28 Apr 2025 15:48:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D80AF1E3;\n\tMon, 28 Apr 2025 15:48:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ekL5Ob1y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745848104;\n\tbh=1icLg02m6mEqfLay+bn/NWxkb5f0rD8EzLtxs3nE6UY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ekL5Ob1yS8Y2v2zSzNCIcQWt/nybGbviUvjQJG3FPD1ZnZ8UJur7bcJoARNqw6ufJ\n\t5TsW9Ee3zEE9OSaYba4JcItlRDaHOpShMQohwAVnx/qdmoOvT0+QyP53hFobfXQGrS\n\tAOVnZ8jnSYAV2azVbkHWqOGbs+eI/rVUoc06WhJ8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250428131617.3507-1-david.plowman@raspberrypi.com>\n\t","Subject":"Re: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control\n\tis used","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"David Plowman ,\n\tNaushir Patuck ","Date":"Mon, 28 Apr 2025 14:48:26 +0100","Message-ID":"<174584810673.1586992.8534183426100791926@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34081,"web_url":"https://patchwork.libcamera.org/comment/34081/","msgid":"<20250429184754.GA3247@pendragon.ideasonboard.com>","date":"2025-04-29T18:47:54","subject":"Re: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control\n\tis used","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Apr 28, 2025 at 02:49:40PM +0100, Kieran Bingham wrote:\n> Quoting Kieran Bingham (2025-04-28 14:48:26)\n> > Quoting Naushir Patuck (2025-04-28 14:20:11)\n> > > On Mon, 28 Apr 2025 at 14:16, David Plowman wrote:\n> > > >\n> > > > The AeEnable control is now just a wrapper that is converted to\n> > > > ExposureTimeMode and AnalogueGainMode controls instead. Therefore, it\n> > > > should simply be ignored when we encounter it, without the need for\n> > > > any warnings.\n> > > >\n> > > > Signed-off-by: David Plowman \n> > > \n> > > Reviewed-by: Naushir Patuck \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > > > ---\n> > > > src/ipa/rpi/common/ipa_base.cpp | 11 +++++++++++\n> > > > 1 file changed, 11 insertions(+)\n> > > >\n> > > > diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> > > > index 4c09a093..80c17588 100644\n> > > > --- a/src/ipa/rpi/common/ipa_base.cpp\n> > > > +++ b/src/ipa/rpi/common/ipa_base.cpp\n> > > > @@ -967,6 +967,17 @@ void IpaBase::applyControls(const ControlList &controls)\n> > > > break;\n> > > > }\n> > > >\n> > > > + case controls::AE_ENABLE: {\n> > > > + /*\n> > > > + * The AeEnable control is now just a wrapper that will already have been\n> > > > + * converted to ExposureTimeMode and AnalogueGainMode equivalents, so there\n> > > > + * would be nothing to do here. Nonetheless, \"handle\" the control so as to\n> > > > + * avoid warnings from the \"default:\" clause of the switch statement.\n> > > > + */\n> > > > +\n> \n> Is this encountered at runtime? I wonder if the higher level should\n> 'remove' the control that has been handled from the list ... But I'm not\n> sure I like the idea of modifying the incoming control list ...\n\nWe're lacking infrastructure to modify the control list at the moment.\nThat's something we'll fix, in the meantime this workaround is fine.\n\n> > > > + break;\n> > > > + }\n> > > > +\n> > > > case controls::AE_FLICKER_MODE: {\n> > > > RPiController::AgcAlgorithm *agc = dynamic_cast(\n> > > > controller_.getAlgorithm(\"agc\"));","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA036BE08B\n\tfor ;\n\tTue, 29 Apr 2025 18:48:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D25D268AD3;\n\tTue, 29 Apr 2025 20:48:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 586BB617DB\n\tfor ;\n\tTue, 29 Apr 2025 20:48:01 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FD216A8;\n\tTue, 29 Apr 2025 20:47:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q6Bj4gB+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745952475;\n\tbh=GmQ05cAd0QYBwRzQjMYORMPzQHyp6K8mUFtEH5gXGEA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q6Bj4gB+HcUMvgZVyWkjfLmuYWZIbL2yONu4P+r0GBkCAZQC/SeylVQd19ytRI99l\n\t1zCTSXPkhWO8/98W9HzGsVAE1SPVsXT44Q42CHTdrh+NTEmwQnnIcOj15gXuXtio8Y\n\tXrgwTljPFzSEotrz4b+yHyBrhWx2l9HI0dWj/7x8=","Date":"Tue, 29 Apr 2025 21:47:54 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"David Plowman ,\n\tNaushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control\n\tis used","Message-ID":"<20250429184754.GA3247@pendragon.ideasonboard.com>","References":"<20250428131617.3507-1-david.plowman@raspberrypi.com>\n\t\n\t<174584810673.1586992.8534183426100791926@ping.linuxembedded.co.uk>\n\t<174584818065.1586992.8964503399187425405@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174584818065.1586992.8964503399187425405@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]