{"id":23295,"url":"https://patchwork.libcamera.org/api/patches/23295/?format=json","web_url":"https://patchwork.libcamera.org/patch/23295/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250428131617.3507-1-david.plowman@raspberrypi.com>","date":"2025-04-28T13:16:17","name":"ipa: rpi: common: Avoid warnings when AeEnable control is used","commit_ref":"e4677362a162b6b2174da3c844353f3321068ed0","pull_url":null,"state":"accepted","archived":false,"hash":"6331679793d8513368313691c67275e854eb233f","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23295/mbox/","series":[{"id":5150,"url":"https://patchwork.libcamera.org/api/series/5150/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5150","date":"2025-04-28T13:16:17","name":"ipa: rpi: common: Avoid warnings when AeEnable control is used","version":1,"mbox":"https://patchwork.libcamera.org/series/5150/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23295/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23295/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D04A0C327D\n\tfor ;\n\tMon, 28 Apr 2025 13:16:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 020D0617E0;\n\tMon, 28 Apr 2025 15:16:24 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9E0A617DC\n\tfor ;\n\tMon, 28 Apr 2025 15:16:21 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-43edecbfb46so30659895e9.0\n\tfor ;\n\tMon, 28 Apr 2025 06:16:21 -0700 (PDT)","from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a073e46c23sm11068219f8f.75.2025.04.28.06.16.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Apr 2025 06:16:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"oP2qrvwj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1745846181; x=1746450981;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=CNYksSi8bqqIpsuVsVY2UVwkUyKSlBUhLt/UCD7I/F4=;\n\tb=oP2qrvwjoCX7IVFldaCWAbxwrG3pklSqejiywmSmlcp00RmHcaBy/CYhb2TgKvdmNo\n\tuK7eRHr/opaXUJNjLS0QN1Mcl0jw6a9jTeyXNp/Ig2iieg3K0VF+clynPpxyGk3VxMXF\n\t7NIZZdtxDOofBfXxV/M5Ij5Sjb/Y+0HgOfoMlv86BC3RWoFZ6NHS8Mu0ZmuwtH2nCgiK\n\tJqobx9F2KanJW/J80UR0oDewQvJ6bLvHJEVHAC5ceKCtp+sCFCCQgR054MGXmKoCMtTZ\n\t0vmduOQwIEUZ8dVOWYyOrS9XupRDicXnbssHPxUVg7/7UnG4hdjxQKwcVXU54wZuQky/\n\t8EDQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745846181; x=1746450981;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=CNYksSi8bqqIpsuVsVY2UVwkUyKSlBUhLt/UCD7I/F4=;\n\tb=m3LT2hCKujpjRhFh4ZmKUk0N2VBM1JldbdwJj5DxM4Tp90oTDSBo6fowXW+LoXbEpr\n\tBa4JAZx6cZXOpORFOrbnXgqFiChDQfoOA6cchfJvCFRpFAva8vT7qv5+uKScCHovRwCU\n\tHC303BiTH8sA3d0dg2gmi5jPDuogj/VJwQ4ztZwl2ebPij3gHq9xHHVs5V2vuGZg5QxW\n\tQHDXqA5JiYgr66Qc5Y37uXfxSbHz+nm6UYTGaHAeHyA+Nyva9cFxrtPgjOdxQttU2MLl\n\t6aT1q+zHZ9dLeEAbwcvwD5uIO/NwyV7qV9pQ2ruCrgFWKSPmX204APaoisYeukcGRdvb\n\tHpOw==","X-Gm-Message-State":"AOJu0YxDRvPnv/x59YtREBrw0i7h+ayg1xyOPXkr3D3I4ttEJR+QmM06\n\tBinNaDslg7SsriWYFAUSmoPoxtXqcYGsb+oQl/iLPZjW05/4qkMaGarrWjEMpG4dwqruPq0q76J\n\tI","X-Gm-Gg":"ASbGncu2BVgseHrluigrq98BuxH0rXMkgfc4+6JVMQHOwQ50pAYvaKy3vZcYEwMTSw1\n\tTozN0oFwMTdGhmryc1S2thGeTg/EWOpHB1iokyhQumKb1UpEpl1r776sdwkKBXDBHR+veeA2pbb\n\t1q9i8HJIwehHqw5wm0elHf3faV1XMlkHbjXdRgIOexJ9hCxMoA0UPBWDWaDeTzrXnS/B0+EZz5P\n\twW+DZwrJwuDsvshiKC1KZSKV7PFjyHftBbnJceUzM7bsyr275XSxyUDXSASBQVWS7RnLaleus0M\n\tirPhjb+1YvRIPfNMD2FQDZ8DpDUbQqqu56Sk6vbZ/nUmLBmMti6zuWyoCJeYxiE28IFxaAGvPlp\n\tuuw4ur10=","X-Google-Smtp-Source":"AGHT+IGnQsGOJWNDl0q6CCdL6EXe4wQ79u2huNrkBICowVaDar0FsFp7x91Zvb6GB8neFXeeYx6Hrg==","X-Received":"by 2002:adf:e548:0:b0:391:2e6a:30fe with SMTP id\n\tffacd0b85a97d-3a07ab9bcd7mr5890824f8f.39.1745846180921; \n\tMon, 28 Apr 2025 06:16:20 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ","Subject":"[PATCH] ipa: rpi: common: Avoid warnings when AeEnable control is\n\tused","Date":"Mon, 28 Apr 2025 14:16:17 +0100","Message-Id":"<20250428131617.3507-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.5","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The AeEnable control is now just a wrapper that is converted to\nExposureTimeMode and AnalogueGainMode controls instead. Therefore, it\nshould simply be ignored when we encounter it, without the need for\nany warnings.\n\nSigned-off-by: David Plowman \n---\n src/ipa/rpi/common/ipa_base.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 4c09a093..80c17588 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -967,6 +967,17 @@ void IpaBase::applyControls(const ControlList &controls)\n \t\t\tbreak;\n \t\t}\n \n+\t\tcase controls::AE_ENABLE: {\n+\t\t\t/*\n+\t\t\t * The AeEnable control is now just a wrapper that will already have been\n+\t\t\t * converted to ExposureTimeMode and AnalogueGainMode equivalents, so there\n+\t\t\t * would be nothing to do here. Nonetheless, \"handle\" the control so as to\n+\t\t\t * avoid warnings from the \"default:\" clause of the switch statement.\n+\t\t\t */\n+\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tcase controls::AE_FLICKER_MODE: {\n \t\t\tRPiController::AgcAlgorithm *agc = dynamic_cast(\n \t\t\t\tcontroller_.getAlgorithm(\"agc\"));\n","prefixes":[]}