[{"id":34163,"web_url":"https://patchwork.libcamera.org/comment/34163/","msgid":"<418fbf93-f93e-493c-ac83-76f05ab95ed8@ideasonboard.com>","date":"2025-05-09T10:21:19","subject":"Re: [PATCH v11 19/19] libcamera: v4l2_videodevice: Log buffer count\n\ton error","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 04. 28. 11:02 keltezéssel, Sven Püschel írta:\n> Log the actual and requested buffer count in the v4l2 error,\n> when not the requested buffer count could was allocated by V4L2.\n> \n> Signed-off-by: Sven Püschel \n\nI think this is useful on its own, independent of the rest of the patch series.\n\nReviewed-by: Barnabás Pőcze \n\n> \n> ---\n> Changes in v11:\n> - Added\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index f5b3fa09..d6f8c3cd 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1326,7 +1326,8 @@ int V4L2VideoDevice::requestBuffers(unsigned int count,\n> \n> \tif (rb.count < count) {\n> \t\tLOG(V4L2, Error)\n> -\t\t\t<< \"Not enough buffers provided by V4L2VideoDevice\";\n> +\t\t\t<< \"Not enough buffers provided by V4L2VideoDevice. Wanted: \"\n> +\t\t\t<< count << \", got: \" << rb.count;\n> \t\trequestBuffers(0, memoryType);\n> \t\treturn -ENOMEM;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AE0CC3226\n\tfor ;\n\tFri, 9 May 2025 10:21:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD21F68B45;\n\tFri, 9 May 2025 12:21:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE27B68B25\n\tfor ;\n\tFri, 9 May 2025 12:21:24 +0200 (CEST)","from [192.168.33.12] (185.221.140.100.nat.pool.zt.hu\n\t[185.221.140.100])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 327838DB;\n\tFri, 9 May 2025 12:21:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IPF5Yg5L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746786072;\n\tbh=974GzDdSzbMDCdeGfUj6CYKYK56YryGzQbhHWCgZa4U=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IPF5Yg5L63CD7iq8kCORkeXbVUwGWkCDNFx0Z/w8bVC8JEdbvOiCxYY+QiL5e+Nol\n\tvnNK17pB+07E63+OkY0RFfbIvKeTALZ8MeECBeg7VNTJj8+6jMlqNtI56rRRwKry3v\n\t8llhiZmDSUDxIBlO7YbjvlltZ7C1UDoVe/lgPkGw=","Message-ID":"<418fbf93-f93e-493c-ac83-76f05ab95ed8@ideasonboard.com>","Date":"Fri, 9 May 2025 12:21:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v11 19/19] libcamera: v4l2_videodevice: Log buffer count\n\ton error","To":"=?utf-8?q?Sven_P=C3=BCschel?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250428090413.38234-1-s.pueschel@pengutronix.de>\n\t<20250428090413.38234-20-s.pueschel@pengutronix.de>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250428090413.38234-20-s.pueschel@pengutronix.de>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]