[{"id":34038,"web_url":"https://patchwork.libcamera.org/comment/34038/","msgid":"<174558271138.1586992.10117587763662735543@ping.linuxembedded.co.uk>","date":"2025-04-25T12:05:11","subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-25 11:47:02)\n> `SDLTextureYUYV` uses `SDL_PIXELFORMAT_YUY2`, which is a single plane\n> format. To support other single plane formats, replace `SDLTextureYUYV`\n> with `SDLTexture1Plane` that can be instantiated with an arbitrary SDL\n> pixel format and that uses `SDL_UpdateTexture()` to update the texture\n> using exactly a single plane.\n> \n> Signed-off-by: Barnabás Pőcze \n\nLooks neat,\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/cam/sdl_sink.cpp | 3 ++-\n> src/apps/cam/sdl_texture_1plane.h | 18 ++++++++++++++++++\n> src/apps/cam/sdl_texture_yuv.cpp | 10 ----------\n> src/apps/cam/sdl_texture_yuv.h | 7 -------\n> 4 files changed, 20 insertions(+), 18 deletions(-)\n> create mode 100644 src/apps/cam/sdl_texture_1plane.h\n> \n> diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\n> index 8355dd5ed..b295675dc 100644\n> --- a/src/apps/cam/sdl_sink.cpp\n> +++ b/src/apps/cam/sdl_sink.cpp\n> @@ -22,6 +22,7 @@\n> #include \"../common/event_loop.h\"\n> #include \"../common/image.h\"\n> \n> +#include \"sdl_texture_1plane.h\"\n> #ifdef HAVE_LIBJPEG\n> #include \"sdl_texture_mjpg.h\"\n> #endif\n> @@ -74,7 +75,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n> break;\n> #endif\n> case libcamera::formats::YUYV:\n> - texture_ = std::make_unique(rect_, cfg.stride);\n> + texture_ = std::make_unique(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride);\n> break;\n> default:\n> std::cerr << \"Unsupported pixel format \"\n> diff --git a/src/apps/cam/sdl_texture_1plane.h b/src/apps/cam/sdl_texture_1plane.h\n> new file mode 100644\n> index 000000000..ded35c589\n> --- /dev/null\n> +++ b/src/apps/cam/sdl_texture_1plane.h\n> @@ -0,0 +1,18 @@\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \"sdl_texture.h\"\n> +\n> +class SDLTexture1Plane final : public SDLTexture\n> +{\n> +public:\n> + using SDLTexture::SDLTexture;\n> +\n> + void update(libcamera::Span> data) override\n> + {\n> + assert(data.size() == 1);\n> + assert(data[0].size_bytes() == std::size_t(rect_.h * stride_));\n> + SDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> + }\n> +};\n> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n> index 7e2ce3f49..bed297d28 100644\n> --- a/src/apps/cam/sdl_texture_yuv.cpp\n> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n> @@ -21,13 +21,3 @@ void SDLTextureNV12::update(libcamera::Span\n> data[1].data(), stride_);\n> }\n> #endif\n> -\n> -SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n> - : SDLTexture(rect, SDL_PIXELFORMAT_YUY2, stride)\n> -{\n> -}\n> -\n> -void SDLTextureYUYV::update(libcamera::Span> data)\n> -{\n> - SDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> -}\n> diff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\n> index db877f503..c271f901b 100644\n> --- a/src/apps/cam/sdl_texture_yuv.h\n> +++ b/src/apps/cam/sdl_texture_yuv.h\n> @@ -17,10 +17,3 @@ public:\n> void update(libcamera::Span> data) override;\n> };\n> #endif\n> -\n> -class SDLTextureYUYV : public SDLTexture\n> -{\n> -public:\n> - SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n> - void update(libcamera::Span> data) override;\n> -};\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4BD9C327D\n\tfor ;\n\tFri, 25 Apr 2025 12:05:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8852668ACE;\n\tFri, 25 Apr 2025 14:05:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B98C4617E5\n\tfor ;\n\tFri, 25 Apr 2025 14:05:14 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BEABB982;\n\tFri, 25 Apr 2025 14:05:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cpWZbHx7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745582711;\n\tbh=C8/T14EJuImjqgIT00LKZktgavGkxumgV8W62T25Pno=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=cpWZbHx7mWgNTcquomKkFGHRsUXPvO96+aALybZNvSbM36Di8MfZJPvSbjT7YIjji\n\tJNE5C/w8ESssUgy1Ip6eG+7IhY8KoYV9cmR7ADmQEIWUXqjBA8jvm14fwN1QouDYh8\n\t0XagpGIlS+qO/L9wh9myM8qHHCYjFvMU/tAogmcs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250425104703.805170-4-barnabas.pocze@ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-4-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 25 Apr 2025 13:05:11 +0100","Message-ID":"<174558271138.1586992.10117587763662735543@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34041,"web_url":"https://patchwork.libcamera.org/comment/34041/","msgid":"<20250425124144.GC24730@pendragon.ideasonboard.com>","date":"2025-04-25T12:41:44","subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Fri, Apr 25, 2025 at 12:47:02PM +0200, Barnabás Pőcze wrote:\n> `SDLTextureYUYV` uses `SDL_PIXELFORMAT_YUY2`, which is a single plane\n> format. To support other single plane formats, replace `SDLTextureYUYV`\n> with `SDLTexture1Plane` that can be instantiated with an arbitrary SDL\n> pixel format and that uses `SDL_UpdateTexture()` to update the texture\n> using exactly a single plane.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/apps/cam/sdl_sink.cpp | 3 ++-\n> src/apps/cam/sdl_texture_1plane.h | 18 ++++++++++++++++++\n> src/apps/cam/sdl_texture_yuv.cpp | 10 ----------\n> src/apps/cam/sdl_texture_yuv.h | 7 -------\n> 4 files changed, 20 insertions(+), 18 deletions(-)\n> create mode 100644 src/apps/cam/sdl_texture_1plane.h\n> \n> diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\n> index 8355dd5ed..b295675dc 100644\n> --- a/src/apps/cam/sdl_sink.cpp\n> +++ b/src/apps/cam/sdl_sink.cpp\n> @@ -22,6 +22,7 @@\n> #include \"../common/event_loop.h\"\n> #include \"../common/image.h\"\n> \n> +#include \"sdl_texture_1plane.h\"\n> #ifdef HAVE_LIBJPEG\n> #include \"sdl_texture_mjpg.h\"\n> #endif\n> @@ -74,7 +75,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n> \t\tbreak;\n> #endif\n> \tcase libcamera::formats::YUYV:\n> -\t\ttexture_ = std::make_unique(rect_, cfg.stride);\n> +\t\ttexture_ = std::make_unique(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride);\n> \t\tbreak;\n> \tdefault:\n> \t\tstd::cerr << \"Unsupported pixel format \"\n> diff --git a/src/apps/cam/sdl_texture_1plane.h b/src/apps/cam/sdl_texture_1plane.h\n> new file mode 100644\n> index 000000000..ded35c589\n> --- /dev/null\n> +++ b/src/apps/cam/sdl_texture_1plane.h\n> @@ -0,0 +1,18 @@\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \"sdl_texture.h\"\n> +\n> +class SDLTexture1Plane final : public SDLTexture\n> +{\n> +public:\n> +\tusing SDLTexture::SDLTexture;\n> +\n> +\tvoid update(libcamera::Span> data) override\n> +\t{\n> +\t\tassert(data.size() == 1);\n> +\t\tassert(data[0].size_bytes() == std::size_t(rect_.h * stride_));\n> +\t\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> +\t}\n\nDo we need to inline this function, can't it go to a .cpp file ?\n\nWith that handled,\n\nReviewed-by: Laurent Pinchart \n\n> +};\n> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n> index 7e2ce3f49..bed297d28 100644\n> --- a/src/apps/cam/sdl_texture_yuv.cpp\n> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n> @@ -21,13 +21,3 @@ void SDLTextureNV12::update(libcamera::Span\n> \t\t\t data[1].data(), stride_);\n> }\n> #endif\n> -\n> -SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n> -\t: SDLTexture(rect, SDL_PIXELFORMAT_YUY2, stride)\n> -{\n> -}\n> -\n> -void SDLTextureYUYV::update(libcamera::Span> data)\n> -{\n> -\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> -}\n> diff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\n> index db877f503..c271f901b 100644\n> --- a/src/apps/cam/sdl_texture_yuv.h\n> +++ b/src/apps/cam/sdl_texture_yuv.h\n> @@ -17,10 +17,3 @@ public:\n> \tvoid update(libcamera::Span> data) override;\n> };\n> #endif\n> -\n> -class SDLTextureYUYV : public SDLTexture\n> -{\n> -public:\n> -\tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n> -\tvoid update(libcamera::Span> data) override;\n> -};","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56174BE08B\n\tfor ;\n\tFri, 25 Apr 2025 12:41:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 26E1468ACD;\n\tFri, 25 Apr 2025 14:41:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A08F8617E4\n\tfor ;\n\tFri, 25 Apr 2025 14:41:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B282582E;\n\tFri, 25 Apr 2025 14:41:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RHE06vR4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745584904;\n\tbh=GhNwlmv5z0Bx2uVzQql75OThF19gbYurcGnVjXkJ6iY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RHE06vR4ixcJFq7grmtl7tKyga9Zhw+nq87PO5m3HlfLEe71wdZ3v29Te1v7cgS1/\n\tHBX1d7mCCr+l3wf2HxdSayvg2b33X1yvaOx5a2vbUievHyCjAdZBUwVns97YNs70DB\n\tUdJ2D4OP3j7kK3WTo2YYrSM6ZDBIMgtsYmrRd7aU=","Date":"Fri, 25 Apr 2025 15:41:44 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","Message-ID":"<20250425124144.GC24730@pendragon.ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-4-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250425104703.805170-4-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34044,"web_url":"https://patchwork.libcamera.org/comment/34044/","msgid":"<3b402efd-e522-47e5-a853-233f09e2e39d@ideasonboard.com>","date":"2025-04-25T12:59:18","subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. 04. 25. 14:41 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> On Fri, Apr 25, 2025 at 12:47:02PM +0200, Barnabás Pőcze wrote:\n>> `SDLTextureYUYV` uses `SDL_PIXELFORMAT_YUY2`, which is a single plane\n>> format. To support other single plane formats, replace `SDLTextureYUYV`\n>> with `SDLTexture1Plane` that can be instantiated with an arbitrary SDL\n>> pixel format and that uses `SDL_UpdateTexture()` to update the texture\n>> using exactly a single plane.\n>>\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> src/apps/cam/sdl_sink.cpp | 3 ++-\n>> src/apps/cam/sdl_texture_1plane.h | 18 ++++++++++++++++++\n>> src/apps/cam/sdl_texture_yuv.cpp | 10 ----------\n>> src/apps/cam/sdl_texture_yuv.h | 7 -------\n>> 4 files changed, 20 insertions(+), 18 deletions(-)\n>> create mode 100644 src/apps/cam/sdl_texture_1plane.h\n>>\n>> diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\n>> index 8355dd5ed..b295675dc 100644\n>> --- a/src/apps/cam/sdl_sink.cpp\n>> +++ b/src/apps/cam/sdl_sink.cpp\n>> @@ -22,6 +22,7 @@\n>> #include \"../common/event_loop.h\"\n>> #include \"../common/image.h\"\n>> \n>> +#include \"sdl_texture_1plane.h\"\n>> #ifdef HAVE_LIBJPEG\n>> #include \"sdl_texture_mjpg.h\"\n>> #endif\n>> @@ -74,7 +75,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n>> \t\tbreak;\n>> #endif\n>> \tcase libcamera::formats::YUYV:\n>> -\t\ttexture_ = std::make_unique(rect_, cfg.stride);\n>> +\t\ttexture_ = std::make_unique(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride);\n>> \t\tbreak;\n>> \tdefault:\n>> \t\tstd::cerr << \"Unsupported pixel format \"\n>> diff --git a/src/apps/cam/sdl_texture_1plane.h b/src/apps/cam/sdl_texture_1plane.h\n>> new file mode 100644\n>> index 000000000..ded35c589\n>> --- /dev/null\n>> +++ b/src/apps/cam/sdl_texture_1plane.h\n>> @@ -0,0 +1,18 @@\n>> +#pragma once\n>> +\n>> +#include \n>> +\n>> +#include \"sdl_texture.h\"\n>> +\n>> +class SDLTexture1Plane final : public SDLTexture\n>> +{\n>> +public:\n>> +\tusing SDLTexture::SDLTexture;\n>> +\n>> +\tvoid update(libcamera::Span> data) override\n>> +\t{\n>> +\t\tassert(data.size() == 1);\n>> +\t\tassert(data[0].size_bytes() == std::size_t(rect_.h * stride_));\n>> +\t\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n>> +\t}\n> \n> Do we need to inline this function, can't it go to a .cpp file ?\n\nIt could certainly be in a cpp file, I can move it if you want me to. I just kept it here\nfor simplicity and because it is only used in a single cpp file.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> With that handled,\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> +};\n>> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n>> index 7e2ce3f49..bed297d28 100644\n>> --- a/src/apps/cam/sdl_texture_yuv.cpp\n>> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n>> @@ -21,13 +21,3 @@ void SDLTextureNV12::update(libcamera::Span\n>> \t\t\t data[1].data(), stride_);\n>> }\n>> #endif\n>> -\n>> -SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n>> -\t: SDLTexture(rect, SDL_PIXELFORMAT_YUY2, stride)\n>> -{\n>> -}\n>> -\n>> -void SDLTextureYUYV::update(libcamera::Span> data)\n>> -{\n>> -\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n>> -}\n>> diff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\n>> index db877f503..c271f901b 100644\n>> --- a/src/apps/cam/sdl_texture_yuv.h\n>> +++ b/src/apps/cam/sdl_texture_yuv.h\n>> @@ -17,10 +17,3 @@ public:\n>> \tvoid update(libcamera::Span> data) override;\n>> };\n>> #endif\n>> -\n>> -class SDLTextureYUYV : public SDLTexture\n>> -{\n>> -public:\n>> -\tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n>> -\tvoid update(libcamera::Span> data) override;\n>> -};\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E959BC327D\n\tfor ;\n\tFri, 25 Apr 2025 12:59:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91D9568ACB;\n\tFri, 25 Apr 2025 14:59:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51CBE617E4\n\tfor ;\n\tFri, 25 Apr 2025 14:59:21 +0200 (CEST)","from [192.168.33.12] (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86C9482E;\n\tFri, 25 Apr 2025 14:59:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EizwuZfy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745585958;\n\tbh=oRirh9qNT/OwqLtEyXutISs4Wv1QEe+PyHG6LDBDnEI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=EizwuZfy/bCqZVNpj4t/W6ApY8NlzfHeVVPLnTdhReVtEEkWRUrZkvkuwPWln1moR\n\tOmLil8bD0KURTt8eLbzyRfsLVmVKNfkXvl7NxwBm/Twc7VPPrpmCVR9RZge/4JQpIK\n\t3u0TAVY7St6jtl2YClEaE1IYo5/3yBIJx1j46JFk=","Message-ID":"<3b402efd-e522-47e5-a853-233f09e2e39d@ideasonboard.com>","Date":"Fri, 25 Apr 2025 14:59:18 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-4-barnabas.pocze@ideasonboard.com>\n\t<20250425124144.GC24730@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250425124144.GC24730@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34049,"web_url":"https://patchwork.libcamera.org/comment/34049/","msgid":"<20250425144236.GG24730@pendragon.ideasonboard.com>","date":"2025-04-25T14:42:36","subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 25, 2025 at 02:59:18PM +0200, Barnabás Pőcze wrote:\n> 2025. 04. 25. 14:41 keltezéssel, Laurent Pinchart írta:\n> > On Fri, Apr 25, 2025 at 12:47:02PM +0200, Barnabás Pőcze wrote:\n> >> `SDLTextureYUYV` uses `SDL_PIXELFORMAT_YUY2`, which is a single plane\n> >> format. To support other single plane formats, replace `SDLTextureYUYV`\n> >> with `SDLTexture1Plane` that can be instantiated with an arbitrary SDL\n> >> pixel format and that uses `SDL_UpdateTexture()` to update the texture\n> >> using exactly a single plane.\n> >>\n> >> Signed-off-by: Barnabás Pőcze \n> >> ---\n> >> src/apps/cam/sdl_sink.cpp | 3 ++-\n> >> src/apps/cam/sdl_texture_1plane.h | 18 ++++++++++++++++++\n> >> src/apps/cam/sdl_texture_yuv.cpp | 10 ----------\n> >> src/apps/cam/sdl_texture_yuv.h | 7 -------\n> >> 4 files changed, 20 insertions(+), 18 deletions(-)\n> >> create mode 100644 src/apps/cam/sdl_texture_1plane.h\n> >>\n> >> diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\n> >> index 8355dd5ed..b295675dc 100644\n> >> --- a/src/apps/cam/sdl_sink.cpp\n> >> +++ b/src/apps/cam/sdl_sink.cpp\n> >> @@ -22,6 +22,7 @@\n> >> #include \"../common/event_loop.h\"\n> >> #include \"../common/image.h\"\n> >> \n> >> +#include \"sdl_texture_1plane.h\"\n> >> #ifdef HAVE_LIBJPEG\n> >> #include \"sdl_texture_mjpg.h\"\n> >> #endif\n> >> @@ -74,7 +75,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n> >> \t\tbreak;\n> >> #endif\n> >> \tcase libcamera::formats::YUYV:\n> >> -\t\ttexture_ = std::make_unique(rect_, cfg.stride);\n> >> +\t\ttexture_ = std::make_unique(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride);\n> >> \t\tbreak;\n> >> \tdefault:\n> >> \t\tstd::cerr << \"Unsupported pixel format \"\n> >> diff --git a/src/apps/cam/sdl_texture_1plane.h b/src/apps/cam/sdl_texture_1plane.h\n> >> new file mode 100644\n> >> index 000000000..ded35c589\n> >> --- /dev/null\n> >> +++ b/src/apps/cam/sdl_texture_1plane.h\n> >> @@ -0,0 +1,18 @@\n> >> +#pragma once\n> >> +\n> >> +#include \n> >> +\n> >> +#include \"sdl_texture.h\"\n> >> +\n> >> +class SDLTexture1Plane final : public SDLTexture\n> >> +{\n> >> +public:\n> >> +\tusing SDLTexture::SDLTexture;\n> >> +\n> >> +\tvoid update(libcamera::Span> data) override\n> >> +\t{\n> >> +\t\tassert(data.size() == 1);\n> >> +\t\tassert(data[0].size_bytes() == std::size_t(rect_.h * stride_));\n> >> +\t\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> >> +\t}\n> > \n> > Do we need to inline this function, can't it go to a .cpp file ?\n> \n> It could certainly be in a cpp file, I can move it if you want me to. I just kept it here\n> for simplicity and because it is only used in a single cpp file.\n\nIt would be more consistent with the rest of the code base. I can also\npretend not to have noticed, but maybe you want to keep that joker card\nfor a future patch instead of using it here :-)\n\n> > With that handled,\n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> >> +};\n> >> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n> >> index 7e2ce3f49..bed297d28 100644\n> >> --- a/src/apps/cam/sdl_texture_yuv.cpp\n> >> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n> >> @@ -21,13 +21,3 @@ void SDLTextureNV12::update(libcamera::Span\n> >> \t\t\t data[1].data(), stride_);\n> >> }\n> >> #endif\n> >> -\n> >> -SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n> >> -\t: SDLTexture(rect, SDL_PIXELFORMAT_YUY2, stride)\n> >> -{\n> >> -}\n> >> -\n> >> -void SDLTextureYUYV::update(libcamera::Span> data)\n> >> -{\n> >> -\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> >> -}\n> >> diff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\n> >> index db877f503..c271f901b 100644\n> >> --- a/src/apps/cam/sdl_texture_yuv.h\n> >> +++ b/src/apps/cam/sdl_texture_yuv.h\n> >> @@ -17,10 +17,3 @@ public:\n> >> \tvoid update(libcamera::Span> data) override;\n> >> };\n> >> #endif\n> >> -\n> >> -class SDLTextureYUYV : public SDLTexture\n> >> -{\n> >> -public:\n> >> -\tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n> >> -\tvoid update(libcamera::Span> data) override;\n> >> -};","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CC09BE08B\n\tfor ;\n\tFri, 25 Apr 2025 14:42:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01D3568ACF;\n\tFri, 25 Apr 2025 16:42:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 264C7617E4\n\tfor ;\n\tFri, 25 Apr 2025 16:42:39 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3FDBE82E;\n\tFri, 25 Apr 2025 16:42:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j46Heojf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745592156;\n\tbh=WJaYymjXDFJBFieCGd9VbtySLbjJMKRmmCrrB4h6kro=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j46HeojfldXxlDf6Hd5Ow2roCBjt4yCXGlvrzFs2goT4wN+uB/eCtmV8ImWVXEJ+7\n\tNrOLNmR0jhWtxSvurbW/R1v3rqZpRTmYMEq9za1oqI5uU85Ififu30SzigrESH8GNo\n\tQ2AD+P3bX4MdbGBK4N0kyllBGl+TvDoAHcVtHDR4=","Date":"Fri, 25 Apr 2025 17:42:36 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/4] apps: cam: sdl_texture: Add `SDLTexture1Plane`","Message-ID":"<20250425144236.GG24730@pendragon.ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-4-barnabas.pocze@ideasonboard.com>\n\t<20250425124144.GC24730@pendragon.ideasonboard.com>\n\t<3b402efd-e522-47e5-a853-233f09e2e39d@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<3b402efd-e522-47e5-a853-233f09e2e39d@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]