[{"id":34036,"web_url":"https://patchwork.libcamera.org/comment/34036/","msgid":"<174558250301.1586992.3586149911870980051@ping.linuxembedded.co.uk>","date":"2025-04-25T12:01:43","subject":"Re: [PATCH v2 1/4] apps: cam: sdl_texture: Take list of buffers in\n\tspan","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-25 11:47:00)\n> A non-owning span is sufficient, so use that instead of a vector.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/cam/sdl_texture.h | 4 ++--\n> src/apps/cam/sdl_texture_mjpg.cpp | 2 +-\n> src/apps/cam/sdl_texture_mjpg.h | 2 +-\n> src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n> src/apps/cam/sdl_texture_yuv.h | 4 ++--\n> 5 files changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/apps/cam/sdl_texture.h b/src/apps/cam/sdl_texture.h\n> index 990f83b6e..39e1c7b38 100644\n> --- a/src/apps/cam/sdl_texture.h\n> +++ b/src/apps/cam/sdl_texture.h\n> @@ -7,7 +7,7 @@\n> \n> #pragma once\n> \n> -#include \n> +#include \n> \n> #include \n> \n> @@ -19,7 +19,7 @@ public:\n> SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat, const int stride);\n> virtual ~SDLTexture();\n> int create(SDL_Renderer *renderer);\n> - virtual void update(const std::vector> &data) = 0;\n> + virtual void update(libcamera::Span> data) = 0;\n> SDL_Texture *get() const { return ptr_; }\n> \n> protected:\n> diff --git a/src/apps/cam/sdl_texture_mjpg.cpp b/src/apps/cam/sdl_texture_mjpg.cpp\n> index cace18fc6..ca49a1142 100644\n> --- a/src/apps/cam/sdl_texture_mjpg.cpp\n> +++ b/src/apps/cam/sdl_texture_mjpg.cpp\n> @@ -76,7 +76,7 @@ int SDLTextureMJPG::decompress(Span data)\n> return 0;\n> }\n> \n> -void SDLTextureMJPG::update(const std::vector> &data)\n> +void SDLTextureMJPG::update(libcamera::Span> data)\n> {\n> decompress(data[0]);\n> SDL_UpdateTexture(ptr_, nullptr, rgb_.get(), stride_);\n> diff --git a/src/apps/cam/sdl_texture_mjpg.h b/src/apps/cam/sdl_texture_mjpg.h\n> index 37bed5f0e..be8a55fe7 100644\n> --- a/src/apps/cam/sdl_texture_mjpg.h\n> +++ b/src/apps/cam/sdl_texture_mjpg.h\n> @@ -14,7 +14,7 @@ class SDLTextureMJPG : public SDLTexture\n> public:\n> SDLTextureMJPG(const SDL_Rect &rect);\n> \n> - void update(const std::vector> &data) override;\n> + void update(libcamera::Span> data) override;\n> \n> private:\n> int decompress(libcamera::Span data);\n> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n> index 480d7a379..80a5ec05d 100644\n> --- a/src/apps/cam/sdl_texture_yuv.cpp\n> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n> @@ -15,7 +15,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n> {\n> }\n> \n> -void SDLTextureNV12::update(const std::vector> &data)\n> +void SDLTextureNV12::update(libcamera::Span> data)\n> {\n> SDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n> data[1].data(), stride_);\n> @@ -27,7 +27,7 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n> {\n> }\n> \n> -void SDLTextureYUYV::update(const std::vector> &data)\n> +void SDLTextureYUYV::update(libcamera::Span> data)\n> {\n> SDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n> }\n> diff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\n> index 29c756e77..db877f503 100644\n> --- a/src/apps/cam/sdl_texture_yuv.h\n> +++ b/src/apps/cam/sdl_texture_yuv.h\n> @@ -14,7 +14,7 @@ class SDLTextureNV12 : public SDLTexture\n> {\n> public:\n> SDLTextureNV12(const SDL_Rect &rect, unsigned int stride);\n> - void update(const std::vector> &data) override;\n> + void update(libcamera::Span> data) override;\n> };\n> #endif\n> \n> @@ -22,5 +22,5 @@ class SDLTextureYUYV : public SDLTexture\n> {\n> public:\n> SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n> - void update(const std::vector> &data) override;\n> + void update(libcamera::Span> data) override;\n> };\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97D8FBE08B\n\tfor ;\n\tFri, 25 Apr 2025 12:01:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7CDA617E5;\n\tFri, 25 Apr 2025 14:01:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E5A2617E4\n\tfor ;\n\tFri, 25 Apr 2025 14:01:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD52B982;\n\tFri, 25 Apr 2025 14:01:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z8zY9VBa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745582502;\n\tbh=SBwE8mDMnRQtY4xivl/frwMJkKCS7U0oMeNQ1+MTihc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Z8zY9VBa/It+CQtirVk115o+wYc1USCuZqy7m3y4XegcW+VQWgNASuC2LCE2i3nRH\n\tyTKq2twHU9dbwfM5W7t0pQSQRMCPNZqhHBhq4Z4Y1+TlzMkKfmPPB6USHrvrwGY5dJ\n\tAw1enMPvTo66O9uAhm9BSG+w8RVO0MehYHusCNSQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250425104703.805170-2-barnabas.pocze@ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 1/4] apps: cam: sdl_texture: Take list of buffers in\n\tspan","From":"Kieran Bingham ","Cc":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 25 Apr 2025 13:01:43 +0100","Message-ID":"<174558250301.1586992.3586149911870980051@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]