[{"id":34037,"web_url":"https://patchwork.libcamera.org/comment/34037/","msgid":"<174558253095.1586992.172314107161648877@ping.linuxembedded.co.uk>","date":"2025-04-25T12:02:10","subject":"Re: [PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-25 11:47:01)\n> If the entire texture is to be updated, there is no need to specify\n> the target area explicitly.\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n> index 80a5ec05d..7e2ce3f49 100644\n> --- a/src/apps/cam/sdl_texture_yuv.cpp\n> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n> @@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n> \n> void SDLTextureNV12::update(libcamera::Span> data)\n> {\n> - SDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n> + SDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,\n> data[1].data(), stride_);\n> }\n> #endif\n> @@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n> \n> void SDLTextureYUYV::update(libcamera::Span> data)\n> {\n> - SDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n> + SDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> }\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8A82C327D\n\tfor ;\n\tFri, 25 Apr 2025 12:02:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 466AF68ACF;\n\tFri, 25 Apr 2025 14:02:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E5F1617E4\n\tfor ;\n\tFri, 25 Apr 2025 14:02:13 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEF7A982;\n\tFri, 25 Apr 2025 14:02:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y35ya2dO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745582531;\n\tbh=dw3w3S6L/RzqJVap3fWvXnxjYC8OAOtZ6Ut+Q+ZbIXY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Y35ya2dOekBqNZDIl0nHa8wFcabo45yOF7IlUughHhImw36ExckzjzJNvBUI3heoe\n\tvguoQ24AtUQLG0lmAytiGvUmYLnfCbuG7D9GtaCeTFvcmdLleGlJMQ4ThhmRBHnd7l\n\t1d5C37l9b5zKw8ihdjagNu1J3fNhf+ByQMCNc0c4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250425104703.805170-3-barnabas.pocze@ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-3-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 25 Apr 2025 13:02:10 +0100","Message-ID":"<174558253095.1586992.172314107161648877@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34040,"web_url":"https://patchwork.libcamera.org/comment/34040/","msgid":"<20250425123539.GB24730@pendragon.ideasonboard.com>","date":"2025-04-25T12:35:39","subject":"Re: [PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Fri, Apr 25, 2025 at 12:47:01PM +0200, Barnabás Pőcze wrote:\n> If the entire texture is to be updated, there is no need to specify\n> the target area explicitly.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\n> index 80a5ec05d..7e2ce3f49 100644\n> --- a/src/apps/cam/sdl_texture_yuv.cpp\n> +++ b/src/apps/cam/sdl_texture_yuv.cpp\n> @@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n> \n> void SDLTextureNV12::update(libcamera::Span> data)\n> {\n> -\tSDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n> +\tSDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,\n> \t\t\t data[1].data(), stride_);\n> }\n> #endif\n> @@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n> \n> void SDLTextureYUYV::update(libcamera::Span> data)\n> {\n> -\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n> +\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17F14C327D\n\tfor ;\n\tFri, 25 Apr 2025 12:35:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E36F9617E5;\n\tFri, 25 Apr 2025 14:35:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD488617E4\n\tfor ;\n\tFri, 25 Apr 2025 14:35:43 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8371082E;\n\tFri, 25 Apr 2025 14:35:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kQ19SEcL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745584540;\n\tbh=ha6we+IxjgKgC1oXleRPhYmcngI2ppZKi9G5ZpGu/XM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kQ19SEcLLKVE7LTnE9yWzqMaFWqSvJb1wccwtATnKLnblBgwZUTRsZ6ACa+9Vi/Ic\n\tD/EMDWN8CKFQ8iBjdVzC+CqBGlTh6gZwtJDdhP0nhXivK+buJxlD7u7l/HLK2LHJQS\n\tuhtbgMiSST8p3UdPyhfD13CT6JKjxjYXDBRkYgYY=","Date":"Fri, 25 Apr 2025 15:35:39 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call","Message-ID":"<20250425123539.GB24730@pendragon.ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>\n\t<20250425104703.805170-3-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250425104703.805170-3-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]