{"id":23263,"url":"https://patchwork.libcamera.org/api/patches/23263/?format=json","web_url":"https://patchwork.libcamera.org/patch/23263/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250425104703.805170-3-barnabas.pocze@ideasonboard.com>","date":"2025-04-25T10:47:01","name":"[v2,2/4] apps: cam: sdl_texture: Drop `&rect_` from `SDL_Update{NV, }Texture()` call","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"afb8b0f6e3e83e23b92a98603b2eff5b6fbcd795","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23263/mbox/","series":[{"id":5146,"url":"https://patchwork.libcamera.org/api/series/5146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5146","date":"2025-04-25T10:46:59","name":"apps: cam: sdl_sink: Support more RGB and YUV formats","version":2,"mbox":"https://patchwork.libcamera.org/series/5146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23263/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23263/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 166B5C32A2\n\tfor ;\n\tFri, 25 Apr 2025 10:47:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D020D68AD8;\n\tFri, 25 Apr 2025 12:47:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C041668ACB\n\tfor ;\n\tFri, 25 Apr 2025 12:47:07 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE8A2124E\n\tfor ;\n\tFri, 25 Apr 2025 12:47:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gnSsj8LO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745578025;\n\tbh=YhNNqglt/zGP3v8gtTaQBRpgzFQHtZfic8dywdGJx/0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gnSsj8LOb9qmWLX3Pq6PhhXhBl0k78Ha+0RJPs5tqRAsDrWbshZ5vruR77q63mQrU\n\tf3ktpMw18lLse1e1r5E7b3i9+apKd1PK5F0Gaodif45fADj77HwFcSS42QfB63y4BP\n\t1aQbvUETtnusyKHGx7AEspQQryh5tXBhcBC0t+Cc=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call","Date":"Fri, 25 Apr 2025 12:47:01 +0200","Message-ID":"<20250425104703.805170-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>","References":"<20250425104703.805170-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the entire texture is to be updated, there is no need to specify\nthe target area explicitly.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex 80a5ec05d..7e2ce3f49 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n \n void SDLTextureNV12::update(libcamera::Span> data)\n {\n-\tSDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n+\tSDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,\n \t\t\t data[1].data(), stride_);\n }\n #endif\n@@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n \n void SDLTextureYUYV::update(libcamera::Span> data)\n {\n-\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n+\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n }\n","prefixes":["v2","2/4"]}