{"id":23256,"url":"https://patchwork.libcamera.org/api/patches/23256/?format=json","web_url":"https://patchwork.libcamera.org/patch/23256/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250424114103.451395-5-barnabas.pocze@ideasonboard.com>","date":"2025-04-24T11:40:58","name":"[RFC,v5,4/9] libcamera: process: Return error if already running","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3cf35decd8df98f157ae4b69bc421e36632804f0","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23256/mbox/","series":[{"id":5145,"url":"https://patchwork.libcamera.org/api/series/5145/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5145","date":"2025-04-24T11:40:54","name":"libcamera: process: Remove `ProcessManager` singleton","version":5,"mbox":"https://patchwork.libcamera.org/series/5145/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23256/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23256/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75E12C327D\n\tfor ;\n\tThu, 24 Apr 2025 11:41:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CF7268AD5;\n\tThu, 24 Apr 2025 13:41:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EB7B68ACC\n\tfor ;\n\tThu, 24 Apr 2025 13:41:08 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3674F1666;\n\tThu, 24 Apr 2025 13:41:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qE82I3ol\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745494866;\n\tbh=Qz9cUuFaDliK3CR4EEBKiEQbQrPsPaP/+AEhQUc9DRE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qE82I3olg4Er13shwbs8T1XAI7zaZeKcHq4ZveIj/ljZwpEukCRsaf3QUNeEJeCBa\n\tO422XIZ5xrWqk/tJQGw+ivpD6JYCHdvj6Hqqy6zai2RPlkgM2ihViy2KhZOk2K3CmQ\n\tZq+U7F49cels9R9OsTRZYoo++GZ2sCw/5dyr20kA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v5 4/9] libcamera: process: Return error if already\n\trunning","Date":"Thu, 24 Apr 2025 13:40:58 +0200","Message-ID":"<20250424114103.451395-5-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>","References":"<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Returning 0 when a running process is already managed can be confusing\nsince the parameters might be completely different, causing the caller\nto mistakenly assume that the program it specified has been started.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/process.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex c22c9af5d..ca9733d77 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -241,7 +241,7 @@ int Process::start(const std::string &path,\n \tint ret;\n \n \tif (pid_ > 0)\n-\t\treturn 0;\n+\t\treturn -EBUSY;\n \n \tint childPid = fork();\n \tif (childPid == -1) {\n","prefixes":["RFC","v5","4/9"]}