{"id":23243,"url":"https://patchwork.libcamera.org/api/patches/23243/?format=json","web_url":"https://patchwork.libcamera.org/patch/23243/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250424112203.445351-2-barnabas.pocze@ideasonboard.com>","date":"2025-04-24T11:21:54","name":"[RFC,v4,1/9] libcamera: process: Disable copy/move","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1889ee2939b66ca847911da55f315eda8bc39baa","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23243/mbox/","series":[{"id":5144,"url":"https://patchwork.libcamera.org/api/series/5144/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5144","date":"2025-04-24T11:21:53","name":"libcamera: process: Remove `ProcessManager` singleton","version":4,"mbox":"https://patchwork.libcamera.org/series/5144/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23243/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23243/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0945C327D\n\tfor ;\n\tThu, 24 Apr 2025 11:22:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D92768AD1;\n\tThu, 24 Apr 2025 13:22:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08B6168AC7\n\tfor ;\n\tThu, 24 Apr 2025 13:22:07 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF5A216A;\n\tThu, 24 Apr 2025 13:22:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CriwA/8N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745493725;\n\tbh=/i8v1siOOqDzDe2JqXG0KEGLYIr+ubhZNLVjfELyg30=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CriwA/8NkbA9Zyb/9ZzjA4pOLahpiBSSnmCTs34wMyc77WdIi4ONkhZVSTmFQ1sOT\n\t9HPXvpuTyjzxLiGzLIFY1rBTCKA4NEshlE1kYc/yQ4TB+YTJSPBIq02xc3MO1vRQ58\n\tV852D91G46hI4/aZOoT+h6jiJWovr33EJlIbhBlQ=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v4 1/9] libcamera: process: Disable copy/move","Date":"Thu, 24 Apr 2025 13:21:54 +0200","Message-ID":"<20250424112203.445351-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250424112203.445351-1-barnabas.pocze@ideasonboard.com>","References":"<20250424112203.445351-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A `Process` object has address identity because a pointer to it is\nstored inside the `ProcessManager`. However, copy/move special\nmethods are still generated by the compiler. So disable them to\navoid potential issues and confusion.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/process.h | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\nindex b1d07a5a5..6c34aef2f 100644\n--- a/include/libcamera/internal/process.h\n+++ b/include/libcamera/internal/process.h\n@@ -11,6 +11,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n \n@@ -42,6 +43,8 @@ public:\n \tSignal finished;\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Process)\n+\n \tvoid closeAllFdsExcept(const std::vector &fds);\n \tint isolate();\n \tvoid died(int wstatus);\n","prefixes":["RFC","v4","1/9"]}