{"id":23231,"url":"https://patchwork.libcamera.org/api/patches/23231/?format=json","web_url":"https://patchwork.libcamera.org/patch/23231/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250422215920.4297-19-bryan.odonoghue@linaro.org>","date":"2025-04-22T21:59:11","name":"[18/27] libcamera: software_isp: Make the debayer_ object of type class Debayer not DebayerCpu","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"6dc05b625b15a71b456dc73c7d9aa5e727b681f4","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23231/mbox/","series":[{"id":5142,"url":"https://patchwork.libcamera.org/api/series/5142/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5142","date":"2025-04-22T21:58:53","name":"RFC: Add in a eGL based GPUISP in libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5142/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23231/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23231/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75C3FC3321\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 21:59:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 063D368B38;\n\tTue, 22 Apr 2025 23:59:56 +0200 (CEST)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0404E68AD0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 23:59:41 +0200 (CEST)","by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-43690d4605dso46293375e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:59:41 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"vhW8DeEk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359180; x=1745963980;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=s22tvATEek2jn56FeC27txLuiJp6vxiU1oIGShzPMbs=;\n\tb=vhW8DeEkTgPnzHtjtj/nTg/Wqmj3ak4v1jg2HfFaCVnSpqPaZM7F9plXWi0z53NRvO\n\taA9QobuzlEFJBqIA8OiDeTz1nwBGgmQAwVovpb7vW2hqqVJf5+kHptCL/oBKIwDV3IMO\n\t1MNAVrioyqmR7Zaz/aE6gGZTN+jQWgwZC0QkXNI58rMygdcPgWRIg49sTyKi5dEQeXSW\n\tpYdAuYsClqS9I9E2tZaNJs96iK4n2E9Xx7EYq6BdcKmN4kFunKd8wgPx43ZuZHc7k8+U\n\t32bUxLDFasmV+U72h4fZBXXpMwdRNKh4UrvS8+qlokJe+zKWpyvigH2ZqXbX47UHHG4+\n\tBqUA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359180; x=1745963980;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=s22tvATEek2jn56FeC27txLuiJp6vxiU1oIGShzPMbs=;\n\tb=IJAjjZTr1coR7HRoDQ+YIdAEkcgLmPm1tOumogTDci2OvagjNxESAssuBHEc0USrgp\n\tST5DMaGcgYB1yzIcuet9G1sa72RRSJk5m303Ls0kcNyDWVDRfzS1fcpou5TFgTevLfnu\n\to3ItPAP25sKa3EesY1AvLro8lcVwxURKy8331mfAlBHVxn93X//ilceRUliOClWB/Jtt\n\tz/Hw+nV7Dzb5ibxvtX/FE22+98se+irKy+sKpVmjgzkzYpZfZ+lnMlWLAQeUJ6iDGyqE\n\tOphB9Q7xyWkMzQKxd0YCKGVU4vzNsPyaX/VBCiWBNRQBjGPB/g04stzkTo4+T3zoASwW\n\t7zuw==","X-Gm-Message-State":"AOJu0YwczJcdMBZHEf6NTdcH5bQTGS+UXNpVqc291FkW1FMyNlpgoFuN\n\tYULoex/psmHUCrHEfY6OhKXvJsA/dZ9BSmEpsL5AgF5AB16CKDp1g8VjtEkGSWl6hNH8IPTislE\n\tWfY4=","X-Gm-Gg":"ASbGncu5Yok/VnGoZ5IFP7oWF/0f2U9YWvWniiCA9sZ8OmAfcJnZ5XKcE0fGeWe/t7o\n\t9P0YqqOdRwh9g41k7kMTuEFT0PYJv0dbY24sQ0QJLmqY9gyek7r+pW5z88DRVdefAEptZdawyeq\n\tJdOvdESlpQZvVwTZ5XhWJJBFPxa5l4c1Y2IG3P8QUrOQt0DwF5xfcHoDObUIc73W3wrTgW4UdfZ\n\t1NSASq7aUvPUqxdXpDgfjxH3VFzOfYfoEaQDTmQVQXGFgvVSVgONc85j+1wINy+Dd+jCaUGokp9\n\ttLe9V1lojkD6PQmXURGAR+zrF3ZWYDZUvTZnmFrNfsghlmV42VLauT/JMai/HK2ciBJ3Go3vv3a\n\tsPAVZ0S+w51RGXlLhD6VI","X-Google-Smtp-Source":"AGHT+IGOWZNCI3xjk2EeqvStTWbtCYGgJ/lu9QTkmFs0PYwwzNyIYcWci8opl93Jz/qBdGy5HztUMg==","X-Received":"by 2002:a05:600c:4e09:b0:43c:f513:958a with SMTP id\n\t5b1f17b1804b1-4406ab9e3ecmr163334415e9.13.1745359180387; \n\tTue, 22 Apr 2025 14:59:40 -0700 (PDT)","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","Subject":"[PATCH 18/27] libcamera: software_isp: Make the debayer_ object of\n\ttype class Debayer not DebayerCpu","Date":"Tue, 22 Apr 2025 22:59:11 +0100","Message-ID":"<20250422215920.4297-19-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","References":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Make the type of object Debayer not DebayerCpu thus allowing us to assign\nthe object to either DebayerCpu or DebayerEGL.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 78624659..ad89c9b3 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -37,7 +37,7 @@\n \n namespace libcamera {\n \n-class DebayerCpu;\n+class Debayer;\n class FrameBuffer;\n class PixelFormat;\n class Stream;\n@@ -94,8 +94,7 @@ private:\n \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n \tvoid inputReady(FrameBuffer *input);\n \tvoid outputReady(FrameBuffer *output);\n-\n-\tstd::unique_ptr<DebayerCpu> debayer_;\n+\tstd::unique_ptr<Debayer> debayer_;\n \tThread ispWorkerThread_;\n \tSharedMemObject<DebayerParams> sharedParams_;\n \tDebayerParams debayerParams_;\n","prefixes":["18/27"]}