{"id":23230,"url":"https://patchwork.libcamera.org/api/patches/23230/?format=json","web_url":"https://patchwork.libcamera.org/patch/23230/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250422215920.4297-18-bryan.odonoghue@linaro.org>","date":"2025-04-22T21:59:10","name":"[17/27] libcamera: software_isp: Move DMA sync code to common place in Debayer base","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"3be7056bd0db9e79c854c2d097807c580fa22c17","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23230/mbox/","series":[{"id":5142,"url":"https://patchwork.libcamera.org/api/series/5142/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5142","date":"2025-04-22T21:58:53","name":"RFC: Add in a eGL based GPUISP in libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5142/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23230/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23230/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7D7EC331F\n\tfor ;\n\tTue, 22 Apr 2025 21:59:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CABA368B4D;\n\tTue, 22 Apr 2025 23:59:53 +0200 (CEST)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A86868B38\n\tfor ;\n\tTue, 22 Apr 2025 23:59:40 +0200 (CEST)","by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-39ee651e419so3305100f8f.3\n\tfor ;\n\tTue, 22 Apr 2025 14:59:40 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"gr9iCbVw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359179; x=1745963979;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=HecQjDX8odq8vh0GEKVOyqoBNzt/soNQ5HnQV1kdZcU=;\n\tb=gr9iCbVwfdaLlcIyeb25Saw2HeESwK1JWeA+bzbWiWI6Lmbj/3dARq12tATBNiWcmv\n\t41nvueZVDU2uS1tSaIqPjjja2YdtqfjF91dcyvuShQ295VbzmcGUd6zhrogHS7/TcOIp\n\tKfxgXKEMM8SzvLu8bXdWBr1f36kzxdlZYovvE+gb7Yn53G4H6VmmvuoKv6vrM00vZNic\n\tOKOfHChE8+dYArjpmptSI9LBm1WsK8/Ghk3b0aw/KKg2Z2QbJa7ipe5KQFSshapnUxHV\n\t+5VOTKC7xbMFGs4p0bDQXmIzMGZriz0F8KUtqSlBf5XIxTHvWv6e898YZFDMctdRtheC\n\tR4bg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359179; x=1745963979;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=HecQjDX8odq8vh0GEKVOyqoBNzt/soNQ5HnQV1kdZcU=;\n\tb=MYvuMHQfPeMMYQquxtUpRjOHt/lOe6RCDiURHRdbYw97DsNo52w/lfHKLgU9yoR86E\n\tl8DoIwPqBVpNSZdcRwS57sKjXEr0ChxK3JjmibQIWJXkaQ4UnJ+ucKK+t+jjNzXcQ43X\n\tNqa3Gzmd1/j9Y3ISNuqnc92GljYCk8sRUWHHpcmey/r8cue1zvwDlMKkkqu+Vw11/lR/\n\tMptRdTWP7ykqP6uw3kaj6mRPC9R3qGNNtU55nn5B7+MeKlnTdTv9lqK93BkOrsT96aiI\n\tyPTXbxtTQeaNJ3lfdMUAWwMjjGpqQ83e5tcFttr3GwVsdMZjVNZehtkqy0JHscqKi79p\n\tF4sQ==","X-Gm-Message-State":"AOJu0YzJYISgyNXi0Zs1bwPYUdUCEh17V+wWPWCmeirhvwQ0nBhOQn2a\n\tCvItQzCXs+X4OVpzGBKeM94GJeww9otneTmqOeYhQgFGea69cQdVBfXvbFhtGJ+xFdnmGISUbY4\n\tXqS4=","X-Gm-Gg":"ASbGncsOiRaT/OywQCgJEhk4XCqTbjKcC7mKsUZvTrUGR1NYonw0V968azbq27gNaK6\n\tYxa6jziaMKWg2v3mhKFWNXzi9hRV1WSFNGu9ALcNLLNhRL1ojH+7vZnPh2nMzAcZHq2J+Ujm4RO\n\tY+7jzJTjQQFn1Zgh1tro+ESHIl1sKTZq22h+IuOmzqr9wc8oJIhhui7BkVGSGEtAj/7l0UMuR6O\n\tbkXHTJuFYkKqspN7Rv0up4aHDpGmDG2BNOJ8QSH/oXrI6/KOkb8XCcSnd3m9sp4NYunlHnIRNxT\n\tEwrUrLUCq5+Lrxv16qBW+RUWM4fPlE4RYrFXX3GDgdv0mV0rfLtS803OCzHLD9yTPfwWtDW8aW8\n\t/TeSxKRk4KSq9KxX+54Vg","X-Google-Smtp-Source":"AGHT+IEGU+TzHtJXKaxOds8dOYgc4To9Q4jKhwW6GsSrwqBYIXW3BQbApvL5/9yNzU8xFMog+gGNiw==","X-Received":"by 2002:a05:6000:40dc:b0:39e:cbca:922f with SMTP id\n\tffacd0b85a97d-39efba3655cmr11768385f8f.12.1745359179434; \n\tTue, 22 Apr 2025 14:59:39 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","Subject":"[PATCH 17/27] libcamera: software_isp: Move DMA sync code to common\n\tplace in Debayer base","Date":"Tue, 22 Apr 2025 22:59:10 +0100","Message-ID":"<20250422215920.4297-18-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","References":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The DMA Sync code is directly reusable in eGLISP move to the Debayer base\nclass to facilitate reuse.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.cpp | 13 +++++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n src/libcamera/software_isp/debayer_cpu.cpp | 6 +-----\n 3 files changed, 16 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 3d883b28..25cfd1a1 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -203,4 +203,17 @@ void Debayer::setParams(DebayerParams ¶ms)\n \tgammaLut_ = params.gammaLut;\n }\n \n+/**\n+ * \\fn void Debayer::dmaSyncBegin(DebayerParams ¶ms)\n+ * \\brief Common CPU/GPU Dma Sync Buffer begin\n+ */\n+void Debayer::dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *input, FrameBuffer *output)\n+{\n+\tfor (const FrameBuffer::Plane &plane : input->planes())\n+\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n+\n+\tfor (const FrameBuffer::Plane &plane : output->planes())\n+\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 9cebcbe8..c8ce14f0 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -20,6 +20,7 @@\n #include \n #include \n \n+#include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/software_isp/benchmark.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n \n@@ -86,6 +87,7 @@ private:\n protected:\n \n \tvoid setParams(DebayerParams ¶ms);\n+\tvoid dmaSyncBegin(std::vector &dmaSyncers,FrameBuffer *input, FrameBuffer *output);\n \n };\n \ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex baec4799..987f225f 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -22,7 +22,6 @@\n #include \n \n #include \"libcamera/internal/bayer_format.h\"\n-#include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\n \n@@ -748,11 +747,8 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \tbench_.startFrame();\n \n \tstd::vector dmaSyncers;\n-\tfor (const FrameBuffer::Plane &plane : input->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n \n-\tfor (const FrameBuffer::Plane &plane : output->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\tdmaSyncBegin(dmaSyncers, input, output);\n \n \tsetParams(params);\n \n","prefixes":["17/27"]}