{"id":23216,"url":"https://patchwork.libcamera.org/api/patches/23216/?format=json","web_url":"https://patchwork.libcamera.org/patch/23216/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250422215920.4297-4-bryan.odonoghue@linaro.org>","date":"2025-04-22T21:58:56","name":"[03/27] libcamera: dma_buf_allocator: Favour udmabuf over cma heap allocations","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"650bd0c39ae85b8061b8a0daf914cbb6379c4890","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23216/mbox/","series":[{"id":5142,"url":"https://patchwork.libcamera.org/api/series/5142/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5142","date":"2025-04-22T21:58:53","name":"RFC: Add in a eGL based GPUISP in libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5142/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23216/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23216/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27CA7C32A2\n\tfor ;\n\tTue, 22 Apr 2025 21:59:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE68B68AD8;\n\tTue, 22 Apr 2025 23:59:28 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FFDA617E3\n\tfor ;\n\tTue, 22 Apr 2025 23:59:26 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-43cef035a3bso39939665e9.1\n\tfor ;\n\tTue, 22 Apr 2025 14:59:26 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"u1daEMSh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359165; x=1745963965;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=L2Y6auKQbWbB47K5RKdIYrjH8wAq46MTq5RtJq3yzk8=;\n\tb=u1daEMShs9VIRRXUukPCi0faMNDUJWEHNsNdbMlRfAwYmvXg8+S9bTLQlaptCtZze2\n\tu0l5qw+q+FJi1ju8LHD6O1ddtsv9qzRXyRZCKUTTrMuFy9qlJhXcPOc73lq9mnXbCyvu\n\tqX1pKl7OB5oKyvRJIAcSuLN/9tsGB6FFSSIxl75e3sgX1lOafZ1lyu1cTDaMwYODIo8n\n\tAUgit+LAorAqPs9vrJXDSsa0bx5B+sMpKf33rsA6E3qrcgp+8ivNTzDGgXlrcTCEiTHu\n\tdGQSKG0KHOEOidBt1iycYxoKPaaK3UQKYY8Jw2SQdBZWSdAkZVAZdt8SpFPHtz6pVXEQ\n\tKdew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359165; x=1745963965;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=L2Y6auKQbWbB47K5RKdIYrjH8wAq46MTq5RtJq3yzk8=;\n\tb=JOGmg3U6XTNvmjuLxO4HcBhDLLSv430wBLT58kGBhdq51KkFlRm6SndSMwNm4m+dEA\n\tEaU4+asyalVrj1KTnRC5vlKa+8FM+DM/9Kb3EMbxu3lXDDJSuluQSgQCIFPVrBJZat8/\n\t+pb0mT1WwZf5EXYGvRxbm0+P8mIMMeb8r0eNNRN6miBMwUUGDE4skg2KBOAA/sUBHW3D\n\twy3kUhb6Zy1197IJmPQG9sDUDAJElTNZdrGzeDrbn8Ok7EDVHqI1lnwTzd1cBOCRqH03\n\tYREk8mLpUw7Vivdw3VPSxoMmupsylFJEDmLQeA8+cnR3idZGPEMbEDwB/zuA7Oxv22va\n\tfhHw==","X-Gm-Message-State":"AOJu0Yx6QXjsJ0Lqe2mRPt5Pi5OdPuWZQhRnRFHMAbuEBFyxkmapCjYz\n\tXtCCDLhXSQmLlra7tQOPedIgEJEyif/shGitNBlqxmwdHqruDY36/QxBT1HFP9QT8qL+8dJVxdw\n\tuCfM=","X-Gm-Gg":"ASbGncsUU4nBRvnoagcb/QtrKbyW+BG70shmupn7wDq5az9zb+ado6OJ2gYgxOFdNzw\n\tTSlG2TwyNiptOXb/27bzTE46mXStQOa5Obg4bp1aiVy4YaaRoVaRAPQQPnCnGCQ80aWyu8If3ur\n\t23+s9TqPU0UhcjnEv55ADWh7NwmowuyV0GsC61l2GaBp8/ggjGKGTPAkdiADbO4wHAEc5lVaDwl\n\tJ3Q0CyysKM6hCCScAtas/JB3Sg+eOdqk0SCUhtMqzxO1Vn7eNrx+O52XW7XfdOdnpCgBoCohxBo\n\tFCiQCVe+EWmPzH56ozEfBkOxV9kVgzF2HlFlLmQA+LNwSvndTIO4xtamD/NPvcTsAQd5pv5BKgy\n\t+LBVCvUdEP0zUu1lpofio","X-Google-Smtp-Source":"AGHT+IEdb5JRZXYkKfavS9mMAPjUvQO/riVMgzKTbQoEzy/XbjElgaJf4tCCwrVEFScRQpYE60JxdQ==","X-Received":"by 2002:a05:600c:1911:b0:43d:9d5:474d with SMTP id\n\t5b1f17b1804b1-4406aa8b882mr160895285e9.0.1745359165425; \n\tTue, 22 Apr 2025 14:59:25 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","Subject":"[PATCH 03/27] libcamera: dma_buf_allocator: Favour udmabuf over cma\n\theap allocations","Date":"Tue, 22 Apr 2025 22:58:56 +0100","Message-ID":"<20250422215920.4297-4-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","References":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When /dev/dma_heap/linux,cma or /dev/dma_heap/system exist currently we\nfavour allocation from this type of heap over /dev/udmabuf.\n\nWe ought to favour udmabuf though\n\n- udmabuf is the preferred method by various distros for security reasons\n- Contiguous memory is a scarce resource\n\nChange the ordering of the allocator lookup so that the udmabuf lookup\ncomes first.\n\nFixes: ea4baaacc325 (\"libcamera: DmaBufAllocator: Support allocating from /dev/udmabuf\")\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/dma_buf_allocator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/dma_buf_allocator.cpp b/src/libcamera/dma_buf_allocator.cpp\nindex d8c62dd6..722ffd46 100644\n--- a/src/libcamera/dma_buf_allocator.cpp\n+++ b/src/libcamera/dma_buf_allocator.cpp\n@@ -45,10 +45,10 @@ static constexpr std::array providerInfos = { {\n \t * /dev/dma_heap/linux,cma is the CMA dma-heap. When the cma heap size is\n \t * specified on the kernel command line, this gets renamed to \"reserved\".\n \t */\n+\t{ DmaBufAllocator::DmaBufAllocatorFlag::UDmaBuf, \"/dev/udmabuf\" },\n \t{ DmaBufAllocator::DmaBufAllocatorFlag::CmaHeap, \"/dev/dma_heap/linux,cma\" },\n \t{ DmaBufAllocator::DmaBufAllocatorFlag::CmaHeap, \"/dev/dma_heap/reserved\" },\n \t{ DmaBufAllocator::DmaBufAllocatorFlag::SystemHeap, \"/dev/dma_heap/system\" },\n-\t{ DmaBufAllocator::DmaBufAllocatorFlag::UDmaBuf, \"/dev/udmabuf\" },\n } };\n \n LOG_DEFINE_CATEGORY(DmaBufAllocator)\n","prefixes":["03/27"]}