[{"id":33995,"web_url":"https://patchwork.libcamera.org/comment/33995/","msgid":"","date":"2025-04-22T15:52:15","subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mardi 22 avril 2025 à 16:25 +0200, Jaslo Ziska a écrit :\n> Now that read- and write-only controls are supported add the remaining\n> controls.\n> \n> Signed-off-by: Jaslo Ziska \n> ---\n>  utils/codegen/gen-gst-controls.py | 16 +++++++++-------\n>  1 file changed, 9 insertions(+), 7 deletions(-)\n> \n> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> index 4ca76049..664e4c41 100755\n> --- a/utils/codegen/gen-gst-controls.py\n> +++ b/utils/codegen/gen-gst-controls.py\n> @@ -19,13 +19,15 @@ from controls import Control\n>  \n>  \n>  exposed_controls = [\n> -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> -    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> -    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> -    'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> -    'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> -    'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',\n> -    'LensPosition', 'Gamma',\n> +    'AeEnable', 'AeState', 'AeMeteringMode', 'AeConstraintMode',\n> +    'AeExposureMode', 'ExposureValue', 'ExposureTime', 'AnalogueGain',\n> +    'AnalogueGainMode', 'AeFlickerMode', 'AeFlickerPeriod',\n> +    'AeFlickerDetected', 'Brightness', 'Contrast', 'Lux', 'AwbEnable',\n> +    'AwbMode', 'AwbLocked', 'ColourGains', 'ColourTemperature', 'Saturation',\n> +    'SensorBlackLevels', 'Sharpness', 'FocusFoM', 'ColourCorrectionMatrix',\n> +    'ScalerCrop', 'DigitalGain', 'SensorTemperature', 'AfMode', 'AfRange',\n> +    'AfSpeed', 'AfMetering', 'AfWindows', 'LensPosition', 'AfState',\n> +    'AfPauseState', 'HdrMode', 'HdrChannel', 'Gamma',\n\nCan we ditch the formater and just make one vertical row ? That would\nmake the diff useful. If not, the list of added controls should be in\nthe description.\n\nNicolas\n\n>  ]\n>  \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83063C327D\n\tfor ;\n\tTue, 22 Apr 2025 15:52:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE4D468ACD;\n\tTue, 22 Apr 2025 17:52:19 +0200 (CEST)","from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com\n\t[IPv6:2607:f8b0:4864:20::f30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7426B68ACA\n\tfor ;\n\tTue, 22 Apr 2025 17:52:17 +0200 (CEST)","by mail-qv1-xf30.google.com with SMTP id\n\t6a1803df08f44-6eeb7589db4so58753356d6.1\n\tfor ;\n\tTue, 22 Apr 2025 08:52:17 -0700 (PDT)","from ?IPv6:2606:6d00:15:9913::5ac? ([2606:6d00:15:9913::5ac])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-6f2c2c22748sm58986646d6.114.2025.04.22.08.52.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 08:52:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"jW6i/Y0W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1745337136;\n\tx=1745941936; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=6tBITKntbXlf5LqdGQmfKJqyJ65t63pxWvOV4+k9i9E=;\n\tb=jW6i/Y0WOmKEXcvLw9Lp+9zju2IIeLMt6tDUUru5DAqmJc45fTTV991GjiNukfkVih\n\tbYP/Kfjt1yjbOJcM7J/5U+MbMxhlwAp43utVyw7i8C79Nk4/PqQq+TnI5BLV0CB2UIOK\n\tqTh91IRFfp6A08i860DSNwh/+D9T+6K1vEAP1g74V5uPbDKBD0bYvX02MfO/+2f6aazp\n\tp2BGU+aqJTkqmYZCd2gehWuPQHowm0cqmsp0Tq3yiQP5E2ciq/fOB4G7VhCPm9KNZ1g7\n\tPZImjI63dccda7aXtwU31w6GJKzNrsYIJtWp7T1IEP9C1jAdfOAvdSkjm7mSm1QKWqKD\n\tQjZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745337136; x=1745941936;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=6tBITKntbXlf5LqdGQmfKJqyJ65t63pxWvOV4+k9i9E=;\n\tb=LLr3RFX2QHzaARZQG3fWLpo0fPyuyUEnbh8zNd7WY0YnepduXVAJMozOIbFGqBzt5F\n\t6c4+O8PBa8M4o+mUWzRoaQotjH957AmJOjLElZy8AQxaz7CvmPssmCjoIGdB251g/uCi\n\tdGE7AUjiiew/AYv89VwPFvJ2pj1NhsXzJ0kcNQBh+2vny3ipY0QuWs1KygrBvuWk9mrS\n\tGu+tV2bAE3FcwQQ7eK8IxUK8XfF/jRtf9Ou996LaH9mdhI+wX5DfEHJEhGoiSuE6C5ly\n\thHsP9tPc2MstbxwFQn8niC+9Nf4dCNee1d01mFb8s81PtVseCWV6/L15pyrNKNo6/LS+\n\twN9A==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWQZMXnQnZlRS8RrtGDktMwdttGeyPWvJqa2k+pWPaEqNHq94lY3jcKoIeHhQNquAkefL4CzW3nUvOPyeAKuw4=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YzevU80UQqF0S1+0o8qdd8awy5H3Hv11WvRvkVH5LLpZkahvUG1\n\tx5zeFr2uX6g/pZG5rWYMB0ShXxF5IkeOSGusmCwL20ZEFGHsWSZ/givJxdoIkOwUAogkLeLnY1U\n\tJ","X-Gm-Gg":"ASbGncsYPc/6qk4hkmD+guHvIEADDc23mkcGSijp45VjYrnbSAds4sLyxtwXZZI5Cj5\n\tc2a2zRUcZc9c1i2kafrvnQQZ4cUR6nk58dpnPN62qlcPgpaXvPjvi3rIR+ugKJa5WJIo6evZntW\n\tcsV11PSN4e2RdzlVXygSjHMbYhRjWp4q655EiCvbf6LbpvWbpF/DgLQtYA9ZUinojUtuuWlp5Jr\n\tSwWYccm1RIRSEwCNO4WkOheId+5OJCSb0SXPc4vvIJJ8ravG6fywSOJXP69SR0bA1Y/aeskkmoK\n\ta42IgDHO25131Qs5ivxP8ZSxFN+sskLyCzpN4awadb8qGVN+DFMd4zLF","X-Google-Smtp-Source":"AGHT+IGOrl3dqe49a8XAVXJ36YmW5CQ/A6+9/m8nMqihPWx+BXzrJ5QUaE9yC8GX5Kkb13mUbh5idw==","X-Received":"by 2002:a0c:ff0a:0:b0:6f2:d45c:4a35 with SMTP id\n\t6a1803df08f44-6f2d45c4c2fmr157878716d6.37.1745337136460; \n\tTue, 22 Apr 2025 08:52:16 -0700 (PDT)","Message-ID":"","Subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","From":"Nicolas Dufresne ","To":"Jaslo Ziska , libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Apr 2025 11:52:15 -0400","In-Reply-To":"<20250422142903.14742-4-jaslo@ziska.de>","References":"<20250422142903.14742-1-jaslo@ziska.de>\n\t<20250422142903.14742-4-jaslo@ziska.de>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.0 (3.56.0-1.fc42) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33996,"web_url":"https://patchwork.libcamera.org/comment/33996/","msgid":"<174533767534.279461.6320105602201704215@ping.linuxembedded.co.uk>","date":"2025-04-22T16:01:15","subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Nicolas Dufresne (2025-04-22 16:52:15)\n> Le mardi 22 avril 2025 à 16:25 +0200, Jaslo Ziska a écrit :\n> > Now that read- and write-only controls are supported add the remaining\n> > controls.\n> > \n> > Signed-off-by: Jaslo Ziska \n> > ---\n> >  utils/codegen/gen-gst-controls.py | 16 +++++++++-------\n> >  1 file changed, 9 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> > index 4ca76049..664e4c41 100755\n> > --- a/utils/codegen/gen-gst-controls.py\n> > +++ b/utils/codegen/gen-gst-controls.py\n> > @@ -19,13 +19,15 @@ from controls import Control\n> >  \n> >  \n> >  exposed_controls = [\n> > -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > -    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> > -    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> > -    'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> > -    'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> > -    'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',\n> > -    'LensPosition', 'Gamma',\n> > +    'AeEnable', 'AeState', 'AeMeteringMode', 'AeConstraintMode',\n> > +    'AeExposureMode', 'ExposureValue', 'ExposureTime', 'AnalogueGain',\n> > +    'AnalogueGainMode', 'AeFlickerMode', 'AeFlickerPeriod',\n> > +    'AeFlickerDetected', 'Brightness', 'Contrast', 'Lux', 'AwbEnable',\n> > +    'AwbMode', 'AwbLocked', 'ColourGains', 'ColourTemperature', 'Saturation',\n> > +    'SensorBlackLevels', 'Sharpness', 'FocusFoM', 'ColourCorrectionMatrix',\n> > +    'ScalerCrop', 'DigitalGain', 'SensorTemperature', 'AfMode', 'AfRange',\n> > +    'AfSpeed', 'AfMetering', 'AfWindows', 'LensPosition', 'AfState',\n> > +    'AfPauseState', 'HdrMode', 'HdrChannel', 'Gamma',\n> \n> Can we ditch the formater and just make one vertical row ? That would\n> make the diff useful. If not, the list of added controls should be in\n> the description.\n\nYes please on this! This would be far more consumable as a straight\nlist!\n\nBonus points for alphabetical ordering ;-)\n\n> \n> Nicolas\n> \n> >  ]\n> >  \n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6CA9BE08B\n\tfor ;\n\tTue, 22 Apr 2025 16:01:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E904768ACA;\n\tTue, 22 Apr 2025 18:01:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB8BD617E6\n\tfor ;\n\tTue, 22 Apr 2025 18:01:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E19322AC;\n\tTue, 22 Apr 2025 18:01:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MH24vfqi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745337678;\n\tbh=QQ+D3B6EvfKCX1DJ1xfA8cohIgIGQVpBLj9cgRjllsc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=MH24vfqi+hlKult9DBTozbiFw6FSxDH4vrowg0fmFZ/+orplWsjdZzXjK2ebDsQud\n\troNlekygcelgtPy6vvVC1LTPUzaVKMDQer0yVwH9XPkjRBxooMGkIBXWPYGJeUIdNF\n\tyNAJH3pAsvCsMCDLEgIcdmxNnWVmbSz+k+MHbJL4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250422142903.14742-1-jaslo@ziska.de>\n\t<20250422142903.14742-4-jaslo@ziska.de>\n\t","Subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","From":"Kieran Bingham ","To":"Jaslo Ziska , Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 22 Apr 2025 17:01:15 +0100","Message-ID":"<174533767534.279461.6320105602201704215@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33997,"web_url":"https://patchwork.libcamera.org/comment/33997/","msgid":"<6425681e7b571ce16d1435bc7fde8d0d5c258180.camel@ndufresne.ca>","date":"2025-04-22T16:32:12","subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mardi 22 avril 2025 à 17:01 +0100, Kieran Bingham a écrit :\n> Quoting Nicolas Dufresne (2025-04-22 16:52:15)\n> > Le mardi 22 avril 2025 à 16:25 +0200, Jaslo Ziska a écrit :\n> > > Now that read- and write-only controls are supported add the remaining\n> > > controls.\n> > > \n> > > Signed-off-by: Jaslo Ziska \n> > > ---\n> > >  utils/codegen/gen-gst-controls.py | 16 +++++++++-------\n> > >  1 file changed, 9 insertions(+), 7 deletions(-)\n> > > \n> > > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> > > index 4ca76049..664e4c41 100755\n> > > --- a/utils/codegen/gen-gst-controls.py\n> > > +++ b/utils/codegen/gen-gst-controls.py\n> > > @@ -19,13 +19,15 @@ from controls import Control\n> > >  \n> > >  \n> > >  exposed_controls = [\n> > > -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > > -    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> > > -    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> > > -    'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> > > -    'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> > > -    'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',\n> > > -    'LensPosition', 'Gamma',\n> > > +    'AeEnable', 'AeState', 'AeMeteringMode', 'AeConstraintMode',\n> > > +    'AeExposureMode', 'ExposureValue', 'ExposureTime', 'AnalogueGain',\n> > > +    'AnalogueGainMode', 'AeFlickerMode', 'AeFlickerPeriod',\n> > > +    'AeFlickerDetected', 'Brightness', 'Contrast', 'Lux', 'AwbEnable',\n> > > +    'AwbMode', 'AwbLocked', 'ColourGains', 'ColourTemperature', 'Saturation',\n> > > +    'SensorBlackLevels', 'Sharpness', 'FocusFoM', 'ColourCorrectionMatrix',\n> > > +    'ScalerCrop', 'DigitalGain', 'SensorTemperature', 'AfMode', 'AfRange',\n> > > +    'AfSpeed', 'AfMetering', 'AfWindows', 'LensPosition', 'AfState',\n> > > +    'AfPauseState', 'HdrMode', 'HdrChannel', 'Gamma',\n> > \n> > Can we ditch the formater and just make one vertical row ? That would\n> > make the diff useful. If not, the list of added controls should be in\n> > the description.\n> \n> Yes please on this! This would be far more consumable as a straight\n> list!\n> \n> Bonus points for alphabetical ordering ;-)\n\nJust in case you aren't familiar, we usually make a reformatting patch,\ndocumented as \"No functional changes.\" The next patch adds the entry.\n\nNicolas\n\n> \n> > \n> > Nicolas\n> > \n> > >  ]\n> > >  \n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB5E0C327D\n\tfor ;\n\tTue, 22 Apr 2025 16:32:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 037FC68ACA;\n\tTue, 22 Apr 2025 18:32:17 +0200 (CEST)","from mail-qk1-x736.google.com (mail-qk1-x736.google.com\n\t[IPv6:2607:f8b0:4864:20::736])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EBFC617E3\n\tfor ;\n\tTue, 22 Apr 2025 18:32:15 +0200 (CEST)","by mail-qk1-x736.google.com with SMTP id\n\taf79cd13be357-7c5b8d13f73so558947285a.0\n\tfor ;\n\tTue, 22 Apr 2025 09:32:14 -0700 (PDT)","from ?IPv6:2606:6d00:15:9913::5ac? ([2606:6d00:15:9913::5ac])\n\tby smtp.gmail.com with ESMTPSA id\n\taf79cd13be357-7c925a6ee74sm576763185a.1.2025.04.22.09.32.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 09:32:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"L+gYcWY9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1745339534;\n\tx=1745944334; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jIbvHKp1gb22XVw+Ou399KlFAYIRDjW1wEFw3+5EA50=;\n\tb=L+gYcWY9+a2L+CHQLd+W2QE1sP+7eOfCAnmiAqUYNIDrTtflr4xwsINhMAbONNtloP\n\tX4paFj9lQ/XFgXoNVQiYWD04nXHAi1UnPZ49LW/RgNZIARR/Wpf7J8mNIPVFG0QcViko\n\tJoLGPIEJXFtSZQw+qcY6nNTq3CnP2Q+irG5fNzlfg0gt6s0z6y188Sll8B5hkJUnpzw3\n\taPlH3XUfklUw/ShWd1iH0Pxe2y6glyhNM2BY2NRQFN3/7JWXBc8l/1UyckTysbVUyhfw\n\tBMGGeLel2fwfcI21+YArdfeFN7jeOh0ctVvha6v+2CRpYEVNC4JFm71k+GwiDM4l6K2E\n\tGTNQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745339534; x=1745944334;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=jIbvHKp1gb22XVw+Ou399KlFAYIRDjW1wEFw3+5EA50=;\n\tb=Y2GSejJlMyGySKssRiaBtS0vqhoZnmZiEGEKOqYM3JRKosHsAFbJ/MU7mgGcE3yZjN\n\tyAjg0fHUUPeiEcKqHBvGX1Yu8JhVrI+L7xgDIygMvZ5hCou0kmV/RB+0cMdESVBO+5oS\n\t0y44JTMtS3fJOTqXX7JoO692UniLpP/LTwRsiBoX67NBd1vLlsod06HnAAlzyDjAFlli\n\t6zYaS+uagGTUAbsGRglnHQWtkHSQ2v3RuQ+hyhJWu8y6arb+RaWrO4iAWy42+Gbng00a\n\tI2NHRJVd8Ejaj3LSflBFgzwJnMaet4fdIHcM//Z+OKvFAWn+W0S8tuRWlJ5rIM37kgu0\n\tizDA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVpR0e1toB3nah3aS/Sv6mvfqIoV76TKF82aRhUzMjsaZMRYRQ8RlRZpXxwRtT0qbAbwLNGsOr+j1yx0O2n/pE=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yy+J5Gb55xHfeYPoqDGC5SVJOeC7/nbXHeM1aykURsM3IPRLJa6\n\tSUXB5RSTxPtfStNGEWGhRSCmafRBLyBb/3GvPX70f7kFFz1qNzTL13g/e+3mZQlm1udsPSpMx4C\n\tq","X-Gm-Gg":"ASbGncveuTjnOagoT/jxcz1qAugKbde/4CFLLw4127ekVf5XufkKevZcq0jIc1Rkd4G\n\tsxVnFT4HL7CGKGElBmMX9NnSxoduBXmAGdv9oC80It9ZJBUzgIUeVhJoLfjkKQs1tknZPYJRD+I\n\tIpLAlL6vFMMLPF8w3C/Jpz3oBqj+ncwYft7NCNT8A2b7r626FrY7e1aRcar2Pp6+GDtm5h/8SQ6\n\tALm1J7cR58siEdmUhcVoMvZmHl2mmmKCJ/ldSgQZk/02Fa7abuBw6Tvn28tOF+9oLarfY4+jIJg\n\tQusSOL88zwzYQkYs9K2+0mbuN5ZNaVJ0UrWWAN7e5i5FiQ==","X-Google-Smtp-Source":"AGHT+IFMRIPh6q76XH9qZ7Dv659B7jVtWlx7h3NTYCSeiFMoqsVDFVH1Lb25cuOfmqLLUFVwILT9Kg==","X-Received":"by 2002:a05:620a:258c:b0:7c7:a555:8788 with SMTP id\n\taf79cd13be357-7c927f5908fmr2034885385a.2.1745339533662; \n\tTue, 22 Apr 2025 09:32:13 -0700 (PDT)","Message-ID":"<6425681e7b571ce16d1435bc7fde8d0d5c258180.camel@ndufresne.ca>","Subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","From":"Nicolas Dufresne ","To":"Kieran Bingham , Jaslo Ziska\n\t, libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Apr 2025 12:32:12 -0400","In-Reply-To":"<174533767534.279461.6320105602201704215@ping.linuxembedded.co.uk>","References":"<20250422142903.14742-1-jaslo@ziska.de>\n\t<20250422142903.14742-4-jaslo@ziska.de>\n\t\n\t<174533767534.279461.6320105602201704215@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.0 (3.56.0-1.fc42) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34009,"web_url":"https://patchwork.libcamera.org/comment/34009/","msgid":"<877c3b1dfn.fsf@ziska.de>","date":"2025-04-23T08:37:16","subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","submitter":{"id":173,"url":"https://patchwork.libcamera.org/api/people/173/","name":"Jaslo Ziska","email":"jaslo@ziska.de"},"content":"Hi Nicolas and Kieran,\n\nNicolas Dufresne writes:\n> Le mardi 22 avril 2025 à 17:01 +0100, Kieran Bingham a écrit :\n>> Quoting Nicolas Dufresne (2025-04-22 16:52:15)\n>> > Le mardi 22 avril 2025 à 16:25 +0200, Jaslo Ziska a écrit :\n>> > > Now that read- and write-only controls are supported add \n>> > > the remaining\n>> > > controls.\n>> > >\n>> > > Signed-off-by: Jaslo Ziska \n>> > > ---\n>> > >  utils/codegen/gen-gst-controls.py | 16 +++++++++-------\n>> > >  1 file changed, 9 insertions(+), 7 deletions(-)\n>> > >\n>> > > diff --git a/utils/codegen/gen-gst-controls.py \n>> > > b/utils/codegen/gen-gst-controls.py\n>> > > index 4ca76049..664e4c41 100755\n>> > > --- a/utils/codegen/gen-gst-controls.py\n>> > > +++ b/utils/codegen/gen-gst-controls.py\n>> > > @@ -19,13 +19,15 @@ from controls import Control\n>> > >\n>> > >\n>> > >  exposed_controls = [\n>> > > -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', \n>> > > 'AeExposureMode',\n>> > > -    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n>> > > -    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n>> > > -    'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', \n>> > > 'ColourGains',\n>> > > -    'Saturation', 'Sharpness', 'ColourCorrectionMatrix', \n>> > > 'ScalerCrop',\n>> > > -    'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', \n>> > > 'AfMetering', 'AfWindows',\n>> > > -    'LensPosition', 'Gamma',\n>> > > +    'AeEnable', 'AeState', 'AeMeteringMode', \n>> > > 'AeConstraintMode',\n>> > > +    'AeExposureMode', 'ExposureValue', 'ExposureTime', \n>> > > 'AnalogueGain',\n>> > > +    'AnalogueGainMode', 'AeFlickerMode', \n>> > > 'AeFlickerPeriod',\n>> > > +    'AeFlickerDetected', 'Brightness', 'Contrast', 'Lux', \n>> > > 'AwbEnable',\n>> > > +    'AwbMode', 'AwbLocked', 'ColourGains', \n>> > > 'ColourTemperature', 'Saturation',\n>> > > +    'SensorBlackLevels', 'Sharpness', 'FocusFoM', \n>> > > 'ColourCorrectionMatrix',\n>> > > +    'ScalerCrop', 'DigitalGain', 'SensorTemperature', \n>> > > 'AfMode', 'AfRange',\n>> > > +    'AfSpeed', 'AfMetering', 'AfWindows', 'LensPosition', \n>> > > 'AfState',\n>> > > +    'AfPauseState', 'HdrMode', 'HdrChannel', 'Gamma',\n>> >\n>> > Can we ditch the formater and just make one vertical row ? \n>> > That would\n>> > make the diff useful. If not, the list of added controls \n>> > should be in\n>> > the description.\n>>\n>> Yes please on this! This would be far more consumable as a \n>> straight\n>> list!\n>>\n>> Bonus points for alphabetical ordering ;-)\n>\n> Just in case you aren't familiar, we usually make a reformatting \n> patch,\n> documented as \"No functional changes.\" The next patch adds the \n> entry.\n\nOk, I will change it.\n\nBest Regards\nJaslo\n\n>\n> Nicolas\n>\n>>\n>> >\n>> > Nicolas\n>> >\n>> > >  ]\n>> > >\n>> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE88ABE08B\n\tfor ;\n\tWed, 23 Apr 2025 08:37:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4261C68AC5;\n\tWed, 23 Apr 2025 10:37:19 +0200 (CEST)","from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de\n\t[81.169.146.167])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB746617E5\n\tfor ;\n\tWed, 23 Apr 2025 10:37:17 +0200 (CEST)","from archlinux by smtp.strato.de (RZmta 51.3.0 AUTH)\n\twith ESMTPSA id z34f8113N8bGTqW\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tWed, 23 Apr 2025 10:37:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ziska.de header.i=@ziska.de header.b=\"ECyAszIO\";\n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"T4RVuqer\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1745397436; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=cS/GIYKl1gtkeZ+UCdC1nwCNz+WaLMV2L1y8chIzT3zT62f7QdOrms+J1JERNg9PVF\n\thGvyGoLaeJlnu7GhZWhCnMZKakM7cvz8fDaOwH/kMwwT29lT68ZqZjGdI3GctW+Ct2bP\n\tI/5mv5OnfFIIdgxEGItEOodAt+yNyM7t4pIiiqieOQD2nCfoAL/+6z4b/mN+xUWu3NPZ\n\tYcvfd/4teYCm/d3Db/p+sRIMX0+ezsTrordLaYPN+zR817P3l0iZucAZnWcrMi6PWMhG\n\tHWPDA5MU0ABe7sVvWtfYG0MZn2B8sSelwKmf8peGRMBEI8zvoRrtHU9qgxijiHqYIR5r\n\tp3IQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; t=1745397436;\n\ts=strato-dkim-0002; d=strato.com;\n\th=Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=YTpPNzFRsflWpwdWKL/HY3Hrp0CQqsiHRvocye369TY=;\n\tb=XURv5PQlJd6YioGNX543xx4Jog0zDSaafRRIQJEKEoA1Mni8UD6Wn7vQMppIMW+ob8\n\t8orQb+kDnXMYyYtsvFDCH9K+bIQ30c2f6IEHeFeaRwAhbobU/YRFs8TZfC2PdnePXzG8\n\t4tNE/LCePq3xqgbEdHHH/0G8Is9s2oBpQ5P8B5JTsmwGAtuXiZJTO8fYtG1DWsY5RXce\n\trEiN6Chok0O9vlKkto4Baa/uEHCSAKl4vmM9oYOZCyaZsqTsYcjo66f0eSyr3xC1WnaE\n\tboHBfV9VZVzoeic4X4lx12JRCQgxZbNiKJ09rr281lWWNtXFwkYaz76XYFRUFwA7pR2B\n\t5dTw==","ARC-Authentication-Results":"i=1; strato.com;\n arc=none;\n dkim=none","X-RZG-CLASS-ID":"mo01","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; t=1745397436;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=YTpPNzFRsflWpwdWKL/HY3Hrp0CQqsiHRvocye369TY=;\n\tb=ECyAszIOSnzLqfNJc/cONgQhJLja36CZHh3sGQV+w+Vz4f3HXRjpYeNC4X+36O3os4\n\t7qBpT1d67/F1srj6tvmCKdHdEZgnQQi9bujTyRiDbfLIRhipS0tES913ySON9V1Ok352\n\tf/Yq9n3ZPJdPMyRZSZqZCze7t1n0O6aX2fMfRpYIue5VcbX2D1MfJ1lD1TIaad7zJUw+\n\tPkS2805kIB09z78bUq6w52VBf8V7xWyZ3qEFPDZG+9cJhKFCC8r/gdgiyx47Zxp3xp5j\n\tm9gXfVS8cd2shC8bqM8BzqBtqhTExB903Buazc7LaUGs36XRA816wRqHi7wlSwgh8CeJ\n\t5WjQ==","v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1745397436;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=YTpPNzFRsflWpwdWKL/HY3Hrp0CQqsiHRvocye369TY=;\n\tb=T4RVuqer7aOi3Los//jP9oiVw1EgvuGW0Bfgin7wcWDJg/xUPq7ig/6G/BvZ8QaRyy\n\tKXL/oUFpRDx1kmGHnTBQ=="],"X-RZG-AUTH":"\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cC1Yq6XPJaRR/P73in+Ce40I+pppMPSbg4/XGF\"","From":"Jaslo Ziska ","To":"Nicolas Dufresne ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] gstreamer: Add remaining controls","In-Reply-To":"<6425681e7b571ce16d1435bc7fde8d0d5c258180.camel@ndufresne.ca>\n\t(Nicolas Dufresne's message of \"Tue, 22 Apr 2025 12:32:12 -0400\")","References":"<20250422142903.14742-1-jaslo@ziska.de>\n\t<20250422142903.14742-4-jaslo@ziska.de>\n\t\n\t<174533767534.279461.6320105602201704215@ping.linuxembedded.co.uk>\n\t<6425681e7b571ce16d1435bc7fde8d0d5c258180.camel@ndufresne.ca>","User-Agent":"mu4e 1.12.9; emacs 30.1","Date":"Wed, 23 Apr 2025 10:37:16 +0200","Message-ID":"<877c3b1dfn.fsf@ziska.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]