[{"id":34020,"web_url":"https://patchwork.libcamera.org/comment/34020/","msgid":"<174541693413.2882969.10631231110761168200@ping.linuxembedded.co.uk>","date":"2025-04-23T14:02:14","subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-22 13:44:01)\n> Arrays of arrays, even arrays of strings, are not supported by\n> the current `ControlValue` mechanism, so disable them for now\n> to trigger comptime errors if attempts are made to use them.\n> \n\nThis sounds safer than discovering the fault at runtime!\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/controls.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 326452540..427517a02 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -121,7 +121,7 @@ struct control_type {\n> };\n> \n> template\n> -struct control_type> : public control_type> {\n> +struct control_type, std::enable_if_t>::size == 0>> : public control_type> {\n> static constexpr std::size_t size = N;\n> };\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8E88C327D\n\tfor ;\n\tWed, 23 Apr 2025 14:02:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AB9968ACD;\n\tWed, 23 Apr 2025 16:02:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 217E868AC6\n\tfor ;\n\tWed, 23 Apr 2025 16:02:17 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8222D1AE2;\n\tWed, 23 Apr 2025 16:02:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XUtYeD4S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745416935;\n\tbh=xvJZtlKxym5G/1hQ4wZklpPlcaTtI2IyPQ0Y6gNOmG4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=XUtYeD4SlAwE/yletgXvO0dzQ82IcJEFRDMCivh7LLGVjnJLx2FBCqykhhEra6vBy\n\tqWx+FeHuHOq9CPMqXmfopaKdc3j3uZxatrifazt4UtAJJvChOcLA7AguuxVLtDusxW\n\tH+PLuOce9uPmX3GvHou2fKYXvCS9MdO5rUEd9atU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>","References":"<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 23 Apr 2025 15:02:14 +0100","Message-ID":"<174541693413.2882969.10631231110761168200@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34021,"web_url":"https://patchwork.libcamera.org/comment/34021/","msgid":"<20250423192916.GC32759@pendragon.ideasonboard.com>","date":"2025-04-23T19:29:16","subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nThe subject line should tell what the patch does.\n\nOn Wed, Apr 23, 2025 at 03:02:14PM +0100, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2025-04-22 13:44:01)\n> > Arrays of arrays, even arrays of strings, are not supported by\n> > the current `ControlValue` mechanism, so disable them for now\n> > to trigger comptime errors if attempts are made to use them.\n\ns/comptime/compile-time/\n\n> This sounds safer than discovering the fault at runtime!\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > include/libcamera/controls.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> > index 326452540..427517a02 100644\n> > --- a/include/libcamera/controls.h\n> > +++ b/include/libcamera/controls.h\n> > @@ -121,7 +121,7 @@ struct control_type {\n> > };\n> > \n> > template\n> > -struct control_type> : public control_type> {\n> > +struct control_type, std::enable_if_t>::size == 0>> : public control_type> {\n\nMaybe with a bit of line wrap,\n\nReviewed-by: Laurent Pinchart \n\n> > static constexpr std::size_t size = N;\n> > };\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30C81C327D\n\tfor ;\n\tWed, 23 Apr 2025 19:29:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 294DA68ACD;\n\tWed, 23 Apr 2025 21:29:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2721B68AC6\n\tfor ;\n\tWed, 23 Apr 2025 21:29:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 399D4198D;\n\tWed, 23 Apr 2025 21:29:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tcxFFftU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745436557;\n\tbh=wHXdRS65vosZJ1deoYNorXbnSCVnvHrrNO854AN5L3A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tcxFFftUZibCuz8MlqFxEni2O3HJmaghnHFOYghz6UvZwZjkCfPTz3wzqpMG1PnYO\n\tfZehfvmWi7IW5OZQ1b/kY08u0zo3Vp6YPV06s7iL839DnnooN5jG+wU0rxvSAg21s8\n\t9TzwLDlwkSFS1cmPpBN2tX9fp733muPFlV6y9r9Q=","Date":"Wed, 23 Apr 2025 22:29:16 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","Message-ID":"<20250423192916.GC32759@pendragon.ideasonboard.com>","References":"<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>\n\t<174541693413.2882969.10631231110761168200@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<174541693413.2882969.10631231110761168200@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34034,"web_url":"https://patchwork.libcamera.org/comment/34034/","msgid":"<2891aec9-95c9-478f-ba55-b20a234fc5c5@ideasonboard.com>","date":"2025-04-25T08:21:44","subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. 04. 23. 21:29 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> The subject line should tell what the patch does.\n\n\"Disallow arrays of array\" ?\n\n\n> \n> On Wed, Apr 23, 2025 at 03:02:14PM +0100, Kieran Bingham wrote:\n>> Quoting Barnabás Pőcze (2025-04-22 13:44:01)\n>>> Arrays of arrays, even arrays of strings, are not supported by\n>>> the current `ControlValue` mechanism, so disable them for now\n>>> to trigger comptime errors if attempts are made to use them.\n> \n> s/comptime/compile-time/\n> \n>> This sounds safer than discovering the fault at runtime!\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> Signed-off-by: Barnabás Pőcze \n>>> ---\n>>> include/libcamera/controls.h | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n>>> index 326452540..427517a02 100644\n>>> --- a/include/libcamera/controls.h\n>>> +++ b/include/libcamera/controls.h\n>>> @@ -121,7 +121,7 @@ struct control_type {\n>>> };\n>>> \n>>> template\n>>> -struct control_type> : public control_type> {\n>>> +struct control_type, std::enable_if_t>::size == 0>> : public control_type> {\n> \n> Maybe with a bit of line wrap,\n\nEverything I tried looks bad, do you have something specific in mind?\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n>>> static constexpr std::size_t size = N;\n>>> };\n>>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06DA5C327D\n\tfor ;\n\tFri, 25 Apr 2025 08:21:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 140D868ACD;\n\tFri, 25 Apr 2025 10:21:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F7FD60526\n\tfor ;\n\tFri, 25 Apr 2025 10:21:48 +0200 (CEST)","from [192.168.33.12] (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39AB0982;\n\tFri, 25 Apr 2025 10:21:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l4VFfSVp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745569305;\n\tbh=dtsUlNNsWky2l30QKHi/oi2E2nObhTRlu+GZMv04DRM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=l4VFfSVprWjuXlVRRFukhPJJb5SjwObrFfQcVEK5kfzWsIPB8VDhWfi5g4ljjHxDX\n\tmxwdOtWSFmaozHQIkkYenh1bYjYoX2Pk7CIjd0fay127JKqeW1qC2Z1Lk4Vsb0n8av\n\tQCfF0Ln8eJPcai1IeeYD/ROhGJFG6C5BwAgAdkSU=","Message-ID":"<2891aec9-95c9-478f-ba55-b20a234fc5c5@ideasonboard.com>","Date":"Fri, 25 Apr 2025 10:21:44 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","To":"Laurent Pinchart ,\n\tKieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>\n\t<174541693413.2882969.10631231110761168200@ping.linuxembedded.co.uk>\n\t<20250423192916.GC32759@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250423192916.GC32759@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34052,"web_url":"https://patchwork.libcamera.org/comment/34052/","msgid":"<20250425152305.GB26250@pendragon.ideasonboard.com>","date":"2025-04-25T15:23:05","subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 25, 2025 at 10:21:44AM +0200, Barnabás Pőcze wrote:\n> 2025. 04. 23. 21:29 keltezéssel, Laurent Pinchart írta:\n> > Hi Barnabás,\n> > \n> > Thank you for the patch.\n> > \n> > The subject line should tell what the patch does.\n> \n> \"Disallow arrays of array\" ?\n\nAck.\n\n> > On Wed, Apr 23, 2025 at 03:02:14PM +0100, Kieran Bingham wrote:\n> >> Quoting Barnabás Pőcze (2025-04-22 13:44:01)\n> >>> Arrays of arrays, even arrays of strings, are not supported by\n> >>> the current `ControlValue` mechanism, so disable them for now\n> >>> to trigger comptime errors if attempts are made to use them.\n> > \n> > s/comptime/compile-time/\n> > \n> >> This sounds safer than discovering the fault at runtime!\n> >>\n> >> Reviewed-by: Kieran Bingham \n> >>\n> >>> Signed-off-by: Barnabás Pőcze \n> >>> ---\n> >>> include/libcamera/controls.h | 2 +-\n> >>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> >>> index 326452540..427517a02 100644\n> >>> --- a/include/libcamera/controls.h\n> >>> +++ b/include/libcamera/controls.h\n> >>> @@ -121,7 +121,7 @@ struct control_type {\n> >>> };\n> >>> \n> >>> template\n> >>> -struct control_type> : public control_type> {\n> >>> +struct control_type, std::enable_if_t>::size == 0>> : public control_type> {\n> > \n> > Maybe with a bit of line wrap,\n> \n> Everything I tried looks bad, do you have something specific in mind?\n\nMaybe\n\nstruct control_type, std::enable_if_t>::size == 0>>\n\t: public control_type> {\n\n? It's not a big deal.\n\n> > Reviewed-by: Laurent Pinchart \n> > \n> >>> static constexpr std::size_t size = N;\n> >>> };\n> >>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4368C327D\n\tfor ;\n\tFri, 25 Apr 2025 15:23:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4D2568ACD;\n\tFri, 25 Apr 2025 17:23:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6972617E4\n\tfor ;\n\tFri, 25 Apr 2025 17:23:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E7D2982;\n\tFri, 25 Apr 2025 17:23:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ADeja99E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745594586;\n\tbh=tsVzkgU69JB0j5QCx8U1bpkBJ23/aCE070d5eTzK4KY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ADeja99E0IfWzuKV8M0MZ8KOzlsUhnW3ZQyZ5v0lRb2zycOSobozNeDSPTdIoziNy\n\tpp300FUl7wzNgVZqc3sqIXCWbl++uYVQkfWe37BJnxt3ZcdO1scPEfy60wZTD5/Wf9\n\tCsEBs70E0nMpi33ghNYLESQHVwFBZKYMWVOzmx+c=","Date":"Fri, 25 Apr 2025 18:23:05 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: controls: Arrays of arrays are not\n\tsupported","Message-ID":"<20250425152305.GB26250@pendragon.ideasonboard.com>","References":"<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>\n\t<174541693413.2882969.10631231110761168200@ping.linuxembedded.co.uk>\n\t<20250423192916.GC32759@pendragon.ideasonboard.com>\n\t<2891aec9-95c9-478f-ba55-b20a234fc5c5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<2891aec9-95c9-478f-ba55-b20a234fc5c5@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]