[{"id":33979,"web_url":"https://patchwork.libcamera.org/comment/33979/","msgid":"<20250421220146.GT17813@pendragon.ideasonboard.com>","date":"2025-04-21T22:01:46","subject":"Re: [PATCH v1] libcamera: ipa_module: Avoid unnecessary copy when\n\tgetting signature","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Apr 21, 2025 at 06:00:11PM +0200, Barnabás Pőcze wrote:\n> The `signature()` getter can just return a reference to the private vector\n> member variable, and let the caller make a copy if needed. Since the\n> return type is const qualified, this was likely the original intetion.\n\ns/intetion/intention/\n\nI wonder if there's a compiler warning flag to report const-qualified\nreturn values.\n\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/ipa_module.h | 2 +-\n> src/libcamera/ipa_module.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n> index 7c49d3f34..15f19492c 100644\n> --- a/include/libcamera/internal/ipa_module.h\n> +++ b/include/libcamera/internal/ipa_module.h\n> @@ -29,7 +29,7 @@ public:\n> \tbool isValid() const;\n> \n> \tconst struct IPAModuleInfo &info() const;\n> -\tconst std::vector signature() const;\n> +\tconst std::vector &signature() const;\n> \tconst std::string &path() const;\n> \n> \tbool load();\n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 9ca74be6e..e6ea61e44 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -373,7 +373,7 @@ const struct IPAModuleInfo &IPAModule::info() const\n> *\n> * \\return The IPA module signature\n> */\n> -const std::vector IPAModule::signature() const\n> +const std::vector &IPAModule::signature() const\n> {\n> \treturn signature_;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C1EEBE08B\n\tfor ;\n\tMon, 21 Apr 2025 22:01:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D3CC68AC7;\n\tTue, 22 Apr 2025 00:01:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1713E68AB5\n\tfor ;\n\tTue, 22 Apr 2025 00:01:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 015B66D6;\n\tMon, 21 Apr 2025 23:59:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OkdbyVT8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745272782;\n\tbh=d6Bucycy2Rd5UXMx0N2Efn0pMsEdfsE5NoSKOiQIrvw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OkdbyVT8bAIun4E3m4XV2bGGkjUj2+GXt0TPSttV/6u5r4k5GZ2Kvduz3RwZiUeVz\n\tCeuYyqu1j5dQBu/m0a72Z9ENPcQzlcKiIwHTAQs17uPdWz+aQ5VMzUKpFHr1xagH8L\n\tBmDj4K2UAbAhLRgEc9muw4lqeqE6XAChM8097VqM=","Date":"Tue, 22 Apr 2025 01:01:46 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: ipa_module: Avoid unnecessary copy when\n\tgetting signature","Message-ID":"<20250421220146.GT17813@pendragon.ideasonboard.com>","References":"<20250421160011.178090-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250421160011.178090-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33988,"web_url":"https://patchwork.libcamera.org/comment/33988/","msgid":"","date":"2025-04-22T10:37:55","subject":"Re: [PATCH v1] libcamera: ipa_module: Avoid unnecessary copy when\n\tgetting signature","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Mon, Apr 21, 2025 at 06:00:11PM +0200, Barnabás Pőcze wrote:\n> The `signature()` getter can just return a reference to the private vector\n> member variable, and let the caller make a copy if needed. Since the\n> return type is const qualified, this was likely the original intetion.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/ipa_module.h | 2 +-\n> src/libcamera/ipa_module.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n> index 7c49d3f34..15f19492c 100644\n> --- a/include/libcamera/internal/ipa_module.h\n> +++ b/include/libcamera/internal/ipa_module.h\n> @@ -29,7 +29,7 @@ public:\n> \tbool isValid() const;\n> \n> \tconst struct IPAModuleInfo &info() const;\n> -\tconst std::vector signature() const;\n> +\tconst std::vector &signature() const;\n> \tconst std::string &path() const;\n> \n> \tbool load();\n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 9ca74be6e..e6ea61e44 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -373,7 +373,7 @@ const struct IPAModuleInfo &IPAModule::info() const\n> *\n> * \\return The IPA module signature\n> */\n> -const std::vector IPAModule::signature() const\n> +const std::vector &IPAModule::signature() const\n> {\n> \treturn signature_;\n> }\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E19D9BE08B\n\tfor ;\n\tTue, 22 Apr 2025 10:38:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19D6F68ACA;\n\tTue, 22 Apr 2025 12:38:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35E95617E3\n\tfor ;\n\tTue, 22 Apr 2025 12:38:04 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:bedf:5f9a:c968:1149])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9BAF250;\n\tTue, 22 Apr 2025 12:35:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BrMCOWsf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745318156;\n\tbh=Kafa1/+VwANWqdiVpnnOedD8/FEbtXjWKIJz4reES8o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BrMCOWsfGd4Lneyedk8SSny7R9v2VvOhXFS/qzJzSNM4t4yGMgR67FFvE6xpPQO2O\n\t97cf/8cYh6zkyETvv7MTAHYm4AWe0KSgMXYvVlCf+kbW69l1Age2O4rRPTo4uKLv9d\n\tjI9heyNEk28NNaBB2HPvLYGLUWVi22afWSSkL+X8=","Date":"Tue, 22 Apr 2025 19:37:55 +0900","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: ipa_module: Avoid unnecessary copy when\n\tgetting signature","Message-ID":"","References":"<20250421160011.178090-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250421160011.178090-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]