[{"id":34064,"web_url":"https://patchwork.libcamera.org/comment/34064/","msgid":"<174582526956.1397492.4276647880440326331@ping.linuxembedded.co.uk>","date":"2025-04-28T07:27:49","subject":"Re: [PATCH v2 5/5] libcamera: controls: Add rvalue overload for\n\t`ControlList::set()`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-21 16:35:56)\n> Add an overload of `ControlList::set()` that takes the `ControlValue` argument\n> as an rvalue reference, therefore enabling the use of move assignment.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/controls.h | 1 +\n> src/libcamera/controls.cpp | 12 ++++++++++++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 62ee5ebd6..611252f20 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -516,6 +516,7 @@ public:\n> \n> const ControlValue &get(unsigned int id) const;\n> void set(unsigned int id, const ControlValue &value);\n> + void set(unsigned int id, ControlValue &&value);\n> \n> const ControlInfoMap *infoMap() const { return infoMap_; }\n> const ControlIdMap *idMap() const { return idmap_; }\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index ae54f8c77..c22c6bdb9 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -1189,6 +1189,18 @@ void ControlList::set(unsigned int id, const ControlValue &value)\n> *val = value;\n> }\n> \n> +/**\n> + * \\copydoc ControlList::set(unsigned int, const ControlValue &)\n> + */\n> +void ControlList::set(unsigned int id, ControlValue &&value)\n> +{\n> + ControlValue *val = find(id);\n> + if (!val)\n> + return;\n\nShould we be reporting an error or log message here?\nThough ControlList::set(unsigned int, const ControlValue &) doesn't -\n\nAha, never mind, I see it would be reported accordingly in ::find().\n\nReviewed-by: Kieran Bingham \n\n> +\n> + *val = std::move(value);\n> +}\n> +\n> /**\n> * \\fn ControlList::infoMap()\n> * \\brief Retrieve the ControlInfoMap used to construct the ControlList\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AF74BE08B\n\tfor ;\n\tMon, 28 Apr 2025 07:27:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EBCD68ACD;\n\tMon, 28 Apr 2025 09:27:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74011617E0\n\tfor ;\n\tMon, 28 Apr 2025 09:27:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7285A475;\n\tMon, 28 Apr 2025 09:27:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RY0LNsJX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745825267;\n\tbh=+MSGvT+99h9QfDOPUoCxJTJnPEtALwq0Jbk8G8ln+IU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=RY0LNsJXirFCaDoJwKL2l+i9ASzDdJnZbDHzq11IwVpUyot0e+Vd7/VSiA/ODsMXA\n\tDH41f+0ZXvQjOMSoIp8c5aQr7J3f7hWJDzuT3f9asKileyvwegRR++Tg/H3+3vmZN1\n\tyHem4fI0up3sJj6kbx6vQwvLK0qvOIG7m0/Cf7Xg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250421153556.171192-6-barnabas.pocze@ideasonboard.com>","References":"<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>\n\t<20250421153556.171192-6-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 5/5] libcamera: controls: Add rvalue overload for\n\t`ControlList::set()`","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 28 Apr 2025 08:27:49 +0100","Message-ID":"<174582526956.1397492.4276647880440326331@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36981,"web_url":"https://patchwork.libcamera.org/comment/36981/","msgid":"","date":"2025-11-21T11:50:34","subject":"Re: [PATCH v2 5/5] libcamera: controls: Add rvalue overload for\n\t`ControlList::set()`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Apr 21, 2025 at 05:35:56PM +0200, Barnabás Pőcze wrote:\n> Add an overload of `ControlList::set()` that takes the `ControlValue` argument\n> as an rvalue reference, therefore enabling the use of move assignment.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\nI guess this series will have to be rebased, but in my opinion it's\nsomething which should be merged!\n\nThanks\n j\n\n> ---\n> include/libcamera/controls.h | 1 +\n> src/libcamera/controls.cpp | 12 ++++++++++++\n> 2 files changed, 13 insertions(+)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 62ee5ebd6..611252f20 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -516,6 +516,7 @@ public:\n>\n> \tconst ControlValue &get(unsigned int id) const;\n> \tvoid set(unsigned int id, const ControlValue &value);\n> +\tvoid set(unsigned int id, ControlValue &&value);\n>\n> \tconst ControlInfoMap *infoMap() const { return infoMap_; }\n> \tconst ControlIdMap *idMap() const { return idmap_; }\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index ae54f8c77..c22c6bdb9 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -1189,6 +1189,18 @@ void ControlList::set(unsigned int id, const ControlValue &value)\n> \t*val = value;\n> }\n>\n> +/**\n> + * \\copydoc ControlList::set(unsigned int, const ControlValue &)\n> + */\n> +void ControlList::set(unsigned int id, ControlValue &&value)\n> +{\n> +\tControlValue *val = find(id);\n> +\tif (!val)\n> +\t\treturn;\n> +\n> +\t*val = std::move(value);\n> +}\n> +\n> /**\n> * \\fn ControlList::infoMap()\n> * \\brief Retrieve the ControlInfoMap used to construct the ControlList\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7DFEC3333\n\tfor ;\n\tFri, 21 Nov 2025 11:50:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B17760805;\n\tFri, 21 Nov 2025 12:50:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACB7660805\n\tfor ;\n\tFri, 21 Nov 2025 12:50:38 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E5EF66B;\n\tFri, 21 Nov 2025 12:48:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oUmxIz7l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763725712;\n\tbh=2JhlzcFlVlTySawZ9nfhaw1s0D/7Pg8/hhZBbH7mxBY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oUmxIz7lVudyZ58G8Cu3BueIb0++VHrLyGMBRktm/DaOKBI0PUUmsCMmg5ejKHhRH\n\tr4gs2cCO8OGB18dIfNb7sVWWCqsmEjn3pC14NTnWqkx1VMzJdt5fMdiqPYwgSDQKGt\n\tdxErbAwUsmnV35WaU2smpvWrPmmJVMRcnYcVMI/g=","Date":"Fri, 21 Nov 2025 12:50:34 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 5/5] libcamera: controls: Add rvalue overload for\n\t`ControlList::set()`","Message-ID":"","References":"<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>\n\t<20250421153556.171192-6-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250421153556.171192-6-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]