[{"id":34063,"web_url":"https://patchwork.libcamera.org/comment/34063/","msgid":"<174582480542.1397492.354995405449146477@ping.linuxembedded.co.uk>","date":"2025-04-28T07:20:05","subject":"Re: [PATCH v2 2/5] libcamera: controls: Replace `numElements_` bit\n\tfield","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-21 16:35:53)\n> Instead of using a 32-bit wide bit field of `std::size_t`, simply\n> use a `uint32_t` to store the number of elements. This makes it\n> possible to construct references, and use e.g. `std::swap()`.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/controls.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 1dc6ccffa..3f3580036 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -236,7 +236,7 @@ public:\n> private:\n> ControlType type_ : 8;\n> bool isArray_;\n> - std::size_t numElements_ : 32;\n> + uint32_t numElements_;\n\nIt even looks ABI compatible.\n\nReviewed-by: Kieran Bingham \n\n> union {\n> uint64_t internal;\n> void *external;\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F0EEC327D\n\tfor ;\n\tMon, 28 Apr 2025 07:20:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35AB868ACD;\n\tMon, 28 Apr 2025 09:20:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3B8D617E0\n\tfor ;\n\tMon, 28 Apr 2025 09:20:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5A127E6;\n\tMon, 28 Apr 2025 09:20:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TtCtwZOU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745824803;\n\tbh=2d3X5cj9uAu4ZU0qzDvzLxVTP6PUHN6dbihzuWLpspE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=TtCtwZOUYc+uj9C9wlp7UsYdtdg+w7MPIbxOuKR8sd5f5ZoS9AinTIDhNhvyD+lHb\n\to/65tx21E6mWGOhC89nQ6gh6STNGCw7MsbOEWmfJBU6ESLiWQp5vUU/ywAKyEkTn7g\n\tlsGa8iuC3kLfdj0VgXqz6TpePhwyO0zaSLhYij3g=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250421153556.171192-3-barnabas.pocze@ideasonboard.com>","References":"<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>\n\t<20250421153556.171192-3-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 2/5] libcamera: controls: Replace `numElements_` bit\n\tfield","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 28 Apr 2025 08:20:05 +0100","Message-ID":"<174582480542.1397492.354995405449146477@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36979,"web_url":"https://patchwork.libcamera.org/comment/36979/","msgid":"","date":"2025-11-21T11:41:23","subject":"Re: [PATCH v2 2/5] libcamera: controls: Replace `numElements_` bit\n\tfield","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Apr 21, 2025 at 05:35:53PM +0200, Barnabás Pőcze wrote:\n> Instead of using a 32-bit wide bit field of `std::size_t`, simply\n> use a `uint32_t` to store the number of elements. This makes it\n> possible to construct references, and use e.g. `std::swap()`.\n>\n> Signed-off-by: Barnabás Pőcze \n\nThis really fell into cracks, sorry about this.\n\nThis patch's trivial\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/controls.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 1dc6ccffa..3f3580036 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -236,7 +236,7 @@ public:\n> private:\n> \tControlType type_ : 8;\n> \tbool isArray_;\n> -\tstd::size_t numElements_ : 32;\n> +\tuint32_t numElements_;\n> \tunion {\n> \t\tuint64_t internal;\n> \t\tvoid *external;\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C2A2C3333\n\tfor ;\n\tFri, 21 Nov 2025 11:41:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F96E609D8;\n\tFri, 21 Nov 2025 12:41:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5236760805\n\tfor ;\n\tFri, 21 Nov 2025 12:41:26 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B29766B;\n\tFri, 21 Nov 2025 12:39:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g805C2Lg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763725160;\n\tbh=wpqHFksWiJYej5SfypWvwxSRZe8VHIE7VuwSEMIvVXw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g805C2Lgz1FXFdhbNG6PdfS8xDUC7N3lShhtP6Hs8Rfa0D7Q4fRa5Xay1P2QiUan9\n\t+A3Hfmxq/17DE2ahW948uCDd0A0scgmU5XIzyXcpiGNfW2qLLFIHUohXrVOnyPVk3O\n\tMITGCgRq87ZE+nRGMulBwVA94Cf7bGo5pwWezQUI=","Date":"Fri, 21 Nov 2025 12:41:23 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 2/5] libcamera: controls: Replace `numElements_` bit\n\tfield","Message-ID":"","References":"<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>\n\t<20250421153556.171192-3-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250421153556.171192-3-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]