[{"id":33972,"web_url":"https://patchwork.libcamera.org/comment/33972/","msgid":"<174522840800.1402823.3668486024011073366@ping.linuxembedded.co.uk>","date":"2025-04-21T09:40:08","subject":"Re: [PATCH] pipeline: rkisp1: Fix vblank delay","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2025-04-21 07:49:59)\n> The vblank delay for delayed controls was incorrectly hardcoded to 1.\n> Get it from the camera sensor properties instead.\n> \n> Fixes: f72c76eb6e06 (\"rkisp1: Honor the FrameDurationLimits control\")\n> Signed-off-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 52633fe3cb85..194dfce7ee5d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> std::unordered_map params = {\n> { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> - { V4L2_CID_VBLANK, { 1, false } },\n> + { V4L2_CID_VBLANK, { delays.vblankDelay, false } },\n> };\n> \n> data->delayedCtrls_ =\n> -- \n> 2.47.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E058BE08B\n\tfor ;\n\tMon, 21 Apr 2025 09:40:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57ACC68AC2;\n\tMon, 21 Apr 2025 11:40:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D651568ABB\n\tfor ;\n\tMon, 21 Apr 2025 11:40:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 236CD6D6;\n\tMon, 21 Apr 2025 11:38:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OykIbM3k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745228285;\n\tbh=ID5H7sc/8rxHFYgYADWhoWW5Yh+fZEx8mHsx2bgAwIc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OykIbM3kinsr+LU/2R2NzUmGKf2Mw5uzB/scBkPojYs7D2HLKnuZHruYNL0CiEV5X\n\tvLlHwCI9MyBmNw6zigldb4RZqv6m75kojZeRBlinhZ1aISFxDGARH7CJF9sKdQ8uCi\n\tTHN4jogn5aUf/aBnHOqOdl5VBptn/ZA7pIEX1O7w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250421064959.1239069-1-paul.elder@ideasonboard.com>","References":"<20250421064959.1239069-1-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH] pipeline: rkisp1: Fix vblank delay","From":"Kieran Bingham ","Cc":"Paul Elder ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 21 Apr 2025 10:40:08 +0100","Message-ID":"<174522840800.1402823.3668486024011073366@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33973,"web_url":"https://patchwork.libcamera.org/comment/33973/","msgid":"<20250421100920.GP29968@pendragon.ideasonboard.com>","date":"2025-04-21T10:09:20","subject":"Re: [PATCH] pipeline: rkisp1: Fix vblank delay","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Apr 21, 2025 at 03:49:59PM +0900, Paul Elder wrote:\n> The vblank delay for delayed controls was incorrectly hardcoded to 1.\n> Get it from the camera sensor properties instead.\n> \n> Fixes: f72c76eb6e06 (\"rkisp1: Honor the FrameDurationLimits control\")\n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 52633fe3cb85..194dfce7ee5d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> \tstd::unordered_map params = {\n> \t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> \t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> -\t\t{ V4L2_CID_VBLANK, { 1, false } },\n> +\t\t{ V4L2_CID_VBLANK, { delays.vblankDelay, false } },\n> \t};\n> \n> \tdata->delayedCtrls_ =","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6D23C327D\n\tfor ;\n\tMon, 21 Apr 2025 10:09:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C897968AC7;\n\tMon, 21 Apr 2025 12:09:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A8D768ABA\n\tfor ;\n\tMon, 21 Apr 2025 12:09:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C37FC56D;\n\tMon, 21 Apr 2025 12:07:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s6dKISHs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745230036;\n\tbh=dtI6TQ/ugckG0NChDQOpY3xMc80p2jj1LNePi5swLJY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=s6dKISHsGaEIMuO26R8Z1ZseQj4qVJWruFVdfyZU5tB60AXZ0GSvlUFjkP0/tjHvg\n\tRaerQapmB60PW7LTSjJnvGjdWBt1y49xRCplBLlrMQes/UVN02jgXqVY7ooHmfz0PW\n\tb7A8taOp2uZXF0ZJvK3KD4wisvtX8qMsTrQDGKCQ=","Date":"Mon, 21 Apr 2025 13:09:20 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] pipeline: rkisp1: Fix vblank delay","Message-ID":"<20250421100920.GP29968@pendragon.ideasonboard.com>","References":"<20250421064959.1239069-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250421064959.1239069-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]