[{"id":33970,"web_url":"https://patchwork.libcamera.org/comment/33970/","msgid":"<174499488844.3064300.12600331477730719781@ping.linuxembedded.co.uk>","date":"2025-04-18T16:48:08","subject":"Re: [PATCH v1] libcamera: pipeline: imx8-isi: Remove unused variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-18 17:24:05)\n> The `mbusCodes` variable in `ISICameraConfiguration::validateRaw()`\n> has been unused since\n> \n> 87fed432533a (\"libcamera: imx8-isi: Break out RAW format selection\"),\n> \n> so remove it.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index 4e66b3368..ecda426a6 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -366,7 +366,6 @@ ISICameraConfiguration::validateRaw(std::set &availableStreams,\n> * Make sure the requested RAW format is supported by the\n> * pipeline, otherwise adjust it.\n> */\n> - std::vector mbusCodes = data_->sensor_->mbusCodes();\n> StreamConfiguration &rawConfig = config_[0];\n> PixelFormat rawFormat = rawConfig.pixelFormat;\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6C65C327D\n\tfor ;\n\tFri, 18 Apr 2025 16:48:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1F7968AC6;\n\tFri, 18 Apr 2025 18:48:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 867D2617E7\n\tfor ;\n\tFri, 18 Apr 2025 18:48:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5C483A4;\n\tFri, 18 Apr 2025 18:46:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"POWLMB6M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744994767;\n\tbh=p1i4R7J3C1WvzX088saoJSrsYjeQ6IhWwhwTZkVUoWo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=POWLMB6Mbxdq1+rAY/zPIGtgogkVi8q8NeGtQ7he20MU4LcULPH+VPEFeE5WqpCEj\n\tSf01c+UZsEO6ZRlrum9NfTBBB36GZiYB6/VBMJl0lTwetEFioeYvYyGzGe3POAwUUz\n\tjdBXX6WIK1NHg3NKFdEtMd6Q/EcarOc3vCptye3s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250418162405.1339989-1-barnabas.pocze@ideasonboard.com>","References":"<20250418162405.1339989-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: pipeline: imx8-isi: Remove unused variable","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Apr 2025 17:48:08 +0100","Message-ID":"<174499488844.3064300.12600331477730719781@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33976,"web_url":"https://patchwork.libcamera.org/comment/33976/","msgid":"<20250421141238.GN29483@pendragon.ideasonboard.com>","date":"2025-04-21T14:12:38","subject":"Re: [PATCH v1] libcamera: pipeline: imx8-isi: Remove unused variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 18, 2025 at 05:48:08PM +0100, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2025-04-18 17:24:05)\n> > The `mbusCodes` variable in `ISICameraConfiguration::validateRaw()`\n> > has been unused since\n> > \n> > 87fed432533a (\"libcamera: imx8-isi: Break out RAW format selection\"),\n> > \n> > so remove it.\n> > \n> > Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 1 -\n> > 1 file changed, 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > index 4e66b3368..ecda426a6 100644\n> > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > @@ -366,7 +366,6 @@ ISICameraConfiguration::validateRaw(std::set &availableStreams,\n> > * Make sure the requested RAW format is supported by the\n> > * pipeline, otherwise adjust it.\n> > */\n> > - std::vector mbusCodes = data_->sensor_->mbusCodes();\n> > StreamConfiguration &rawConfig = config_[0];\n> > PixelFormat rawFormat = rawConfig.pixelFormat;\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99B3EC327D\n\tfor ;\n\tMon, 21 Apr 2025 14:12:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AF3868AC2;\n\tMon, 21 Apr 2025 16:12:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1194468AC2\n\tfor ;\n\tMon, 21 Apr 2025 16:12:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A3CB56D;\n\tMon, 21 Apr 2025 16:10:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LqXeYMNK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745244633;\n\tbh=qey1jhalLGBE9/eP9odpuOqenpL2vHq0v1BNyKQXMgU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LqXeYMNKt5Whbc878uU5X6e+tsdTmaK7T2QwcvOhGsmxmm1qURkVWEcrS2OGZiLu2\n\tAR30h/F5ZmAa2+LfYht+ANCcGBHm6ylFmqEIY0WQWXz+/FJLb1jXCStnj5vME9pjw1\n\t9Z3D9fqUWdnduC8ZiG5yo8ObrEUB0c9AaxBo3AXA=","Date":"Mon, 21 Apr 2025 17:12:38 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: imx8-isi: Remove unused variable","Message-ID":"<20250421141238.GN29483@pendragon.ideasonboard.com>","References":"<20250418162405.1339989-1-barnabas.pocze@ideasonboard.com>\n\t<174499488844.3064300.12600331477730719781@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<174499488844.3064300.12600331477730719781@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]