[{"id":33969,"web_url":"https://patchwork.libcamera.org/comment/33969/","msgid":"<174499365834.3064300.5966705227378152390@ping.linuxembedded.co.uk>","date":"2025-04-18T16:27:38","subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Fix typo in log message","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-18 17:23:59)\n> pass -> parse\n\nReviewed-by: Kieran Bingham \n\nI think you can merge that straight away.\n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp\n> index 1e009946d..d9900add6 100644\n> --- a/src/libcamera/pipeline/virtual/config_parser.cpp\n> +++ b/src/libcamera/pipeline/virtual/config_parser.cpp\n> @@ -31,7 +31,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)\n> \n> std::unique_ptr cameras = YamlParser::parse(file);\n> if (!cameras) {\n> - LOG(Virtual, Error) << \"Failed to pass config file.\";\n> + LOG(Virtual, Error) << \"Failed to parse config file.\";\n> return configurations;\n> }\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBABEC3213\n\tfor ;\n\tFri, 18 Apr 2025 16:27:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0B09617E7;\n\tFri, 18 Apr 2025 18:27:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2669617E7\n\tfor ;\n\tFri, 18 Apr 2025 18:27:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 076043A4;\n\tFri, 18 Apr 2025 18:25:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WCIwec38\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744993537;\n\tbh=B6E6/sIb9ciIdHlwjf12Vy+p/xp51MTD66c4W7w1W+A=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=WCIwec38tp+ZAJ5XVfcTxt9zfxyFnWacbqY5niIRQ+bG1WMPDqjp4CFz3hQT2IMr+\n\tTJct8kuP8mjsi5G6Qkd0shCo0H8Nn3HaSpjLeCqakQvW0Oo4CZL0EaYWCGN+P7Slbv\n\tusrSHYB6pHh/2+9/HEPp9XxxlJz4IMePwoofXv+U=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250418162359.1339957-1-barnabas.pocze@ideasonboard.com>","References":"<20250418162359.1339957-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Fix typo in log message","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Apr 2025 17:27:38 +0100","Message-ID":"<174499365834.3064300.5966705227378152390@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33974,"web_url":"https://patchwork.libcamera.org/comment/33974/","msgid":"<20250421140456.GL29483@pendragon.ideasonboard.com>","date":"2025-04-21T14:04:56","subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Fix typo in log message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 18, 2025 at 05:27:38PM +0100, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2025-04-18 17:23:59)\n> > pass -> parse\n> \n> Reviewed-by: Kieran Bingham \n> \n> I think you can merge that straight away.\n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp\n> > index 1e009946d..d9900add6 100644\n> > --- a/src/libcamera/pipeline/virtual/config_parser.cpp\n> > +++ b/src/libcamera/pipeline/virtual/config_parser.cpp\n> > @@ -31,7 +31,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)\n> > \n> > std::unique_ptr cameras = YamlParser::parse(file);\n> > if (!cameras) {\n> > - LOG(Virtual, Error) << \"Failed to pass config file.\";\n> > + LOG(Virtual, Error) << \"Failed to parse config file.\";\n> > return configurations;\n> > }\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA9C9BE08B\n\tfor ;\n\tMon, 21 Apr 2025 14:05:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74C3368AC7;\n\tMon, 21 Apr 2025 16:05:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0313168ABA\n\tfor ;\n\tMon, 21 Apr 2025 16:04:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02D3056D;\n\tMon, 21 Apr 2025 16:02:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oq67exBr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745244172;\n\tbh=mJgL+aPg9GjVrUafK4l9hdxMyt7FQtP9ZFIBh17Dc7k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oq67exBrb99xl6F4bfZmFIqVvUiwO7KQ9aOm3HQNMsx29xtnHa/bHOU1yql881NSO\n\trbv6ULnvvX5aWUMnTd6i7+ljL8pLKmcGxSNIeu72220KqcaQlkl+dsNDqXD39/Pj+g\n\tOBsv/XjSLfOIjy6gvqoFxbmAJNAtu1/JWBjjsfvk=","Date":"Mon, 21 Apr 2025 17:04:56 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Fix typo in log message","Message-ID":"<20250421140456.GL29483@pendragon.ideasonboard.com>","References":"<20250418162359.1339957-1-barnabas.pocze@ideasonboard.com>\n\t<174499365834.3064300.5966705227378152390@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<174499365834.3064300.5966705227378152390@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]