[{"id":34689,"web_url":"https://patchwork.libcamera.org/comment/34689/","msgid":"<175101731400.3281735.13507586064092429044@ping.linuxembedded.co.uk>","date":"2025-06-27T09:41:54","subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-25 13:42:31)\n> Generate a macro in the form of LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME\n> for each control so that its existence can be checked easily and without\n> extra version checks.\n> \n> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThis has two tags ... but is still in my inbox/reported as 'New' in\npatchwork. Is it ready to merge?\n\n--\nKieran\n\n> ---\n> changes in v2:\n>   * rename macro from `LIBCAMERA_HAS_$VENDOR_$MODE_$NAME` to\n>     `LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME` so that has the\n>                           ^^^^^^^\n>     name of the macro already generated for the control namespaces\n>     as prefix\n> \n> v1: https://patchwork.libcamera.org/patch/22972/\n> ---\n>  include/libcamera/control_ids.h.in | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\n> index 5d0594c68..6b5712339 100644\n> --- a/include/libcamera/control_ids.h.in\n> +++ b/include/libcamera/control_ids.h.in\n> @@ -49,6 +49,7 @@ extern const std::array<const ControlValue, {{ctrl.enum_values_count}}> {{ctrl.n\n>  extern const std::map<std::string, {{ctrl.type}}> {{ctrl.name}}NameValueMap;\n>  {% endif -%}\n>  extern const Control<{{ctrl.type}}> {{ctrl.name}};\n> +#define LIBCAMERA_HAS_{{vendor|upper}}_VENDOR_{{mode|upper}}_{{ctrl.name|snake_case|upper}}\n>  {% endfor -%}\n> \n>  {% if vendor != 'libcamera' %}\n> --\n> 2.49.0","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23D95C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Jun 2025 09:41:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 075D368DFC;\n\tFri, 27 Jun 2025 11:41:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE4ED62C43\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jun 2025 11:41:56 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22F9173B;\n\tFri, 27 Jun 2025 11:41:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H0vqSvM3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751017297;\n\tbh=gbZ/HvuJDFRoP62IyuEU2jhOcE3tRoMC9g6WkcDyNgE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=H0vqSvM3PLFmm1YXfN+j+quI5JuG5DgogQq42tV1AuNv2ZDw/VGjtGRUymP5UEkWv\n\t8/4zKJYGK8TCHyj2FtRqiH9W0gpOTsIeh6S5cIrGM3+hL0iE57rgtazbak7hB2NOVY\n\tdP8nJ9u9i09ls0Xmve2xkD8xc6zrhyvbr67CIbCQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>","References":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 27 Jun 2025 10:41:54 +0100","Message-ID":"<175101731400.3281735.13507586064092429044@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34692,"web_url":"https://patchwork.libcamera.org/comment/34692/","msgid":"<d8281eb8-bc9e-43bc-b871-59413b6a9f5b@ideasonboard.com>","date":"2025-06-27T10:06:25","subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 06. 27. 11:41 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2025-03-25 13:42:31)\n>> Generate a macro in the form of LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME\n>> for each control so that its existence can be checked easily and without\n>> extra version checks.\n>>\n>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> This has two tags ... but is still in my inbox/reported as 'New' in\n> patchwork. Is it ready to merge?\n\nI think so.\n\n> \n> --\n> Kieran\n> \n>> ---\n>> changes in v2:\n>>    * rename macro from `LIBCAMERA_HAS_$VENDOR_$MODE_$NAME` to\n>>      `LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME` so that has the\n>>                            ^^^^^^^\n>>      name of the macro already generated for the control namespaces\n>>      as prefix\n>>\n>> v1: https://patchwork.libcamera.org/patch/22972/\n>> ---\n>>   include/libcamera/control_ids.h.in | 1 +\n>>   1 file changed, 1 insertion(+)\n>>\n>> diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\n>> index 5d0594c68..6b5712339 100644\n>> --- a/include/libcamera/control_ids.h.in\n>> +++ b/include/libcamera/control_ids.h.in\n>> @@ -49,6 +49,7 @@ extern const std::array<const ControlValue, {{ctrl.enum_values_count}}> {{ctrl.n\n>>   extern const std::map<std::string, {{ctrl.type}}> {{ctrl.name}}NameValueMap;\n>>   {% endif -%}\n>>   extern const Control<{{ctrl.type}}> {{ctrl.name}};\n>> +#define LIBCAMERA_HAS_{{vendor|upper}}_VENDOR_{{mode|upper}}_{{ctrl.name|snake_case|upper}}\n>>   {% endfor -%}\n>>\n>>   {% if vendor != 'libcamera' %}\n>> --\n>> 2.49.0","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7045BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Jun 2025 10:06:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6ECBD68DFE;\n\tFri, 27 Jun 2025 12:06:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05A3E68DE5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jun 2025 12:06:39 +0200 (CEST)","from [192.168.33.12] (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2566819;\n\tFri, 27 Jun 2025 12:06:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V4HGlEki\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751018780;\n\tbh=DjK6PqxBglVU9jAqLV0spC1DE40LNzeESfcq16QZEts=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=V4HGlEkinomLP4N/RiYHMjD9UqyeFPTckrXBNSUPWdT6/rAV/gKAi3X2n4rEDiOgI\n\tti64tbwfp+5MOTYfuXZeKOxQzBBsr+7xQp3oIdnoNGX98BIToiG5QeB7kkZ+hUWqPi\n\tkTeKzyE13VPaNXFMFy9I3SA0WUYY/AQBU2vOXoiY=","Message-ID":"<d8281eb8-bc9e-43bc-b871-59413b6a9f5b@ideasonboard.com>","Date":"Fri, 27 Jun 2025 12:06:25 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>\n\t<175101731400.3281735.13507586064092429044@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<175101731400.3281735.13507586064092429044@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34937,"web_url":"https://patchwork.libcamera.org/comment/34937/","msgid":"<175284701157.560048.13393107949274104008@ping.linuxembedded.co.uk>","date":"2025-07-18T13:56:51","subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-06-27 11:06:25)\n> 2025. 06. 27. 11:41 keltezéssel, Kieran Bingham írta:\n> > Quoting Barnabás Pőcze (2025-03-25 13:42:31)\n> >> Generate a macro in the form of LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME\n> >> for each control so that its existence can be checked easily and without\n> >> extra version checks.\n> >>\n> >> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > \n> > This has two tags ... but is still in my inbox/reported as 'New' in\n> > patchwork. Is it ready to merge?\n> \n> I think so.\n\nIt's still here - please merge it when you're ready and able to.\n\n--\nKieran\n\n\n> \n> > \n> > --\n> > Kieran\n> > \n> >> ---\n> >> changes in v2:\n> >>    * rename macro from `LIBCAMERA_HAS_$VENDOR_$MODE_$NAME` to\n> >>      `LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME` so that has the\n> >>                            ^^^^^^^\n> >>      name of the macro already generated for the control namespaces\n> >>      as prefix\n> >>\n> >> v1: https://patchwork.libcamera.org/patch/22972/\n> >> ---\n> >>   include/libcamera/control_ids.h.in | 1 +\n> >>   1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\n> >> index 5d0594c68..6b5712339 100644\n> >> --- a/include/libcamera/control_ids.h.in\n> >> +++ b/include/libcamera/control_ids.h.in\n> >> @@ -49,6 +49,7 @@ extern const std::array<const ControlValue, {{ctrl.enum_values_count}}> {{ctrl.n\n> >>   extern const std::map<std::string, {{ctrl.type}}> {{ctrl.name}}NameValueMap;\n> >>   {% endif -%}\n> >>   extern const Control<{{ctrl.type}}> {{ctrl.name}};\n> >> +#define LIBCAMERA_HAS_{{vendor|upper}}_VENDOR_{{mode|upper}}_{{ctrl.name|snake_case|upper}}\n> >>   {% endfor -%}\n> >>\n> >>   {% if vendor != 'libcamera' %}\n> >> --\n> >> 2.49.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AD2FC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jul 2025 13:56:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A76C68FA7;\n\tFri, 18 Jul 2025 15:56:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0E436150F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jul 2025 15:56:54 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD9D059DF;\n\tFri, 18 Jul 2025 15:56:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qrRofOlg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752846979;\n\tbh=XwwbuzMFH5MJTmT1G8nyuc4f4JMz3f00Qeb88a86ttY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qrRofOlgnhGoFSDXfZhazDWFnLvPx3p88R6zZcxGqI1Hx9Nx+Ud6PVDDpyMmAALLR\n\tlG+DJWY9biTGia1vP2UJt8NG3A+YJf32buyN4FiTcQ1PTDUqH4orbJz1L1AUsmce31\n\tWV6gS0DaPVhISvxOcrSDAnZtmzmzmgTGK26kOg8s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<d8281eb8-bc9e-43bc-b871-59413b6a9f5b@ideasonboard.com>","References":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>\n\t<175101731400.3281735.13507586064092429044@ping.linuxembedded.co.uk>\n\t<d8281eb8-bc9e-43bc-b871-59413b6a9f5b@ideasonboard.com>","Subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jul 2025 14:56:51 +0100","Message-ID":"<175284701157.560048.13393107949274104008@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34941,"web_url":"https://patchwork.libcamera.org/comment/34941/","msgid":"<1d2a6d6f-c5d2-4737-87b1-3b3dbccb16dc@ideasonboard.com>","date":"2025-07-18T14:07:35","subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 07. 18. 15:56 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2025-06-27 11:06:25)\n>> 2025. 06. 27. 11:41 keltezéssel, Kieran Bingham írta:\n>>> Quoting Barnabás Pőcze (2025-03-25 13:42:31)\n>>>> Generate a macro in the form of LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME\n>>>> for each control so that its existence can be checked easily and without\n>>>> extra version checks.\n>>>>\n>>>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>>>> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>>>\n>>> This has two tags ... but is still in my inbox/reported as 'New' in\n>>> patchwork. Is it ready to merge?\n>>\n>> I think so.\n> \n> It's still here - please merge it when you're ready and able to.\n\nSorry... I have waited so long because I am not sure if it is \"the best\" solution.\nBut since I haven't had a better idea, I suppose it's best to merge this.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> --\n> Kieran\n> \n> \n>>\n>>>\n>>> --\n>>> Kieran\n>>>\n>>>> ---\n>>>> changes in v2:\n>>>>     * rename macro from `LIBCAMERA_HAS_$VENDOR_$MODE_$NAME` to\n>>>>       `LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME` so that has the\n>>>>                             ^^^^^^^\n>>>>       name of the macro already generated for the control namespaces\n>>>>       as prefix\n>>>>\n>>>> v1: https://patchwork.libcamera.org/patch/22972/\n>>>> ---\n>>>>    include/libcamera/control_ids.h.in | 1 +\n>>>>    1 file changed, 1 insertion(+)\n>>>>\n>>>> diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\n>>>> index 5d0594c68..6b5712339 100644\n>>>> --- a/include/libcamera/control_ids.h.in\n>>>> +++ b/include/libcamera/control_ids.h.in\n>>>> @@ -49,6 +49,7 @@ extern const std::array<const ControlValue, {{ctrl.enum_values_count}}> {{ctrl.n\n>>>>    extern const std::map<std::string, {{ctrl.type}}> {{ctrl.name}}NameValueMap;\n>>>>    {% endif -%}\n>>>>    extern const Control<{{ctrl.type}}> {{ctrl.name}};\n>>>> +#define LIBCAMERA_HAS_{{vendor|upper}}_VENDOR_{{mode|upper}}_{{ctrl.name|snake_case|upper}}\n>>>>    {% endfor -%}\n>>>>\n>>>>    {% if vendor != 'libcamera' %}\n>>>> --\n>>>> 2.49.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F36CC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jul 2025 14:07:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 606BE68FA8;\n\tFri, 18 Jul 2025 16:07:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23E866150F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jul 2025 16:07:40 +0200 (CEST)","from [192.168.33.15] (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2505E59E3;\n\tFri, 18 Jul 2025 16:07:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"govdT+Uh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752847625;\n\tbh=lZ3tCj7hjs12pGD/tCqro7/x6vVIP0iI5iT6jdhaJmU=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=govdT+UhoeAWQMxhJxvdKeTkSnjBGl4+KQzSIF34M0RpYecU6lUn3JT6LoL9rThvb\n\tiqvmSWn9FyyqSV6r8v36FOtvZRoC3cJ4MVWDblsHisJpuE4yBCErFNfFGi4qgGucuS\n\tv0YFP4MbXB2D7wjr+R9nrf7kdIrRqqTG996Fl/oQ=","Message-ID":"<1d2a6d6f-c5d2-4737-87b1-3b3dbccb16dc@ideasonboard.com>","Date":"Fri, 18 Jul 2025 16:07:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] libcamera: controls: Generate macro for each control","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>\n\t<175101731400.3281735.13507586064092429044@ping.linuxembedded.co.uk>\n\t<d8281eb8-bc9e-43bc-b871-59413b6a9f5b@ideasonboard.com>\n\t<175284701157.560048.13393107949274104008@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<175284701157.560048.13393107949274104008@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]