[{"id":33954,"web_url":"https://patchwork.libcamera.org/comment/33954/","msgid":"<174487903306.494853.5687263836095045961@ping.linuxembedded.co.uk>","date":"2025-04-17T08:37:13","subject":"Re: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-15 16:48:18)\n> The specific proxy type (see `module_ipa_proxy.h.tmpl`) inherits `IPAProxy`,\n> the specific interface type, and `Object`. The interface type already\n> provides public definitions of the necessary `Signal<>` objects (see\n> `module_ipa_interface.h.tmpl`), so do not duplicate them.\n\nThis sounds like a good thing - but reviewing the IPA templates is\nreally hard for me.\n\nPaul - can you review this please?\n\n--\nKieran\n\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> .../libcamera_templates/module_ipa_proxy.h.tmpl | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index e213b18a0..a0312a7c1 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -44,15 +44,6 @@ public:\n> {{proxy_funcs.func_sig(proxy_name, method, \"\", false, true)|indent(8, true)}};\n> {% endfor %}\n> \n> -{%- for method in interface_event.methods %}\n> - Signal<\n> -{%- for param in method.parameters -%}\n> - {{\"const \" if not param|is_pod}}{{param|name}}{{\" &\" if not param|is_pod and not param|is_enum}}\n> - {{- \", \" if not loop.last}}\n> -{%- endfor -%}\n> -> {{method.mojom_name}};\n> -{% endfor %}\n> -\n> private:\n> void recvMessage(const IPCMessage &data);\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E22C5C3213\n\tfor ;\n\tThu, 17 Apr 2025 08:37:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9EC968AC4;\n\tThu, 17 Apr 2025 10:37:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AB2E68AB6\n\tfor ;\n\tThu, 17 Apr 2025 10:37:16 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB9EE6A2;\n\tThu, 17 Apr 2025 10:35:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cU6Xl0zg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744878912;\n\tbh=N/k8Q9/2JTVjAS2xhyIrkZ4XvRtLu1QEVR6ADVU6DPg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=cU6Xl0zgRBDYDmLGhhKCLymGX9IGrSH+DESQYMlqrlRVRFyf/C5rS4SDtwnKN33E1\n\tee645QPlaOWHpL/y43jwXFO4evbPHqcUcx+oioaGRptSt5PIMSeIN4vJeWvDWiXh5d\n\tgCPBw0z915RVow4a7HS6vvdtAyGGgbeW5MkOY8dE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","References":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org, Paul Elder\n\t, ","Date":"Thu, 17 Apr 2025 09:37:13 +0100","Message-ID":"<174487903306.494853.5687263836095045961@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33963,"web_url":"https://patchwork.libcamera.org/comment/33963/","msgid":"","date":"2025-04-18T07:38:32","subject":"Re: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Barnabás,\n\nThanks for the patch.\n\nOn Tue, Apr 15, 2025 at 05:48:18PM +0200, Barnabás Pőcze wrote:\n> The specific proxy type (see `module_ipa_proxy.h.tmpl`) inherits `IPAProxy`,\n> the specific interface type, and `Object`. The interface type already\n> provides public definitions of the necessary `Signal<>` objects (see\n> `module_ipa_interface.h.tmpl`), so do not duplicate them.\n\nGood catch.\n\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> .../libcamera_templates/module_ipa_proxy.h.tmpl | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index e213b18a0..a0312a7c1 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -44,15 +44,6 @@ public:\n> {{proxy_funcs.func_sig(proxy_name, method, \"\", false, true)|indent(8, true)}};\n> {% endfor %}\n> \n> -{%- for method in interface_event.methods %}\n> -\tSignal<\n> -{%- for param in method.parameters -%}\n> -\t\t{{\"const \" if not param|is_pod}}{{param|name}}{{\" &\" if not param|is_pod and not param|is_enum}}\n> -\t\t{{- \", \" if not loop.last}}\n> -{%- endfor -%}\n> -> {{method.mojom_name}};\n> -{% endfor %}\n> -\n> private:\n> \tvoid recvMessage(const IPCMessage &data);\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC1C6C327D\n\tfor ;\n\tFri, 18 Apr 2025 07:38:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E989B68AC1;\n\tFri, 18 Apr 2025 09:38:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA0E268AB5\n\tfor ;\n\tFri, 18 Apr 2025 09:38:39 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8f5d:55c8:fd32:b527])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53833F6;\n\tFri, 18 Apr 2025 09:36:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wffo+zf6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744961795;\n\tbh=23vtPb/5f7Nu0Lu31Kkmk6OQgaRcLxW4tzq1W7k8vw0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wffo+zf6egigAGEbTm7RJHv5UrTgWwEz09x7gPMNwD0Um7vgdVaN3JZzE+aCdpkDB\n\tR9ElCBtg1OkymketKwwA3MHwVBqAbHq+z25Fn/Sw0hX0hC3WsYRaRhLzNMitRCn0VB\n\tj7y0MRcdQhLoXrRbsOIET3x9WO0m9d0Ow9a+chnU=","Date":"Fri, 18 Apr 2025 16:38:32 +0900","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object","Message-ID":"","References":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33975,"web_url":"https://patchwork.libcamera.org/comment/33975/","msgid":"<20250421141031.GM29483@pendragon.ideasonboard.com>","date":"2025-04-21T14:10:31","subject":"Re: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Apr 15, 2025 at 05:48:18PM +0200, Barnabás Pőcze wrote:\n> The specific proxy type (see `module_ipa_proxy.h.tmpl`) inherits `IPAProxy`,\n> the specific interface type, and `Object`. The interface type already\n> provides public definitions of the necessary `Signal<>` objects (see\n> `module_ipa_interface.h.tmpl`), so do not duplicate them.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .../libcamera_templates/module_ipa_proxy.h.tmpl | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index e213b18a0..a0312a7c1 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -44,15 +44,6 @@ public:\n> {{proxy_funcs.func_sig(proxy_name, method, \"\", false, true)|indent(8, true)}};\n> {% endfor %}\n> \n> -{%- for method in interface_event.methods %}\n> -\tSignal<\n> -{%- for param in method.parameters -%}\n> -\t\t{{\"const \" if not param|is_pod}}{{param|name}}{{\" &\" if not param|is_pod and not param|is_enum}}\n> -\t\t{{- \", \" if not loop.last}}\n> -{%- endfor -%}\n> -> {{method.mojom_name}};\n> -{% endfor %}\n> -\n> private:\n> \tvoid recvMessage(const IPCMessage &data);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 824F9C327D\n\tfor ;\n\tMon, 21 Apr 2025 14:10:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8584268AC7;\n\tMon, 21 Apr 2025 16:10:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F0D468ABA\n\tfor ;\n\tMon, 21 Apr 2025 16:10:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A33056D;\n\tMon, 21 Apr 2025 16:08:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dtxQc43I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745244506;\n\tbh=6wUY1F5uGD7gdGOOa1eKtasx+Po+ZeyAvgkgaQ85j8Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dtxQc43IWHWA1bFdU5+Pt+GgfjMGdKpxVIrin7visithRTYAHyi+u+2LsAoAFcx+E\n\tNB4tSYVEkwVdwK9T4jucr8QKE1NaP88C7oWyV8de5iTYxvJCQkadmE9XsfTfqJ3wOk\n\tLuFlcGz0HThCCeMIJMz1ZMIB7tRzMWQ6BOIUEQlk=","Date":"Mon, 21 Apr 2025 17:10:31 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object","Message-ID":"<20250421141031.GM29483@pendragon.ideasonboard.com>","References":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]