{"id":23181,"url":"https://patchwork.libcamera.org/api/patches/23181/?format=json","web_url":"https://patchwork.libcamera.org/patch/23181/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","date":"2025-04-15T15:48:18","name":"[v1] utils: ipc: Do not duplicate signals in proxy object","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1c9d73282115a47b7a226235a7ae8ebc13615829","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23181/mbox/","series":[{"id":5128,"url":"https://patchwork.libcamera.org/api/series/5128/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5128","date":"2025-04-15T15:48:18","name":"[v1] utils: ipc: Do not duplicate signals in proxy object","version":1,"mbox":"https://patchwork.libcamera.org/series/5128/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23181/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23181/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA1F2C3213\n\tfor ;\n\tTue, 15 Apr 2025 15:48:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA2FC68AB9;\n\tTue, 15 Apr 2025 17:48:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCE98627EF\n\tfor ;\n\tTue, 15 Apr 2025 17:48:21 +0200 (CEST)","from pb-laptop.local (185.182.215.138.nat.pool.zt.hu\n\t[185.182.215.138])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FE57725\n\tfor ;\n\tTue, 15 Apr 2025 17:46:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PQ4pWxbM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744731979;\n\tbh=DobXLS0+Mp0vDLiEIZHe9C8n9PiIrwF3gHhqlIpEuDU=;\n\th=From:To:Subject:Date:From;\n\tb=PQ4pWxbMyXFhjSubyN/Unpm9UIgrDJOz2/TNbh8lsrTb25f0xcb+vMtNCMUq8Puee\n\tIbdJwunqpy0oVy7KJ0LCGMbQvs7K85yWoe/EfER+EptDQ9NLpySmRziZj1E2QMDZhG\n\tIEug2rHxNlPsWPmCldfb8tLMB6AxrzAgC2/qifhw=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] utils: ipc: Do not duplicate signals in proxy object","Date":"Tue, 15 Apr 2025 17:48:18 +0200","Message-ID":"<20250415154818.398689-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The specific proxy type (see `module_ipa_proxy.h.tmpl`) inherits `IPAProxy`,\nthe specific interface type, and `Object`. The interface type already\nprovides public definitions of the necessary `Signal<>` objects (see\n`module_ipa_interface.h.tmpl`), so do not duplicate them.\n\nSigned-off-by: Barnabás Pőcze \n---\n .../libcamera_templates/module_ipa_proxy.h.tmpl | 9 ---------\n 1 file changed, 9 deletions(-)","diff":"diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\nindex e213b18a0..a0312a7c1 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n@@ -44,15 +44,6 @@ public:\n {{proxy_funcs.func_sig(proxy_name, method, \"\", false, true)|indent(8, true)}};\n {% endfor %}\n \n-{%- for method in interface_event.methods %}\n-\tSignal<\n-{%- for param in method.parameters -%}\n-\t\t{{\"const \" if not param|is_pod}}{{param|name}}{{\" &\" if not param|is_pod and not param|is_enum}}\n-\t\t{{- \", \" if not loop.last}}\n-{%- endfor -%}\n-> {{method.mojom_name}};\n-{% endfor %}\n-\n private:\n \tvoid recvMessage(const IPCMessage &data);\n \n","prefixes":["v1"]}