[{"id":33937,"web_url":"https://patchwork.libcamera.org/comment/33937/","msgid":"<174456628395.3333606.12593415577827821080@ping.linuxembedded.co.uk>","date":"2025-04-13T17:44:43","subject":"Re: [PATCH] doc: document libtiff dependency for cam","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Pavel Machek (2025-04-12 08:41:22)\n> DNG writing is useful when working with bayer data, but libtiff is\n> needed for that.\n> \n> Signed-off-by: Pavel Machek \n> \n> diff --git a/README.rst b/README.rst\n> index ae5126e2..31c27c87 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -83,6 +83,7 @@ for cam: [optional]\n> - libdrm-dev: Enables the KMS sink\n> - libjpeg-dev: Enables MJPEG on the SDL sink\n> - libsdl2-dev: Enables the SDL sink\n> + - libtiff-dev: For dng writing\n\nI think DNG could be capitalised, but we can handle that while applying.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> for qcam: [optional]\n> libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> \n> -- \n> I don't work for Nazis and criminals, and neither should you.\n> Boycott Putin, Trump, and Musk!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59AF0C3213\n\tfor ;\n\tSun, 13 Apr 2025 17:44:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81B1A68AB7;\n\tSun, 13 Apr 2025 19:44:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD06368A99\n\tfor ;\n\tSun, 13 Apr 2025 19:44:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DAE64520;\n\tSun, 13 Apr 2025 19:42:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Uec058n0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744566165;\n\tbh=60KCMri0CIzyeBqyxLWohK9hPSLHNOWFayMhKbaXduE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Uec058n00ftallU8RSFPwzCQEfSoc62bcy/q1YRHTeXPE130QYo8IvvmYMnHzDeGl\n\tI7h+lf0UkAuGYEF1QcFltOlIU68UrVLUQhUNT4nsZUmOfm3ds/CjO2wscqgllLRfvu\n\tgM+TrlIeAib9QY2yqT8tYSY+3Fu7azR8B7xRlJN8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"","Subject":"Re: [PATCH] doc: document libtiff dependency for cam","From":"Kieran Bingham ","To":"Pavel Machek , laurent.pinchart@ideasonboard.com,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 13 Apr 2025 18:44:43 +0100","Message-ID":"<174456628395.3333606.12593415577827821080@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33943,"web_url":"https://patchwork.libcamera.org/comment/33943/","msgid":"<20250413235508.GE12286@pendragon.ideasonboard.com>","date":"2025-04-13T23:55:08","subject":"Re: [PATCH] doc: document libtiff dependency for cam","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Apr 13, 2025 at 06:44:43PM +0100, Kieran Bingham wrote:\n> Quoting Pavel Machek (2025-04-12 08:41:22)\n> > DNG writing is useful when working with bayer data, but libtiff is\n> > needed for that.\n> > \n> > Signed-off-by: Pavel Machek \n> > \n> > diff --git a/README.rst b/README.rst\n> > index ae5126e2..31c27c87 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -83,6 +83,7 @@ for cam: [optional]\n> > - libdrm-dev: Enables the KMS sink\n> > - libjpeg-dev: Enables MJPEG on the SDL sink\n> > - libsdl2-dev: Enables the SDL sink\n> > + - libtiff-dev: For dng writing\n> \n> I think DNG could be capitalised, but we can handle that while applying.\n\nI'd write\n\n - libtiff-dev: Enables writing DNG\n\nto match the other entries.\n\n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > \n> > for qcam: [optional]\n> > libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41532C327D\n\tfor ;\n\tSun, 13 Apr 2025 23:55:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1FA568ABB;\n\tMon, 14 Apr 2025 01:55:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42231617EE\n\tfor ;\n\tMon, 14 Apr 2025 01:55:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19B28475;\n\tMon, 14 Apr 2025 01:53:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rCci63c3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744588388;\n\tbh=W0csDixWUb7F4SITgNVojU0KJl0oXYYSI6VzK/D1YXs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rCci63c3rANb3f9OGY4m5fV3b33PLKZ0aX4AYKimT1YV7Mm6HPL3JRUSZed8SE9tX\n\t/75vHNJfPLx51rFGchxVYoFdEPaY1OZtXpIqrv3KCyGbnwloEKFKJxTQRJh6InYLwH\n\tKrgd3V9N4YqQsToHkRoI2Cp88GGgYD3y7wy5Xkso=","Date":"Mon, 14 Apr 2025 02:55:08 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Pavel Machek , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] doc: document libtiff dependency for cam","Message-ID":"<20250413235508.GE12286@pendragon.ideasonboard.com>","References":"\n\t<174456628395.3333606.12593415577827821080@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174456628395.3333606.12593415577827821080@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]