[{"id":34211,"web_url":"https://patchwork.libcamera.org/comment/34211/","msgid":"<174708608723.7542.5257443339157404984@pyrite.rasen.tech>","date":"2025-05-12T21:41:27","subject":"Re: [PATCH 8/8] ipa: rkisp1: agc: Add debug controls for statistic\n\tvalues","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 15:04:15)\n> Add debug controls for AWB stats and exposure means.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 16 +++++++++++++++\n> src/ipa/rkisp1/algorithms/awb.cpp | 3 +++\n> src/libcamera/control_ids_debug.yaml | 29 ++++++++++++++++++++++++++++\n> 3 files changed, 48 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index a2c8d5403ba2..6dc8b9fc0a31 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -400,8 +400,10 @@ void Agc::fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> {\n> utils::Duration exposureTime = context.configuration.sensor.lineDuration\n> * frameContext.sensor.exposure;\n> + utils::Duration exposureTimeCorrected = exposureTime * frameContext.awb.additionalGain;\n> metadata.set(controls::AnalogueGain, frameContext.sensor.gain);\n> metadata.set(controls::ExposureTime, exposureTime.get());\n> + metadata.set(controls::debug::ExposureTimeCorrected, exposureTimeCorrected.get());\n> metadata.set(controls::FrameDuration, frameContext.agc.frameDuration.get());\n> metadata.set(controls::ExposureTimeMode,\n> frameContext.agc.autoExposureEnabled\n> @@ -574,6 +576,20 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> frameContext.agc.exposureMode,\n> hist, effectiveExposureValue);\n> \n> + auto &debugMeta = context.debugMetadata;\n> + std::vector histMeta;\n> + for (unsigned i = 0; i < context.hw->numHistogramBins; i++)\n> + histMeta.push_back(params->hist.hist_bins[i] >> 4);\n> + debugMeta.set>(controls::debug::StatsHistogram, histMeta);\n> +\n> + double meanExposure = 0;\n> + for (uint8_t expMean : expMeans_)\n> + meanExposure += expMean;\n> + meanExposure = meanExposure / expMeans_.size() / 255.0;\n> + debugMeta.set(controls::debug::StatsExpMean, meanExposure);\n> +\n> + debugMeta.set>(controls::debug::StatsExpMeans, expMeans_);\n> +\n> LOG(RkISP1Agc, Debug)\n> << \"Divided up exposure time, analogue gain and digital gain are \"\n> << newExposureTime << \", \" << aGain << \" and \" << dGain;\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index cc78136a22c8..be08458e45e3 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -310,6 +310,9 @@ void Awb::process(IPAContext &context,\n> \n> RGB rgbMeans = calculateRgbMeans(frameContext, awb);\n> \n> + context.debugMetadata.set>(controls::debug::RgbMeans, Vector(rgbMeans).data());\n> + context.debugMetadata.set(controls::debug::AwbCount, awb->awb_mean[0].cnt);\n> +\n> /*\n> * If the means are too small we don't have enough information to\n> * meaningfully calculate gains. Freeze the algorithm in that case.\n> diff --git a/src/libcamera/control_ids_debug.yaml b/src/libcamera/control_ids_debug.yaml\n> index 9489e677402e..d0f9329187f7 100644\n> --- a/src/libcamera/control_ids_debug.yaml\n> +++ b/src/libcamera/control_ids_debug.yaml\n> @@ -1,9 +1,38 @@\n> # SPDX-License-Identifier: LGPL-2.1-or-later\n> #\n> +# This file was generated by utils/gen-debug-controls.py\n> +#\n> %YAML 1.1\n> ---\n> vendor: debug\n> controls:\n> +- AwbCount:\n> + type: int\n> + direction: out\n> + description: Debug control AwbCount found in src/ipa/rkisp1/algorithms/awb.cpp\n> +- ExposureTimeCorrected:\n> + type: float\n> + direction: out\n> + description: Debug control ExposureTimeCorrected found in src/ipa/rkisp1/algorithms/agc.cpp\n> +- RgbMeans:\n> + type: float\n> + direction: out\n> + description: Debug control RgbMeans found in src/ipa/rkisp1/algorithms/awb.cpp\n> + size: '[n]'\n> +- StatsExpMean:\n> + type: const float\n> + direction: out\n> + description: Debug control StatsExpMean found in src/ipa/rkisp1/algorithms/agc.cpp\n> +- StatsExpMeans:\n> + type: uint8_t\n> + direction: out\n> + description: Debug control StatsExpMeans found in src/ipa/rkisp1/algorithms/agc.cpp\n> + size: '[n]'\n> +- StatsHistogram:\n> + type: int32_t\n> + direction: out\n> + description: Debug control StatsHistogram found in src/ipa/rkisp1/algorithms/agc.cpp\n> + size: '[n]'\n> - WdrCurve:\n> type: Point\n> direction: out\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53B90C3200\n\tfor ;\n\tMon, 12 May 2025 21:41:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1409F68B52;\n\tMon, 12 May 2025 23:41:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 459FF614E3\n\tfor ;\n\tMon, 12 May 2025 23:41:30 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27B8B8CB;\n\tMon, 12 May 2025 23:41:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ClvLPVvh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747086075;\n\tbh=ihVLm/B673mLubHZmVvnWol3UE/wa33zYEAdpgNFCpc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ClvLPVvhf1MygquECYxVrKjrB0iUXFEHs89TbiRsF4pI5+SktI15jTDbZlAd/IMEy\n\tplLu65gWVTk6RNUbEdaa863GZiHgAslxXECpQyZxegIFjSc/cXLtkXzsGkAY4DDTpd\n\tmHtZtYXKhfugE2PJqbMavE1AYsBIUl60Id2Pu0dM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411130423.2164577-9-stefan.klug@ideasonboard.com>","References":"<20250411130423.2164577-1-stefan.klug@ideasonboard.com>\n\t<20250411130423.2164577-9-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 8/8] ipa: rkisp1: agc: Add debug controls for statistic\n\tvalues","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 May 2025 23:41:27 +0200","Message-ID":"<174708608723.7542.5257443339157404984@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]