[{"id":3033,"web_url":"https://patchwork.libcamera.org/comment/3033/","msgid":"<20191115170521.es52gu6p7f4op6r7@uno.localdomain>","date":"2019-11-15T17:05:21","subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Nov 08, 2019 at 10:54:06PM +0200, Laurent Pinchart wrote:\n> IPA modules have to implement a public ipaCreate() function, but its\n> prototype isn't declared in any header file. This allows for modules to\n> get the prototype wrong without being warned by the compiler. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/ipa/ipa_interface.h | 2 ++\n> src/libcamera/ipa_interface.cpp | 10 ++++++++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\n> index 3a423e37671f..92f1aac50b85 100644\n> --- a/include/ipa/ipa_interface.h\n> +++ b/include/ipa/ipa_interface.h\n> @@ -80,6 +80,8 @@ struct ipa_context_ops {\n> \t\t\t const struct ipa_operation_data *data);\n> };\n>\n> +struct ipa_context *ipaCreate();\n> +\n> #ifdef __cplusplus\n> }\n>\n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index 89fce0e8347f..cb2767a04711 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -261,6 +261,16 @@\n> * \\sa libcamera::IPAInterface::processEvent()\n> */\n>\n> +/**\n> + * \\fn ipaCreate()\n> + * \\brief Entry point to the IPA modules\n> + *\n> + * This function is the entry point to the IPA modules. It is implemented by\n> + * every IPA module, and called by libcamera to create a new IPA context.\n> + *\n> + * \\return A newly created IPA context\n> + */\n> +\n\nYout might want to remove the prototype defined in the \\file comment\nblock in ipa_interface.cpp and let Doxygen link ipaCreate() mentions\nwith this\n\nApart from that\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> namespace libcamera {\n>\n> /**\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE6976136F\n\tfor ;\n\tFri, 15 Nov 2019 18:03:20 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 4B4EA20000A;\n\tFri, 15 Nov 2019 17:03:20 +0000 (UTC)"],"Date":"Fri, 15 Nov 2019 18:05:21 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191115170521.es52gu6p7f4op6r7@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-22-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"etks7a6ke3vbe4yl\"","Content-Disposition":"inline","In-Reply-To":"<20191108205409.18845-22-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 Nov 2019 17:03:20 -0000"}},{"id":3043,"web_url":"https://patchwork.libcamera.org/comment/3043/","msgid":"<20191118010919.GO4853@pendragon.ideasonboard.com>","date":"2019-11-18T01:09:19","subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Nov 15, 2019 at 06:05:21PM +0100, Jacopo Mondi wrote:\n> On Fri, Nov 08, 2019 at 10:54:06PM +0200, Laurent Pinchart wrote:\n> > IPA modules have to implement a public ipaCreate() function, but its\n> > prototype isn't declared in any header file. This allows for modules to\n> > get the prototype wrong without being warned by the compiler. Fix it.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/ipa/ipa_interface.h | 2 ++\n> > src/libcamera/ipa_interface.cpp | 10 ++++++++++\n> > 2 files changed, 12 insertions(+)\n> >\n> > diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\n> > index 3a423e37671f..92f1aac50b85 100644\n> > --- a/include/ipa/ipa_interface.h\n> > +++ b/include/ipa/ipa_interface.h\n> > @@ -80,6 +80,8 @@ struct ipa_context_ops {\n> > \t\t\t const struct ipa_operation_data *data);\n> > };\n> >\n> > +struct ipa_context *ipaCreate();\n> > +\n> > #ifdef __cplusplus\n> > }\n> >\n> > diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> > index 89fce0e8347f..cb2767a04711 100644\n> > --- a/src/libcamera/ipa_interface.cpp\n> > +++ b/src/libcamera/ipa_interface.cpp\n> > @@ -261,6 +261,16 @@\n> > * \\sa libcamera::IPAInterface::processEvent()\n> > */\n> >\n> > +/**\n> > + * \\fn ipaCreate()\n> > + * \\brief Entry point to the IPA modules\n> > + *\n> > + * This function is the entry point to the IPA modules. It is implemented by\n> > + * every IPA module, and called by libcamera to create a new IPA context.\n> > + *\n> > + * \\return A newly created IPA context\n> > + */\n> > +\n> \n> Yout might want to remove the prototype defined in the \\file comment\n> block in ipa_interface.cpp and let Doxygen link ipaCreate() mentions\n> with this\n\nI like having it there, as it gives a nice overview without a need to\njump to the ipaCreate() documentation, but if you think it should be\nremoved, I can replace the two paragraphs with\n\n * IPA modules shall expose a public function named ipaCreate(). The function\n * creates an instance of an IPA context, which models a context of execution\n * for the IPA. IPA modules shall support creating one context per camera, as\n * required by their associated pipeline handler.\n\nPlease let me know what you think is best.\n\n> Apart from that\n> Reviewed-by: Jacopo Mondi \n> \n> > namespace libcamera {\n> >\n> > /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EC4760C33\n\tfor ;\n\tMon, 18 Nov 2019 02:09:24 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1E9511F2;\n\tMon, 18 Nov 2019 02:09:23 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574039363;\n\tbh=Z0D703Cvsu7QEy6ulSiCaUbEoT3s89PoeiqVLf43Bl4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WHhW4eWeMUSq0H/DRJzQxdR+0/oUOkQLZVV9SBDqA84Y4hioISAzEb+/d/V7HhHmH\n\t1Lb5bpD3aFY//VakN2T53+gbWaYAoJyFsvc+47/i6Hpjk9l3QOmQ1+1Omk7rhobK3T\n\ti4IbG59Fh9sf+ik5uq7QvB/10SUAn08Gf+HUI9dI=","Date":"Mon, 18 Nov 2019 03:09:19 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118010919.GO4853@pendragon.ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-22-laurent.pinchart@ideasonboard.com>\n\t<20191115170521.es52gu6p7f4op6r7@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191115170521.es52gu6p7f4op6r7@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 01:09:24 -0000"}},{"id":3091,"web_url":"https://patchwork.libcamera.org/comment/3091/","msgid":"<20191118230107.ouh3bu6oismyueqs@uno.localdomain>","date":"2019-11-18T23:01:07","subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Nov 18, 2019 at 03:09:19AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Fri, Nov 15, 2019 at 06:05:21PM +0100, Jacopo Mondi wrote:\n> > On Fri, Nov 08, 2019 at 10:54:06PM +0200, Laurent Pinchart wrote:\n> > > IPA modules have to implement a public ipaCreate() function, but its\n> > > prototype isn't declared in any header file. This allows for modules to\n> > > get the prototype wrong without being warned by the compiler. Fix it.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > include/ipa/ipa_interface.h | 2 ++\n> > > src/libcamera/ipa_interface.cpp | 10 ++++++++++\n> > > 2 files changed, 12 insertions(+)\n> > >\n> > > diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\n> > > index 3a423e37671f..92f1aac50b85 100644\n> > > --- a/include/ipa/ipa_interface.h\n> > > +++ b/include/ipa/ipa_interface.h\n> > > @@ -80,6 +80,8 @@ struct ipa_context_ops {\n> > > \t\t\t const struct ipa_operation_data *data);\n> > > };\n> > >\n> > > +struct ipa_context *ipaCreate();\n> > > +\n> > > #ifdef __cplusplus\n> > > }\n> > >\n> > > diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> > > index 89fce0e8347f..cb2767a04711 100644\n> > > --- a/src/libcamera/ipa_interface.cpp\n> > > +++ b/src/libcamera/ipa_interface.cpp\n> > > @@ -261,6 +261,16 @@\n> > > * \\sa libcamera::IPAInterface::processEvent()\n> > > */\n> > >\n> > > +/**\n> > > + * \\fn ipaCreate()\n> > > + * \\brief Entry point to the IPA modules\n> > > + *\n> > > + * This function is the entry point to the IPA modules. It is implemented by\n> > > + * every IPA module, and called by libcamera to create a new IPA context.\n> > > + *\n> > > + * \\return A newly created IPA context\n> > > + */\n> > > +\n> >\n> > Yout might want to remove the prototype defined in the \\file comment\n> > block in ipa_interface.cpp and let Doxygen link ipaCreate() mentions\n> > with this\n>\n> I like having it there, as it gives a nice overview without a need to\n> jump to the ipaCreate() documentation, but if you think it should be\n> removed, I can replace the two paragraphs with\n\nNo no, more documentation it's fine, please take my tag in.\n>\n> * IPA modules shall expose a public function named ipaCreate(). The function\n> * creates an instance of an IPA context, which models a context of execution\n> * for the IPA. IPA modules shall support creating one context per camera, as\n> * required by their associated pipeline handler.\n>\n> Please let me know what you think is best.\n>\n> > Apart from that\n> > Reviewed-by: Jacopo Mondi \n> >\n> > > namespace libcamera {\n> > >\n> > > /**\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3749360F1C\n\tfor ;\n\tMon, 18 Nov 2019 23:59:05 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id E1B7020003;\n\tMon, 18 Nov 2019 22:59:03 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 19 Nov 2019 00:01:07 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118230107.ouh3bu6oismyueqs@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-22-laurent.pinchart@ideasonboard.com>\n\t<20191115170521.es52gu6p7f4op6r7@uno.localdomain>\n\t<20191118010919.GO4853@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"txb2chgeh4e5tnom\"","Content-Disposition":"inline","In-Reply-To":"<20191118010919.GO4853@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 22:59:05 -0000"}},{"id":3092,"web_url":"https://patchwork.libcamera.org/comment/3092/","msgid":"<20191118230627.GP8072@bigcity.dyn.berto.se>","date":"2019-11-18T23:06:27","subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-11-08 22:54:06 +0200, Laurent Pinchart wrote:\n> IPA modules have to implement a public ipaCreate() function, but its\n> prototype isn't declared in any header file. This allows for modules to\n> get the prototype wrong without being warned by the compiler. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/ipa/ipa_interface.h | 2 ++\n> src/libcamera/ipa_interface.cpp | 10 ++++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\n> index 3a423e37671f..92f1aac50b85 100644\n> --- a/include/ipa/ipa_interface.h\n> +++ b/include/ipa/ipa_interface.h\n> @@ -80,6 +80,8 @@ struct ipa_context_ops {\n> \t\t\t const struct ipa_operation_data *data);\n> };\n> \n> +struct ipa_context *ipaCreate();\n> +\n> #ifdef __cplusplus\n> }\n> \n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index 89fce0e8347f..cb2767a04711 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -261,6 +261,16 @@\n> * \\sa libcamera::IPAInterface::processEvent()\n> */\n> \n> +/**\n> + * \\fn ipaCreate()\n> + * \\brief Entry point to the IPA modules\n> + *\n> + * This function is the entry point to the IPA modules. It is implemented by\n> + * every IPA module, and called by libcamera to create a new IPA context.\n> + *\n> + * \\return A newly created IPA context\n> + */\n> +\n> namespace libcamera {\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8DD560C12\n\tfor ;\n\tTue, 19 Nov 2019 00:06:28 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id n5so20974630ljc.9\n\tfor ;\n\tMon, 18 Nov 2019 15:06:28 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tb23sm5805377lfi.77.2019.11.18.15.06.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2019 15:06:27 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ihuHftnXnaTyugbggAcxmGmF3nHsmMpxHrmrbsKSzks=;\n\tb=Rqf5Lk4AAyyGgrNUgbdZnEzynil0al2OzhVX9IuL9OymlxXvNFX6yhE4JsmgLsBlqr\n\t5IeDPFz4K/HgYdRR9m/L4q101d9h2oIpVde4zhtbbJtohzqv/Q6oPOQnXvODtYq40bYe\n\tGbqB4lu+sueT9jEdKRxKPE+obxwbDbxUrJ+vMzziy6DELVguZwyxqy4uddWAlDf4yYip\n\t1U6T7/366G+8mOJHDPIR2GmnbS3mjh34IRhzkhbhGKfyuq4JiAf3URklFiYlCAdZVBs3\n\tcBhrQbJnvUzy8CReH6sakXyYJo8756Weas9G8NCTBcm5NpvWT1oLThWuR5LE8ue+Td92\n\tqTGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ihuHftnXnaTyugbggAcxmGmF3nHsmMpxHrmrbsKSzks=;\n\tb=CiJ007bPJovxnxOlTxLidc9A/5JKV9X2ttPHx+nsbOnwD5ZiIcs3XXhTrGWkra1qmU\n\tbDg9QAiJMoCJ1beJy4u3SVFTnguehWGr3ZUbAQHwOFUVI4p8D9/IHjcOOs7is86KnJS2\n\t8EJbhbxJWXcnP9iFVwwWF2iqM9fdWbR3n8+lSNYz0l/HQyOnQ+LW/Vf11x1V/SgGykos\n\ttOdH1TyDhKSISOv2/8lxoAeMP69N+M+imedh9I357qnYYe444o+RyPHmUxVGHwTGGBay\n\tILF/1MKa8B5b4dqrvJkLZ5FkFFAOUz7MGhq7RDUT0LVNVFUiZbNe0T1uREgFrifr/v11\n\tXqzA==","X-Gm-Message-State":"APjAAAXavOgWoO1cBtbv+A5xBqcOdU9JK7f1y7xLuFx8/++oz4fs278B\n\tjcRW0AWfKHcL+HSTbkMB2kNFsQ==","X-Google-Smtp-Source":"APXvYqxh3ZpuB/BA6QXcxrJRxkkP6zN3VHMHpMetaOWL/pWbBtk3tLu/I3stFYbTcXhZeHS4Mo2c0w==","X-Received":"by 2002:a2e:9151:: with SMTP id\n\tq17mr1404646ljg.156.1574118388363; \n\tMon, 18 Nov 2019 15:06:28 -0800 (PST)","Date":"Tue, 19 Nov 2019 00:06:27 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118230627.GP8072@bigcity.dyn.berto.se>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-22-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108205409.18845-22-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate()\n\tfunction prototype","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 23:06:29 -0000"}}]