[{"id":34198,"web_url":"https://patchwork.libcamera.org/comment/34198/","msgid":"<174704199733.521251.2112691629109085923@pyrite.rasen.tech>","date":"2025-05-12T09:26:37","subject":"Re: [PATCH 2/8] tuning: rksip1: Add a static WideDynamicRange entry","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 15:04:09)\n> Add a static WideDynamicRange entry that gets added by default.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/rkisp1.py | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 207b717a029c..1c9261021922 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -47,15 +47,18 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> # values. This can also be a custom function.\n> smoothing_function=lt.smoothing.MedianBlur(3),)\n> lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> +wdr = StaticModule('WideDynamicRange',\n> + { 'ExposureConstraint': { 'MaxBrightPixels': 0.02, 'yTarget': 0.95 },\n> + 'MinExposureValue': -4.0 })\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, wdr])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> \n> # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> - filter, gamma_out, lsc])\n> + filter, gamma_out, lsc, wdr])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AD76C3200\n\tfor ;\n\tMon, 12 May 2025 09:26:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB81C68D65;\n\tMon, 12 May 2025 11:26:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA2B568B44\n\tfor ;\n\tMon, 12 May 2025 11:26:40 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD9F76AF;\n\tMon, 12 May 2025 11:26:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QTTgyuzb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747041985;\n\tbh=2iKW+e8F1x9bbNvqZwMg0unSnBQFfylvvsoMkVDmSr8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=QTTgyuzbuehNtFcdySEPJTm1iK2B7NSLxnMZ9mxceQpjXGwCJPj/7DohzJy222vID\n\tDGY5X+SU2Pqo5zwcTp7rIa7vl0qL2EurtVtWw4AcS3dAssQxgIZswr2WHJas2sPQQ3\n\tgWkCeK+kLClBV9sNO04zBfgN5BaD+Inv3A9m1xf0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411130423.2164577-3-stefan.klug@ideasonboard.com>","References":"<20250411130423.2164577-1-stefan.klug@ideasonboard.com>\n\t<20250411130423.2164577-3-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 2/8] tuning: rksip1: Add a static WideDynamicRange entry","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 May 2025 11:26:37 +0200","Message-ID":"<174704199733.521251.2112691629109085923@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]