[{"id":33934,"web_url":"https://patchwork.libcamera.org/comment/33934/","msgid":"<174446225018.722505.6207575815626275600@ping.linuxembedded.co.uk>","date":"2025-04-12T12:50:50","subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 13:36:35)\n> The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\n\nWas the bug introduced in 6.13? Or exists only in versions before 6.13 ?\nor only since?\n\nWould probably be helpful/useful to clarify when applying.\n\n--\nKieran\n\n\n> applied correctly. Add the color space to the debug log output to be\n> able to detect that now and later.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 9d7a3bd57ada..2708cecca0b0 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \n> LOG(RkISP1, Debug)\n> << \"ISP output pad configured with \" << format\n> - << \" crop \" << outputCrop;\n> + << \" crop \" << outputCrop\n> + << \" color space \" << ColorSpace::toString(format.colorSpace);\n> \n> IPACameraSensorInfo sensorInfo;\n> ret = data->sensor_->sensorInfo(&sensorInfo);\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACFC4C327D\n\tfor ;\n\tSat, 12 Apr 2025 12:50:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C340368AA9;\n\tSat, 12 Apr 2025 14:50:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D69468AA7\n\tfor ;\n\tSat, 12 Apr 2025 14:50:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C643D50A;\n\tSat, 12 Apr 2025 14:48:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lff3aeJ9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744462132;\n\tbh=tBAzjlxtbXm2O9n+d/0ILi1EeN7T3Ktjbn9/HAC70LU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Lff3aeJ9qESYuZAVLxpAlPJYR8otvTDzGCPRM64d1m/ICtutHvPSV35N/Mfk1WXUe\n\tkd8vZKj6azy3gm0e9I7y/AzwcdepQFwIPE7ynIt4qEPK4D0vFqx+V4ut8dnxAJM0Jt\n\tjdtzpSUs4GUUo5vxQwUZXCu4CX3y8rP7Gp/pH/fU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-8-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-8-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 12 Apr 2025 13:50:50 +0100","Message-ID":"<174446225018.722505.6207575815626275600@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34095,"web_url":"https://patchwork.libcamera.org/comment/34095/","msgid":"<174611486835.2882969.10045411344601970569@ping.linuxembedded.co.uk>","date":"2025-05-01T15:54:28","subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-04-12 13:50:50)\n> Quoting Stefan Klug (2025-04-11 13:36:35)\n> > The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\n> \n> Was the bug introduced in 6.13? Or exists only in versions before 6.13 ?\n> or only since?\n> \n> Would probably be helpful/useful to clarify when applying.\n> \n> --\n> Kieran\n> \n> \n> > applied correctly. Add the color space to the debug log output to be\n> > able to detect that now and later.\n> > \n> > Signed-off-by: Stefan Klug \n> > Reviewed-by: Kieran Bingham \n> > \n> > ---\n> > \n> > Changes in v2:\n> > - Collected tag\n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 9d7a3bd57ada..2708cecca0b0 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > \n> > LOG(RkISP1, Debug)\n> > << \"ISP output pad configured with \" << format\n> > - << \" crop \" << outputCrop;\n> > + << \" crop \" << outputCrop\n> > + << \" color space \" << ColorSpace::toString(format.colorSpace);\n\nPerhaps in fact we should change the format type here to report the\ncolorspace as part of it's string as we now do at:\n\n - https://git.libcamera.org/libcamera/libcamera.git/commit/?id=9b50d3c23dea1bc2882cd3e6566a3d4cb9f7296f\n\nwhich produces\n\t1920x1080-YUYV/sYCC\n\nstyle strings ?\n\n--\nKieran\n\n\n> > \n> > IPACameraSensorInfo sensorInfo;\n> > ret = data->sensor_->sensorInfo(&sensorInfo);\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49889C327D\n\tfor ;\n\tThu, 1 May 2025 15:54:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85EA368AD0;\n\tThu, 1 May 2025 17:54:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D1D8617D7\n\tfor ;\n\tThu, 1 May 2025 17:54:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E2A21E3;\n\tThu, 1 May 2025 17:54:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TZ7rh5GP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746114864;\n\tbh=JFwvmMhQ7ZpiWaEau8GJRCAtIyCJXFaZHe4s98c6RCA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TZ7rh5GPdGIkizLv3tKgNB03Dtq9IErUNGZvN5XRWyzbFS+VmSoTg8FAuu6jDo/Rg\n\ti3Sn0xyIBBlp5yEHrpHazJMUjYbCQ+vommLe2WK9GKeB0H1DVnQVmNvkxvlu7+sPDk\n\tPmCBvIOle0MFPpZvSvjSnHPhddBZP5I0ufxJZhGg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<174446225018.722505.6207575815626275600@ping.linuxembedded.co.uk>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-8-stefan.klug@ideasonboard.com>\n\t<174446225018.722505.6207575815626275600@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 01 May 2025 16:54:28 +0100","Message-ID":"<174611486835.2882969.10045411344601970569@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34190,"web_url":"https://patchwork.libcamera.org/comment/34190/","msgid":"<174700114682.116187.16559498899332962864@pyrite.rasen.tech>","date":"2025-05-11T22:05:46","subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 14:36:35)\n> The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\n\ns/the the/where the/\n\nI parse this as \"6.13 and earlier\" versions all have the bug; if this is\ncorrect then good. Otherwise a clarification might be better as Kieran\nsays.\n\n> applied correctly. Add the color space to the debug log output to be\n> able to detect that now and later.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 9d7a3bd57ada..2708cecca0b0 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \n> LOG(RkISP1, Debug)\n> << \"ISP output pad configured with \" << format\n> - << \" crop \" << outputCrop;\n> + << \" crop \" << outputCrop\n> + << \" color space \" << ColorSpace::toString(format.colorSpace);\n> \n> IPACameraSensorInfo sensorInfo;\n> ret = data->sensor_->sensorInfo(&sensorInfo);\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 552E8C3226\n\tfor ;\n\tSun, 11 May 2025 22:05:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7746768C8D;\n\tMon, 12 May 2025 00:05:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4090768B60\n\tfor ;\n\tMon, 12 May 2025 00:05:50 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CE698FA;\n\tMon, 12 May 2025 00:05:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sCF9kfvx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747001135;\n\tbh=v9iFK64JVMRt8QjV4yQsu83SyaMnDyzvSfUYejwUwKA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sCF9kfvxW2gvs2W/V4uw5UzRvlOAWqpZBCXFUdBTTt//wAjn+D0a87BIRYE+jLE/E\n\tlZuC2gCTZdtWoecueCWnj3uIZTzoXLa2UlxnU2Kq3nAFTe3Vm7s5BK6HpRen8jW62t\n\trjh3skiIaom7mSYcqBndkov9FxG8q7Nwu156a6cw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-8-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-8-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 May 2025 00:05:46 +0200","Message-ID":"<174700114682.116187.16559498899332962864@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34191,"web_url":"https://patchwork.libcamera.org/comment/34191/","msgid":"<20250511221749.GO19001@pendragon.ideasonboard.com>","date":"2025-05-11T22:17:49","subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, May 01, 2025 at 04:54:28PM +0100, Kieran Bingham wrote:\n> Quoting Kieran Bingham (2025-04-12 13:50:50)\n> > Quoting Stefan Klug (2025-04-11 13:36:35)\n> > > The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\n> > \n> > Was the bug introduced in 6.13? Or exists only in versions before 6.13 ?\n> > or only since?\n> > \n> > Would probably be helpful/useful to clarify when applying.\n> > \n> > > applied correctly. Add the color space to the debug log output to be\n> > > able to detect that now and later.\n> > > \n> > > Signed-off-by: Stefan Klug \n> > > Reviewed-by: Kieran Bingham \n> > > \n> > > ---\n> > > \n> > > Changes in v2:\n> > > - Collected tag\n> > > ---\n> > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n> > > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > index 9d7a3bd57ada..2708cecca0b0 100644\n> > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > > \n> > > LOG(RkISP1, Debug)\n> > > << \"ISP output pad configured with \" << format\n> > > - << \" crop \" << outputCrop;\n> > > + << \" crop \" << outputCrop\n> > > + << \" color space \" << ColorSpace::toString(format.colorSpace);\n> \n> Perhaps in fact we should change the format type here to report the\n> colorspace as part of it's string as we now do at:\n> \n> - https://git.libcamera.org/libcamera/libcamera.git/commit/?id=9b50d3c23dea1bc2882cd3e6566a3d4cb9f7296f\n> \n> which produces\n> \t1920x1080-YUYV/sYCC\n> \n> style strings ?\n\nOr better, add the colorspace to\n\nstd::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f);\n\n> > > \n> > > IPACameraSensorInfo sensorInfo;\n> > > ret = data->sensor_->sensorInfo(&sensorInfo);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDAF6C3200\n\tfor ;\n\tSun, 11 May 2025 22:17:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DEE068C8E;\n\tMon, 12 May 2025 00:17:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 149CA68B4F\n\tfor ;\n\tMon, 12 May 2025 00:17:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(static-176-133-119-130.ftth.abo.bbox.fr [176.133.119.130])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63BA88FA;\n\tMon, 12 May 2025 00:17:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gq4Wo+kY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747001862;\n\tbh=27fGqr76C6OUk2T4TeTok/VO3Du4p67PpTsi65jMj5w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gq4Wo+kYgF9ckI4qzD+TA3YSxQE7Wz04DcuuED35hknSb63AIAY5+wjfdRSmC732b\n\txI4jHmQnqcqatRJSCEyTUJ6FSyoLRlMM72csCM8smkINBvpXhtDvUzgdhKFi0Tdqxl\n\ttV1CAkbmxgCBUK31QJZv18ntT6gYpPmY+rIjttCM=","Date":"Mon, 12 May 2025 00:17:49 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","Message-ID":"<20250511221749.GO19001@pendragon.ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-8-stefan.klug@ideasonboard.com>\n\t<174446225018.722505.6207575815626275600@ping.linuxembedded.co.uk>\n\t<174611486835.2882969.10045411344601970569@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174611486835.2882969.10045411344601970569@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]