{"id":23163,"url":"https://patchwork.libcamera.org/api/patches/23163/?format=json","web_url":"https://patchwork.libcamera.org/patch/23163/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250411123641.2144530-7-stefan.klug@ideasonboard.com>","date":"2025-04-11T12:36:34","name":"[v2,6/9] pipeline: rkisp1: Add more info when parameter queue fails","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"716e25f9ee3ef687a5f8a40af2f4d8a33b008727","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23163/mbox/","series":[{"id":5121,"url":"https://patchwork.libcamera.org/api/series/5121/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5121","date":"2025-04-11T12:36:28","name":"Wdr preparations","version":2,"mbox":"https://patchwork.libcamera.org/series/5121/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23163/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23163/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF2BBC327D\n\tfor ;\n\tFri, 11 Apr 2025 12:37:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AE3E68A90;\n\tFri, 11 Apr 2025 14:37:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A676968A90\n\tfor ;\n\tFri, 11 Apr 2025 14:37:03 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57C8B1E6;\n\tFri, 11 Apr 2025 14:35:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pBcJhOOg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744374904;\n\tbh=hEjttf+X0Z3Ha2p/Z8webfyhIN8pceaFTmQC/BEddRs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pBcJhOOgnuprPRhqKUL9D6PqSL8dViMZ1gmEmFCIOTDkCb87jbEKRr8B8deHIQQMM\n\tpj4OoWV8EQu/p8b7YXcONjCFHXBUAAIuQdmhyXd04WfxOVrnqVG1p/oK4OMYmd8rdP\n\tsydhUNd0X9Xdc/RG43QgFRt3h+nNzgaMZ875qRzQ=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 6/9] pipeline: rkisp1: Add more info when parameter queue\n\tfails","Date":"Fri, 11 Apr 2025 14:36:34 +0200","Message-ID":"<20250411123641.2144530-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the rkisp1 driver of the running kernel supports less parameter\ntypes than the libcamera build and such a parameter is used, queuing of\nthe parameter buffer fails with -EINVAL. For the time being we have no\nway to query the kernel for supported parameter types at runtime. So at\nleast print a error message that points the user in that direction.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- Also print the error code in case of failure\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 52633fe3cb85..9d7a3bd57ada 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -409,7 +409,15 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\treturn;\n \n \tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n-\tpipe->param_->queueBuffer(info->paramBuffer);\n+\n+\tint ret = pipe->param_->queueBuffer(info->paramBuffer);\n+\tif (ret < 0) {\n+\t\tLOG(RkISP1, Error) << \"Failed to queue parameter buffer: \" << ret\n+\t\t\t\t << \" Maybe the kernel doesn't support the\"\n+\t\t\t\t \" required parameter types.\";\n+\t\treturn;\n+\t}\n+\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n \tif (info->mainPathBuffer)\n","prefixes":["v2","6/9"]}