{"id":23162,"url":"https://patchwork.libcamera.org/api/patches/23162/?format=json","web_url":"https://patchwork.libcamera.org/patch/23162/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250411123641.2144530-6-stefan.klug@ideasonboard.com>","date":"2025-04-11T12:36:33","name":"[v2,5/9] ipa: rkisp1: params: Check for empty parameters","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"184195b3b86f131055a9dd70df3d9dcc0f941a6d","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23162/mbox/","series":[{"id":5121,"url":"https://patchwork.libcamera.org/api/series/5121/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5121","date":"2025-04-11T12:36:28","name":"Wdr preparations","version":2,"mbox":"https://patchwork.libcamera.org/series/5121/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23162/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23162/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC5F3C327D\n\tfor ;\n\tFri, 11 Apr 2025 12:37:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7848168AB4;\n\tFri, 11 Apr 2025 14:37:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A27A968AA8\n\tfor ;\n\tFri, 11 Apr 2025 14:37:00 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 568D2667;\n\tFri, 11 Apr 2025 14:35:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UbyCELFf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744374901;\n\tbh=xIIy2K0wc7Ph23MpdCUr7Hu+hQJBMLVpuxN9xA/bXbE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UbyCELFf/wpd8lcKtkV2Adge9bQUr1055y8583u0tdsVF+KZWAvHBZrd+vTD8LpM8\n\tbtO28pIxfpxTzla7OXP4wumfzqKr5RsGwtDJ/jbfgWyYXQCMA8peI5Q7QfSU2APsdp\n\tFHzy+2j3Zq4tDPy+uC0mx0zx97IEvQTt8tJd7tKw=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 5/9] ipa: rkisp1: params: Check for empty parameters","Date":"Fri, 11 Apr 2025 14:36:33 +0200","Message-ID":"<20250411123641.2144530-6-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add functions to check for empty parameter blocks. Modify the constructor\nso that a parameter block constructed from an empty span stays empty.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- Removed unrelated get() functions\n---\n src/ipa/rkisp1/params.cpp | 3 +++\n src/ipa/rkisp1/params.h | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\nindex 4c0b051ce65d..b4a889e415fc 100644\n--- a/src/ipa/rkisp1/params.cpp\n+++ b/src/ipa/rkisp1/params.cpp\n@@ -82,6 +82,9 @@ RkISP1ParamsBlockBase::RkISP1ParamsBlockBase(RkISP1Params *params, BlockType typ\n \t\t\t\t\t const Span &data)\n \t: params_(params), type_(type)\n {\n+\tif (data.empty())\n+\t\treturn;\n+\n \tif (params_->format() == V4L2_META_FMT_RK_ISP1_EXT_PARAMS) {\n \t\theader_ = data.subspan(0, sizeof(rkisp1_ext_params_block_header));\n \t\tdata_ = data.subspan(sizeof(rkisp1_ext_params_block_header));\ndiff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\nindex 40450e34497a..04b06c2a6266 100644\n--- a/src/ipa/rkisp1/params.h\n+++ b/src/ipa/rkisp1/params.h\n@@ -89,6 +89,9 @@ public:\n \n \tvoid setEnabled(bool enabled);\n \n+\tbool isValid() const { return !data_.empty(); }\n+\texplicit operator bool() const { return !data_.empty(); }\n+\n private:\n \tLIBCAMERA_DISABLE_COPY(RkISP1ParamsBlockBase)\n \n","prefixes":["v2","5/9"]}