[{"id":34187,"web_url":"https://patchwork.libcamera.org/comment/34187/","msgid":"<174699075399.1551504.1706554262818507331@pyrite.rasen.tech>","date":"2025-05-11T19:12:33","subject":"Re: [PATCH v2 4/9] libipa: agc_mean_luminance: Add debug logging","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 14:36:32)\n> When debugging the AEGC it is important to know when the constraints\n> apply. As this is important information for anyone doing tuning file\n> optimization, add it upstream.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Daniel Scally \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tags\n> ---\n> src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\n> index f617fde81101..9154f083a510 100644\n> --- a/src/ipa/libipa/agc_mean_luminance.cpp\n> +++ b/src/ipa/libipa/agc_mean_luminance.cpp\n> @@ -468,12 +468,16 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n> hist.interQuantileMean(constraint.qLo, constraint.qHi);\n> \n> if (constraint.bound == AgcConstraint::Bound::Lower &&\n> - newGain > gain)\n> + newGain > gain) {\n> gain = newGain;\n> + LOG(AgcMeanLuminance, Debug) << \"Apply lower bound: \" << gain << \" to \" << newGain;\n> + }\n> \n> if (constraint.bound == AgcConstraint::Bound::Upper &&\n> - newGain < gain)\n> + newGain < gain) {\n> gain = newGain;\n> + LOG(AgcMeanLuminance, Debug) << \"Apply upper bound: \" << gain << \" to \" << newGain;\n> + }\n> }\n> \n> return gain;\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67094C3200\n\tfor ;\n\tSun, 11 May 2025 19:12:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B321368B6A;\n\tSun, 11 May 2025 21:12:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34DAA68B69\n\tfor ;\n\tSun, 11 May 2025 21:12:37 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 984E163B;\n\tSun, 11 May 2025 21:12:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pnB1R31V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746990742;\n\tbh=wGvCtvb5tPxAczkCGDie13tJNSgHS6AL14cq4OYSSPY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pnB1R31Vaqlm/egFuGP24tFPXmr9vVdi79jGTlgrv4uwY9ihX95B48c/bpXyowSIi\n\tykO2A1vj62r6IC4IV3SooLQmhK1UuKfaml4PwJ2cP0WsFUPtv7LwuQoHEVlKJA71Nn\n\t/yvQENhU0yk0GFeU8yWcWtbFGz6iCQqV1NKxZid0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-5-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-5-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 4/9] libipa: agc_mean_luminance: Add debug logging","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tDaniel Scally ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 11 May 2025 21:12:33 +0200","Message-ID":"<174699075399.1551504.1706554262818507331@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34192,"web_url":"https://patchwork.libcamera.org/comment/34192/","msgid":"<20250511222401.GP19001@pendragon.ideasonboard.com>","date":"2025-05-11T22:24:01","subject":"Re: [PATCH v2 4/9] libipa: agc_mean_luminance: Add debug logging","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Apr 11, 2025 at 02:36:32PM +0200, Stefan Klug wrote:\n> When debugging the AEGC it is important to know when the constraints\n> apply. As this is important information for anyone doing tuning file\n> optimization, add it upstream.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Daniel Scally \n> \n> ---\n> \n> Changes in v2:\n> - Collected tags\n> ---\n> src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\n> index f617fde81101..9154f083a510 100644\n> --- a/src/ipa/libipa/agc_mean_luminance.cpp\n> +++ b/src/ipa/libipa/agc_mean_luminance.cpp\n> @@ -468,12 +468,16 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n> \t\t\t\t hist.interQuantileMean(constraint.qLo, constraint.qHi);\n> \n> \t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n> -\t\t newGain > gain)\n> +\t\t newGain > gain) {\n> \t\t\tgain = newGain;\n> +\t\t\tLOG(AgcMeanLuminance, Debug) << \"Apply lower bound: \" << gain << \" to \" << newGain;\n\n\t\t\tLOG(AgcMeanLuminance, Debug)\n\t\t\t\t<< \"Apply lower bound: \" << gain << \" to \"\n\t\t\t\t<< newGain;\n\nThe same comment applies to the upper bound.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t}\n> \n> \t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n> -\t\t newGain < gain)\n> +\t\t newGain < gain) {\n> \t\t\tgain = newGain;\n> +\t\t\tLOG(AgcMeanLuminance, Debug) << \"Apply upper bound: \" << gain << \" to \" << newGain;\n> +\t\t}\n> \t}\n> \n> \treturn gain;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5042EC3226\n\tfor ;\n\tSun, 11 May 2025 22:24:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22F5068B6B;\n\tMon, 12 May 2025 00:24:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8757B68B4F\n\tfor ;\n\tMon, 12 May 2025 00:24:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(noh63-h01-176-133-119-130.dsl.sta.abo.bbox.fr [176.133.119.130])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D528E8FA;\n\tMon, 12 May 2025 00:23:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i882kaqH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747002234;\n\tbh=Evqk7dq44Ss+Fzh5Su76ZPaWauAi9C34eozFBxnVN5g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i882kaqH3NsZ5Q+9JXS+c3KkX5/rHt7hvnVnApC/JksxSP1Xvx/DXXE4gTeZ5HatW\n\t6qdCcEkkyWmfxCJdol7JvH8u4X2I6MsdsIVAqnq/K4jbFTyw0LTjdj0nFZ5gd9fScL\n\tNmNZKc1QGICcwez4jO40Vgjl9rfVTMRJGy1StgDY=","Date":"Mon, 12 May 2025 00:24:01 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tDaniel Scally ","Subject":"Re: [PATCH v2 4/9] libipa: agc_mean_luminance: Add debug logging","Message-ID":"<20250511222401.GP19001@pendragon.ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-5-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250411123641.2144530-5-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]