[{"id":34186,"web_url":"https://patchwork.libcamera.org/comment/34186/","msgid":"<174699049437.1551504.10238370392275957485@pyrite.rasen.tech>","date":"2025-05-11T19:08:14","subject":"Re: [PATCH v2 3/9] utils: gen-debug-controls: Improve log output","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 14:36:31)\n> Add log statements for found controls and the file written. This makes\n> it easier to understand what happens under the hood.\n> \n> While at it, create nice colored log out put using coloredlogs if\n> available.\n> \n> Signed-off-by: Stefan Klug \n> Acked-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> utils/gen-debug-controls.py | 15 +++++++++++++--\n> 1 file changed, 13 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\n> index ff22b986475e..a1c69bbd8294 100755\n> --- a/utils/gen-debug-controls.py\n> +++ b/utils/gen-debug-controls.py\n> @@ -17,8 +17,13 @@ import sys\n> from dataclasses import dataclass\n> from pathlib import Path\n> \n> -logger = logging.getLogger(__name__)\n> -logging.basicConfig(level=logging.INFO, format='%(levelname)s: %(message)s')\n> +fmt = '%(levelname)s: %(message)s'\n> +try:\n> + import coloredlogs\n> + coloredlogs.install(level=logging.INFO, fmt=fmt)\n> +except ImportError:\n> + logging.basicConfig(level=logging.INFO, format=fmt)\n> +\n> \n> try:\n> import ruamel.yaml as ruyaml\n> @@ -27,6 +32,8 @@ except:\n> f'Failed to import ruamel.yaml. Please install the ruamel.yaml package.')\n> sys.exit(1)\n> \n> +logger = logging.getLogger(__name__)\n> +\n> @dataclass\n> class FoundMatch:\n> file: os.PathLike\n> @@ -106,6 +113,7 @@ def main(argv):\n> continue\n> \n> p = m.file.relative_to(root_dir)\n> + logger.info(f\"Found control {m.name} in {p}\")\n> desc = {'type': m.type,\n> 'direction': 'out',\n> 'description': f'Debug control {m.name} found in {p}'}\n> @@ -165,6 +173,9 @@ def main(argv):\n> \"#\\n\"))\n> yaml.dump(doc, f)\n> \n> + p = ctrl_file.relative_to(Path.cwd(), walk_up=True)\n> + logger.info(f\"Sucessfully updated {p}\")\n> +\n> return 0\n> \n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AD26C3200\n\tfor ;\n\tSun, 11 May 2025 19:08:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A735E68B66;\n\tSun, 11 May 2025 21:08:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F14FF68B60\n\tfor ;\n\tSun, 11 May 2025 21:08:17 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 535E6B63;\n\tSun, 11 May 2025 21:08:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sU1v+coE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746990483;\n\tbh=5VajSbJBXXyaT9YZWC67+Dfe0bVVB4YjmpBJk0Q8HCI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sU1v+coEdnNypfJ8Zv82qTAlrjjPNumFo2ihRn097hL2W/RtZCrbK0amwg0xBfulO\n\t04fPmKKtdrOJ6jyf9LpACPH9CrMR5WEDDhTF1BOfZr1QXQZ4BsoI0xYoM1I45YV0zd\n\tyZuG0ZNBC9TC+iWNpepO7vyp3nZuGLS0tm+g+Mfc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-4-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 3/9] utils: gen-debug-controls: Improve log output","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 11 May 2025 21:08:14 +0200","Message-ID":"<174699049437.1551504.10238370392275957485@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34246,"web_url":"https://patchwork.libcamera.org/comment/34246/","msgid":"<174731484819.752761.4866232827831726265@isaac-ThinkPad-T16-Gen-2>","date":"2025-05-15T13:14:08","subject":"Re: [PATCH v2 3/9] utils: gen-debug-controls: Improve log output","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Stefan,\n\nQuoting Stefan Klug (2025-04-11 13:36:31)\n> Add log statements for found controls and the file written. This makes\n> it easier to understand what happens under the hood.\n> \n> While at it, create nice colored log out put using coloredlogs if\n> available.\n> \n> Signed-off-by: Stefan Klug \n> Acked-by: Kieran Bingham \n> \n\nReviewed-by: Isaac Scott \n\n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> utils/gen-debug-controls.py | 15 +++++++++++++--\n> 1 file changed, 13 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\n> index ff22b986475e..a1c69bbd8294 100755\n> --- a/utils/gen-debug-controls.py\n> +++ b/utils/gen-debug-controls.py\n> @@ -17,8 +17,13 @@ import sys\n> from dataclasses import dataclass\n> from pathlib import Path\n> \n> -logger = logging.getLogger(__name__)\n> -logging.basicConfig(level=logging.INFO, format='%(levelname)s: %(message)s')\n> +fmt = '%(levelname)s: %(message)s'\n> +try:\n> + import coloredlogs\n> + coloredlogs.install(level=logging.INFO, fmt=fmt)\n> +except ImportError:\n> + logging.basicConfig(level=logging.INFO, format=fmt)\n> +\n> \n> try:\n> import ruamel.yaml as ruyaml\n> @@ -27,6 +32,8 @@ except:\n> f'Failed to import ruamel.yaml. Please install the ruamel.yaml package.')\n> sys.exit(1)\n> \n> +logger = logging.getLogger(__name__)\n> +\n> @dataclass\n> class FoundMatch:\n> file: os.PathLike\n> @@ -106,6 +113,7 @@ def main(argv):\n> continue\n> \n> p = m.file.relative_to(root_dir)\n> + logger.info(f\"Found control {m.name} in {p}\")\n> desc = {'type': m.type,\n> 'direction': 'out',\n> 'description': f'Debug control {m.name} found in {p}'}\n> @@ -165,6 +173,9 @@ def main(argv):\n> \"#\\n\"))\n> yaml.dump(doc, f)\n> \n> + p = ctrl_file.relative_to(Path.cwd(), walk_up=True)\n> + logger.info(f\"Sucessfully updated {p}\")\n> +\n> return 0\n> \n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55C19C3200\n\tfor ;\n\tThu, 15 May 2025 13:14:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A966468B70;\n\tThu, 15 May 2025 15:14:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE3D168B4F\n\tfor ;\n\tThu, 15 May 2025 15:14:15 +0200 (CEST)","from thinkpad.ideasonboard.com (unknown\n\t[IPv6:2a01:cb16:204c:4644:3f69:4c6e:7066:a222])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11857886;\n\tThu, 15 May 2025 15:13:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WwWh/tek\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747314838;\n\tbh=Y0Idw7RxWonLv+UJu357I6nJrL4IJGRuVh8uW7gN8dE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=WwWh/tekTlkRDXlxAv3eeC97UMAVCOsaViVTk7TkVaJT/c8AMBhkR75MvTM/89cn7\n\t1z523tz0Heeau3Rhx3kuL7t/j9i+I5zntKdDOErqW+951bhYtOQPBEXKSGYe8jVZmd\n\tq9AWMos68oayccbmOz9s/bRBi2Qn2eGdOzeotakE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-4-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 3/9] utils: gen-debug-controls: Improve log output","From":"Isaac Scott ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 15 May 2025 14:14:08 +0100","Message-ID":"<174731484819.752761.4866232827831726265@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]